n800 build error in clock24xx.c: 'secure_32k_ck' undeclared
Hello,
I'm trying to compile n800 kernel with latest linux-omap tree. First I got strange build error:
arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc' arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a cast arch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree' arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast
Adding include <linux/slab.h> made it go away but then I got this:
In file included from arch/arm/mach-omap2/clock24xx.c:46:arch/arm/mach-omap2/clock24xx.h:1801: error: 'secure_32k_ck' undeclared here (not in a function)
Any hints?
The latest commit I have is:
commit 8e58316ba38aa6ffd53e2ada59142ad40cf47744
Merge: 1232332 0932667
Author: Tony Lindgren <[email protected]>
Date: Wed Apr 15 11:22:24 2009 -0700
Merge branch 'omap-pool'
Signature · 1 line
Kalle Valo
Kalle Valo wrote at 2009-04-17 14:44 -0600:
Quoted 2 lines
I'm trying to compile n800 kernel with latest linux-omap tree. First I got strange build error:
Here too, on n810.
Quoted 6 lines
arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a castarch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast
I see nearly the same:
arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_epoll_wait’:arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function ‘kmalloc’ arch/arm/kernel/sys_oabi-compat.c:288: error: ‘GFP_KERNEL’ undeclared (first use in this function) arch/arm/kernel/sys_oabi-compat.c:288: error: (Each undeclared identifier is reported only once arch/arm/kernel/sys_oabi-compat.c:288: error: for each function it appears in.) arch/arm/kernel/sys_oabi-compat.c:288: warning: assignment makes pointer from integer without a cast arch/arm/kernel/sys_oabi-compat.c:301: error: implicit declaration of function ‘kfree’ arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_semtimedop’:arch/arm/kernel/sys_oabi-compat.c:324: error: ‘GFP_KERNEL’ undeclared (first use in this function) arch/arm/kernel/sys_oabi-compat.c:324: warning: assignment makes pointer from integer without a cast
Quoted 9 lines · green
Kalle Valo wrote at 2009-04-17 14:44 -0600:
Quoted 6 lines
arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a castarch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast
Quoted 5 lines
I see nearly the same:
arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_epoll_wait’:arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function ‘kmalloc’arch/arm/kernel/sys_oabi-compat.c:288: error: ‘GFP_KERNEL’ undeclared (first use in this function)
I think that's the same error. Most probably my tree was dirty and that's the line numbers are different.
Signature · 5 lines
Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Kalle Valo wrote at 2009-04-19 09:58 -0600:
Quoted 11 lines
Quoted 9 lines · green
Kalle Valo wrote at 2009-04-17 14:44 -0600:
Quoted 6 lines
arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a castarch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a cast
Quoted 8 lines
Quoted 5 lines
I see nearly the same:
arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_epoll_wait’:arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function ‘kmalloc’arch/arm/kernel/sys_oabi-compat.c:288: error: ‘GFP_KERNEL’ undeclared (first use in this function)I think that's the same error. Most probably my tree was dirty and that's the line numbers are different.
I was noticing the 'GFP_KERNEL' undeclared error rather than the line numbers.
Tony Lindgren
maintainerQuoted 14 lines · green
Kalle Valo wrote at 2009-04-19 09:58 -0600:
Quoted 13 lines
Quoted 11 lines · green
Kalle Valo wrote at 2009-04-17 14:44 -0600:
Quoted 6 lines
arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':arch/arm/kernel/sys_oabi-compat.c:289: error: implicit declaration of function 'kmalloc'arch/arm/kernel/sys_oabi-compat.c:289: warning: assignment makes pointer from integer without a castarch/arm/kernel/sys_oabi-compat.c:302: error: implicit declaration of function 'kfree'arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':arch/arm/kernel/sys_oabi-compat.c:325: warning: assignment makes pointer from integer without a castI see nearly the same:
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
arch/arm/kernel/sys_oabi-compat.c: In function ‘sys_oabi_epoll_wait’:arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function ‘kmalloc’arch/arm/kernel/sys_oabi-compat.c:288: error: ‘GFP_KERNEL’ undeclared (first use in this function)I think that's the same error. Most probably my tree was dirty and that's the line numbers are different.
I was noticing the '
GFP_KERNEL' undeclared error rather than the line numbers.
Looks like the above is fixed by cbb55092a674bcfd9774637a06d0f1511763aa2c, I'll git cherry-pick that one.
The secure_32k_ck is still undefined though.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Paul Walmsley
maintainerHi Kalle,
Quoted 4 lines · Kalle Valo
In file included from
arch/arm/mach-omap2/clock24xx.c:46:arch/arm/mach-omap2/clock24xx.h:1801: error: 'secure_32k_ck' undeclared here (not in a function)Any hints?
This is a bug in the version of fa9ef57a1efdd4e7c41a42db71d99b9b69e9b356 I pushed. The new clock definition in clock24xx.h for "secure_32k_fck" should be for "secure_32k_ck". Just talked with Tony about this; he's going to re-pull a fixed version of that patch today.
Thanks for the find,
- Paul
Paul Walmsley
maintainerQuoted 11 lines · Paul Walmsley
Quoted 4 lines · Kalle Valo
In file included from
arch/arm/mach-omap2/clock24xx.c:46:arch/arm/mach-omap2/clock24xx.h:1801: error: 'secure_32k_ck' undeclared here (not in a function)Any hints?
This is a bug in the version of
fa9ef57a1efdd4e7c41a42db71d99b9b69e9b356I pushed. The new clock definition inclock24xx.hfor "secure_32k_fck" should be for "secure_32k_ck". Just talked with Tony about this; he's going to re-pull a fixed version of that patch today.
Here's the patch BTW:
- Paul
arch/arm/mach-omap2/clock24xx.h +2 -2
@@ -625,8 +625,8 @@ static struct clk func_32k_ck = { .clkdm_name = "wkup_clkdm", }; -static struct clk secure_32k_fck = { - .name ="secure_32k_fck" , +static struct clk secure_32k_ck = { + .name ="secure_32k_ck" , .ops = &clkops_null, .rate =32768 , .flags =RATE_FIXED ,
Tony Lindgren
maintainer[APPLIED] n800 build error in clock24xx.c: 'secure_32k_ck' undeclared
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Initial commit ID (Likely to change): dc1ac9cea15e3317badd0fdece931926413f6759
PatchWorks
http://patchwork.kernel.org/patch/19037/
Quoted 1 line · Paul Walmsley
Hi Kalle,
Hi Paul,
sorry for a late answer.
Quoted 11 lines · Kalle Valo
Quoted 5 lines
arch/arm/mach-omap2/clock24xx.h:1801: error: 'secure_32k_ck' undeclared here (not in a function)Any hints?
This is a bug in the version of
fa9ef57a1efdd4e7c41a42db71d99b9b69e9b356I pushed. The new clock definition inclock24xx.hfor "secure_32k_fck" should be for "secure_32k_ck". Just talked with Tony about this; he's going to re-pull a fixed version of that patch today.
I updated to latest linux-omap (commit 55b1274c). It now compiles and boots on N800.
Thank you for fixing this.
Signature · 1 line
Kalle Valo