Skip to contentSkip to conversation

xfstests: skip dump tests if dump utils not found

PATCH In review Eric Sandeen 4 participants 7 messages Apr 19, 2009 – Apr 21, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: skip dump tests if dump utils not found

I was running xfstests on a NAS box which had no xfsdump, and any tests which required xfsdump were failing in not-so-nice ways:

Quoted 1 line

xfsdump not found

038 [failed, exit status 1] - output mismatch (see 038.out.bad)

I think using _notrun is a lot better:

038 [not run] xfsdump not found

---

common.dump +3 -3
index 6d2f120..fcc4945 100644
@@ -23,9 +23,9 @@ if [ -n "$DEBUGDUMP" ]; then
 	[ -x $here/xfsinvutil ] && echo "Using xfstests' xfsinvutil for debug"
 fi
 
-[ "$XFSDUMP_PROG" = "" ]    && _fatal "xfsdump not found"
-[ "$XFSRESTORE_PROG" = "" ] && _fatal "xfsrestore not found"
-[ "$XFSINVUTIL_PROG" = "" ] && _fatal "xfsinvutil not found"
+[ "$XFSDUMP_PROG" = "" ]    && _notrun "xfsdump not found"
+[ "$XFSRESTORE_PROG" = "" ] && _notrun "xfsrestore not found"
+[ "$XFSINVUTIL_PROG" = "" ] && _notrun "xfsinvutil not found"
 
 # status returned for not run tests
 NOTRUNSTS=2

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 4 lines · Eric Sandeen

I was running xfstests on a NAS box which had no xfsdump, and any tests which required xfsdump were failing in not-so-nice ways:

Quoted 8 lines
Quoted 1 line

xfsdump not found

038 [failed, exit status 1] - output mismatch (see 038.out.bad)

I think using _notrun is a lot better:

038 [not run] xfsdump not found

Looks good.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
In reply to Eric Sandeen
Quoted 4 lines · Eric Sandeen

I was running xfstests on a NAS box which had no xfsdump, and any tests which required xfsdump were failing in not-so-nice ways:

Quoted 8 lines
Quoted 1 line

xfsdump not found

038 [failed, exit status 1] - output mismatch (see 038.out.bad)

I think using _notrun is a lot better:

038 [not run] xfsdump not found

Sounds good.

Josef 'Jeff' Sipek.

Signature · 7 lines
Bad pun of the week: The formula 1 control computer suffered from a race
condition

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#3 lore raw

PATCH 1/1 xfstests: skip fsr tests if xfs_fsr utils not found

In reply to Eric Sandeen

Similar to the xfsdump-related patch; gracefully fail if no xfs_fsr is found.

I'll probably send another for the acl & attr userspace, it's actually not always installed on minimal boxes.

---

042 +2 -0
index 7c2bcac..6628040 100755
@@ -37,6 +37,8 @@ _supported_os IRIX Linux
 
 _require_scratch
 
+[ "$XFS_FSR_PROG" = "" ] && _notrun "xfs_fsr not found"
+
 _cull_files()
 {
     perl -e "\$manifest=\"$tmp.manifest\";" -e '
111 +2 -0
index 060c0bc..3ce4ee1 100755
@@ -27,6 +27,8 @@ _supported_fs xfs
 _supported_os Linux
 _require_scratch
 
+[ "$XFS_FSR_PROG" = "" ] && _notrun "xfs_fsr not found"
+
 # real QA test starts here
 umount $SCRATCH_DEV 2>/dev/null
 MKFS_OPTIONS="-bsize=4096"

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#4 lore raw

Re: [PATCH] xfstests: skip fsr tests if xfs_fsr utils not found

Quoted 7 lines · Eric Sandeen

Similar to the xfsdump-related patch; gracefully fail if no xfs_fsr is found.

I'll probably send another for the acl & attr userspace, it's actually not always installed on minimal boxes.

Looks good.

Felix

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#6 lore raw
In reply to Eric Sandeen
Quoted 4 lines · Eric Sandeen

I was running xfstests on a NAS box which had no xfsdump, and any tests which required xfsdump were failing in not-so-nice ways:

Quoted 8 lines
Quoted 1 line

xfsdump not found

038 [failed, exit status 1] - output mismatch (see 038.out.bad)

I think using _notrun is a lot better:

038 [not run] xfsdump not found

Seems good.

Felix

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs