[0904_13] Siano: move DVB_API and remove redundant code

PATCH Uri Shkolnik 2 participants 2 messages Apr 20, 2009 Media (V4L/DVB)

Share & tools

Uri Shkolnik

author

2009-04-20 18:08 UTC #0 lore raw

Quoted 111 lines · Mauro Carvalho Chehab

From: Mauro Carvalho Chehab <[email protected]>
Subject: Re: [PATCH] [0904_13] Siano: move DVB_API and remove redundant code
To: "Uri Shkolnik" <[email protected]>
Cc: "LinuxML" <[email protected]>
Date: Monday, April 20, 2009, 9:02 PM
On Sun, 5 Apr 2009 03:31:32 -0700
(PDT)
Uri Shkolnik <[email protected]>
Quoted 6 lines · wrote:
# HG changeset patch
# User Uri Shkolnik <[email protected]>
# Date 1238755204 -10800
# Node ID f65a29f0f9a66f82a91525ae0085a15f00ac91c2 # Parent
897669fdeb3be75a2bde978557b5398a4a7d8914
Quoted 1 line
[PATCH] [0904_13] Siano: move DVB_API and remove
redundant code
Quoted 4 lines
From: Uri Shkolnik <[email protected]>
The DVB-API related information has been moved from
the core header
Quoted 1 line
to the smsdvb, and the redundant code has been removed
from the
Quoted 4 lines
core header.
This code has been moved since it is used only by
the smsdvb client component.
This patch depends on the previous patches that I asked some changes. Please
re-submit it together with the other patches that weren't committed. It is
probably not much valuable to commit the later patches, so I'll stop analysing
the code here.
The patch itself looks sane to my eyes.
Quoted 6 lines
Priority: normal
Signed-off-by Uri Shkolnik <[email protected]>
diff -r 897669fdeb3b -r f65a29f0f9a6
linux/drivers/media/dvb/siano/smscoreapi.h
Quoted 1 line
---
a/linux/drivers/media/dvb/siano/smscoreapi.h
Fri Apr 03 13:31:13 2009 +0300
Quoted 1 line
+++
b/linux/drivers/media/dvb/siano/smscoreapi.h
Fri Apr 03 13:40:04 2009 +0300
Review along with this program. If
Quoted 1 line
(quoted diff) +0 -0
@@ -36,15 +36,6 @@ along with this program.  If
not, see <h
Quoted 12 lines
(quoted diff) +0 -0
   #include <asm/page.h>
/* #include "smsir.h" */
(quoted diff) +0 -9
-
-#define SMS_DVB3_SUBSYS
-#ifdef SMS_DVB3_SUBSYS
-#include "dmxdev.h"
-#include "dvbdev.h"
-#include "dvb_demux.h"
-#include "dvb_frontend.h"
-
-#endif
Quoted 4 lines

#define kmutex_init(_p_) mutex_init(_p_)
#define kmutex_lock(_p_) mutex_lock(_p_)
diff -r 897669fdeb3b -r f65a29f0f9a6
linux/drivers/media/dvb/siano/smsdvb.c
Quoted 1 line
---
a/linux/drivers/media/dvb/siano/smsdvb.c
Fri Apr 03 13:31:13 2009 +0300
Quoted 1 line
+++
b/linux/drivers/media/dvb/siano/smsdvb.c
Fri Apr 03 13:40:04 2009 +0300
Review along with this program. If
Quoted 1 line
(quoted diff) +0 -0
@@ -22,6 +22,11 @@ along with this program.  If
not, see <h
Quoted 12 lines
(quoted diff) +5 -0
   #include <linux/module.h>
   #include <linux/init.h>
   #include <asm/byteorder.h>
+
+#include "dmxdev.h"
+#include "dvbdev.h"
+#include "dvb_demux.h"
+#include "dvb_frontend.h"
#include "smscoreapi.h"
/*#include "smsendian.h"*/
Review struct smsdvb_client_t { · line 58
Quoted 2 lines
(quoted diff) +0 -0
@@ -52,7 +57,7 @@ struct smsdvb_client_t {
       fe_status_t fe_status;
       int fe_ber, fe_snr, fe_unc,
fe_signal_strength;
Quoted 2 lines

-    struct completion tune_done,
stat_done;
Quoted 3 lines
+    struct completion tune_done;

    /* todo: save freq/band
instead whole struct */
Quoted 1 line
    struct
dvb_frontend_parameters fe_params;
Quoted 6 lines

--
To unsubscribe from this list: send the line
"unsubscribe linux-media" in

Quoted 9 lines

Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
Mauro

I'll submit patches to fix the various rejects on the coming Wednesday (I'm ooo tomorrow).

BTW - is it possible for me to clone the current tree you currently have? (after applying the approved patches), it will help me for future patches.

Regards,

Uri

Mauro Carvalho Chehab

2009-04-20 18:19 UTC #1 lore raw

Quoted 126 lines · On Mon, 20 Apr 2009 11:07:57 -0700 (PDT) Uri Shkolnik <[email protected]> wrote:

Quoted 111 lines · Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <[email protected]>
Subject: Re: [PATCH] [0904_13] Siano: move DVB_API and remove redundant code
To: "Uri Shkolnik" <[email protected]>
Cc: "LinuxML" <[email protected]>
Date: Monday, April 20, 2009, 9:02 PM
On Sun, 5 Apr 2009 03:31:32 -0700
(PDT)
Uri Shkolnik <[email protected]>
Quoted 6 lines · wrote:
# HG changeset patch
# User Uri Shkolnik <[email protected]>
# Date 1238755204 -10800
# Node ID f65a29f0f9a66f82a91525ae0085a15f00ac91c2 # Parent
897669fdeb3be75a2bde978557b5398a4a7d8914
Quoted 1 line
[PATCH] [0904_13] Siano: move DVB_API and remove
redundant code
Quoted 4 lines
From: Uri Shkolnik <[email protected]>
The DVB-API related information has been moved from
the core header
Quoted 1 line
to the smsdvb, and the redundant code has been removed
from the
Quoted 4 lines
core header.
This code has been moved since it is used only by
the smsdvb client component.
This patch depends on the previous patches that I asked some changes. Please
re-submit it together with the other patches that weren't committed. It is
probably not much valuable to commit the later patches, so I'll stop analysing
the code here.
The patch itself looks sane to my eyes.
Quoted 6 lines
Priority: normal
Signed-off-by Uri Shkolnik <[email protected]>
diff -r 897669fdeb3b -r f65a29f0f9a6
linux/drivers/media/dvb/siano/smscoreapi.h
Quoted 1 line
---
a/linux/drivers/media/dvb/siano/smscoreapi.h
Fri Apr 03 13:31:13 2009 +0300
Quoted 1 line
+++
b/linux/drivers/media/dvb/siano/smscoreapi.h
Fri Apr 03 13:40:04 2009 +0300
Review along with this program. If
Quoted 1 line
(quoted diff) +0 -0
@@ -36,15 +36,6 @@ along with this program.  If
not, see <h
Quoted 12 lines
(quoted diff) +0 -0
   #include <asm/page.h>
/* #include "smsir.h" */
(quoted diff) +0 -9
-
-#define SMS_DVB3_SUBSYS
-#ifdef SMS_DVB3_SUBSYS
-#include "dmxdev.h"
-#include "dvbdev.h"
-#include "dvb_demux.h"
-#include "dvb_frontend.h"
-
-#endif
Quoted 4 lines

#define kmutex_init(_p_) mutex_init(_p_)
#define kmutex_lock(_p_) mutex_lock(_p_)
diff -r 897669fdeb3b -r f65a29f0f9a6
linux/drivers/media/dvb/siano/smsdvb.c
Quoted 1 line
---
a/linux/drivers/media/dvb/siano/smsdvb.c
Fri Apr 03 13:31:13 2009 +0300
Quoted 1 line
+++
b/linux/drivers/media/dvb/siano/smsdvb.c
Fri Apr 03 13:40:04 2009 +0300
Review along with this program. If
Quoted 1 line
(quoted diff) +0 -0
@@ -22,6 +22,11 @@ along with this program.  If
not, see <h
Quoted 12 lines
(quoted diff) +5 -0
   #include <linux/module.h>
   #include <linux/init.h>
   #include <asm/byteorder.h>
+
+#include "dmxdev.h"
+#include "dvbdev.h"
+#include "dvb_demux.h"
+#include "dvb_frontend.h"
#include "smscoreapi.h"
/*#include "smsendian.h"*/
Review struct smsdvb_client_t { · line 58
Quoted 2 lines
(quoted diff) +0 -0
@@ -52,7 +57,7 @@ struct smsdvb_client_t {
       fe_status_t fe_status;
       int fe_ber, fe_snr, fe_unc,
fe_signal_strength;
Quoted 2 lines

-    struct completion tune_done,
stat_done;
Quoted 3 lines
+    struct completion tune_done;

    /* todo: save freq/band
instead whole struct */
Quoted 1 line
    struct
dvb_frontend_parameters fe_params;
Quoted 6 lines

--
To unsubscribe from this list: send the line
"unsubscribe linux-media" in
Quoted 9 lines
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
Mauro

Quoted 5 lines

OK
I'll submit patches to fix the various rejects on the coming Wednesday (I'm ooo tomorrow).
BTW - is it possible for me to clone the current tree you currently have? (after applying the approved patches), it will help me for future patches.

Sure. The better is to apply your patches over the fresh clone. You can use the ./hgimport script to help you to pick the patches from your old tree.

Cheers,
Mauro