Skip to contentSkip to conversation

usb gadget: fix ethernet link reports to ethtool

PATCH In review David Brownell 2 participants 4 messages Apr 17, 2009 – Apr 21, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/22 usb gadget: fix ethernet link reports to ethtool

Hmm, I should probably try to cc netdev on some of these patches. They're fairly infrequent any more, but...

Likewise, it'd be good to get cc'd from netdev on patches that affect drivers/usb/gadget ... I was very recently surprised to see a "phonet" driver just appear.

- Dave

---------- Forwarded Message ----------

Subject: [PATCH 01/22] usb gadget: fix ethernet link reports to ethtool
Date: Friday 17 April 2009
From: "Greg Kroah-Hartman" <[email protected]>
To: [email protected]

From: Jonathan McDowell <[email protected]>

The g_ether USB gadget driver currently decides whether or not there's a link to report back for eth_get_link based on if the USB link speed is set. The USB gadget speed is however often set even before the device is enumerated. It seems more sensible to only report a "link" if we're actually connected to a host that wants to talk to us. The patch below does this for me - tested with the PXA27x UDC driver.

---
 drivers/usb/gadget/u_ether.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
drivers/usb/gadget/u_ether.c +1 -7
index 96d65ca..4007770 100644
@@ -175,12 +175,6 @@ static void eth_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *p)
 	strlcpy(p->bus_info, dev_name(&dev->gadget->dev), sizeof p->bus_info);
 }
 
-static u32 eth_get_link(struct net_device *net)
-{
-	struct eth_dev	*dev = netdev_priv(net);
-	return dev->gadget->speed != USB_SPEED_UNKNOWN;
-}
-
 /* REVISIT can also support:
  *   - WOL (by tracking suspends and issuing remote wakeup)
  *   - msglevel (implies updated messaging)
@@ -189,7 +183,7 @@ static u32 eth_get_link(struct net_device *net)
 
 static struct ethtool_ops ops = {
 	.get_drvinfo = eth_get_drvinfo,
-	.get_link = eth_get_link
+	.get_link = ethtool_op_get_link,
 };
 
 static void defer_kevent(struct eth_dev *dev, int flag)
Signature · 4 lines
1.6.2


-------------------------------------------------------
maintainer
#1 lore raw

From: David Brownell <[email protected]>
Date: Fri, 17 Apr 2009 12:45:14 -0700

Quoted 6 lines

Hmm, I should probably try to cc netdev on some of these patches. They're fairly infrequent any more, but...

Likewise, it'd be good to get cc'd from netdev on patches that affect drivers/usb/gadget ... I was very recently surprised to see a "phonet" driver just appear.

David, want me to add this patch to net-2.6?

#2 lore raw
Quoted 11 lines · David Miller

From: David Brownell <[email protected]>
Date: Fri, 17 Apr 2009 12:45:14 -0700

Quoted 6 lines

Hmm, I should probably try to cc netdev on some of these patches. They're fairly infrequent any more, but...

Likewise, it'd be good to get cc'd from netdev on patches that affect drivers/usb/gadget ... I was very recently surprised to see a "phonet" driver just appear.

David, want me to add this patch to net-2.6?

No, it's already gone to Linus and merged. This was just a FYI.

maintainer
#3 lore raw

From: David Brownell <[email protected]>
Date: Tue, 21 Apr 2009 02:15:21 -0700

Quoted 7 lines · David Miller
Quoted 6 lines

From: David Brownell <[email protected]>
Date: Fri, 17 Apr 2009 12:45:14 -0700

Quoted 3 lines

Hmm, I should probably try to cc netdev on some of these patches. They're fairly infrequent any more, but...

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Likewise, it'd be good to get cc'd from netdev on patches that affect drivers/usb/gadget ... I was very recently surprised to see a "phonet" driver just appear.

David, want me to add this patch to net-2.6?

No, it's already gone to Linus and merged. This was just a FYI.

Ok, thanks David.