non working tests on unsigned f->pseudoflavor
Subsystems (2)
vi include/linux/nfsd/export.h +77
and note that struct exp_flavor_info f->pseudoflavor in secinfo_parse() is unsigned. Should there maybe be a test:
if (f->pseudoflavor > MAX)
(and what should MAX be then?)
Otherwise you may want to apply the cleanup patch below
Roel ------------------------------>8-------------8<--------------------------------- Remove redundant tests on unsigned
---
fs/nfsd/export.c +0 -11
@@ -463,17 +463,6 @@ static int secinfo_parse(char **mesg, char *buf, struct svc_export *exp) err =get_int (mesg, &f->pseudoflavor);if (err)return err; -/* -* Just a quick sanity check; we could also try to check -* whether this pseudoflavor is supported, but at worst -* an unsupported pseudoflavor on the export would just -* be a pseudoflavor that won't match the flavor of any -* authenticated request. The administrator will -* probably discover the problem when someone fails to -* authenticate. -*/ -if (f->pseudoflavor <0 ) -return -EINVAL ; err =get_int (mesg, &f->flags);if (err)return err;
J. Bruce Fields
AppliedThanks, applied.
Quoted 7 lines · Roel Kluin
vi
include/linux/nfsd/export.h+77
and note that structexp_flavor_infof->pseudoflavorinsecinfo_parse()is unsigned. Should there maybe be a test:if (
f->pseudoflavor> MAX)(and what should MAX be then?)
I think the only sensible thing would actually be to attempt to verify that we support each pseudoflavor, but that's a little more work; for now I just modified your patch to leave a note that we should do that some day.
Another todo if anyone's interested would be to modify the code that looks for supported pseudoflavors to attempt to load the right module if necessary--I saw the lack of this cause a problem somewhere recently.
--b.
Author: Roel Kluin <[email protected]> Date: Tue Apr 21 16:08:39 2009 +0200
rpcgss: remove redundant test on unsigned.
fs/nfsd/export.c +4 -9
@@ -464,16 +464,11 @@ static int secinfo_parse(char **mesg, char *buf, struct svc_export *exp)if (err)return err;/* -* Just a quick sanity check; we could also try to check -* whether this pseudoflavor is supported, but at worst -* an unsupported pseudoflavor on the export would just -* be a pseudoflavor that won't match the flavor of any -* authenticated request. The administrator will -* probably discover the problem when someone fails to -* authenticate. +* XXX: It would be nice to also check whether this +* pseudoflavor is supported, so we can discover the +* problem at export time instead of when a client fails +* to authenticate. */ -if (f->pseudoflavor <0 ) -return -EINVAL ; err =get_int (mesg, &f->flags);if (err)return err;