Skip to contentSkip to conversation

nfsd-affecting part of vfs queue

PATCH In review Al Viro 3 participants 4 messages Apr 21, 2009 – Apr 23, 2009

Subsystems (2)
lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 nfsd-affecting part of vfs queue

Fix for out-order dput() vs. mntput() (in nfsd_cross_mnt()) plus several "switch to passing struct path *" ones. Comments would be welcome...

Entire queue is on git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ in "untested".

#1 lore raw
Quoted 7 lines · Al Viro

Fix for out-order dput() vs. mntput() (in nfsd_cross_mnt()) plus several "switch to passing struct path *" ones. Comments would be welcome...

Entire queue is on git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ in "untested".

I haven't tested them, but otherwise they look like fine. Shall queue them in the nfsd tree?

--b.

#2 lore raw
Quoted 11 lines · J. Bruce Fields
Quoted 7 lines · Al Viro

Fix for out-order dput() vs. mntput() (in nfsd_cross_mnt()) plus several "switch to passing struct path *" ones. Comments would be welcome...

Entire queue is on git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ in "untested".

I haven't tested them, but otherwise they look like fine. Shall queue them in the nfsd tree?

Several patches later in VFS queue depend on those, so I'm definitely keeping them in there; might make sense to duplicate in nfsd tree as well to avoid inter-tree dependencies. Hell knows, git will cope with that just fine, so linux-next will be OK with that, but -mm used to have problems with such things, IIRC.

#3 lore raw
Quoted 10 lines · Al Viro
Quoted 9 lines · J. Bruce Fields
Quoted 7 lines · Al Viro

Fix for out-order dput() vs. mntput() (in nfsd_cross_mnt()) plus several "switch to passing struct path *" ones. Comments would be welcome...

Entire queue is on git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ in "untested".

Quoted 8 lines
Quoted 2 lines

I haven't tested them, but otherwise they look like fine. Shall queue them in the nfsd tree?

Several patches later in VFS queue depend on those, so I'm definitely keeping them in there; might make sense to duplicate in nfsd tree as well to avoid inter-tree dependencies. Hell knows, git will cope with that just fine, so linux-next will be OK with that, but -mm used to have problems with such things, IIRC.

OK. I'll just ignore them unless it becomes a problem.

I did boot your tree above (c65d9c93...) and run a test or two without seeing any obvious problem. Feel free to add an

--b.