Skip to contentSkip to conversation

FM1216ME_MK3 AUX byte for FM mode

PATCH In review Dmitri Belimov 2 participants 5 messages Apr 23, 2009 – Oct 27, 2011 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FM1216ME_MK3 AUX byte for FM mode

Hi All

Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It can be usefull for other tuners.

linux/drivers/media/common/tuners/tuner-simple.c +11 -0
diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c
@@ -751,6 +751,17 @@
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }
 

With my best regards, Dmitry.

linux/drivers/media/common/tuners/tuner-simple.c +11 -0
diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c
@@ -751,6 +751,17 @@
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }
 
#1 lore raw

Hi Dmitri,

Em 23-04-2009 02:40, Dmitri Belimov escreveu:

Quoted 4 lines

Hi All

Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It can be usefull for other tuners.

Hmm... Found this patch. It were never applied, but it may make some sense to apply it.

Could you please double-check if this patch is still valid, and, if so, re-send it to me?

Thanks!
Mauro

Quoted 26 lines

diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c

linux/drivers/media/common/tuners/tuner-simple.c +11 -0
@@ -751,6 +751,17 @@
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }
 

With my best regards, Dmitry.

#2 lore raw

Hi Mauro

Sure. I'll do it ASAP

With my best regards, Dmitry.

Quoted 48 lines

Hi Dmitri,

Em 23-04-2009 02:40, Dmitri Belimov escreveu:

Quoted 4 lines

Hi All

Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It can be usefull for other tuners.

Hmm... Found this patch. It were never applied, but it may make some sense to apply it.

Could you please double-check if this patch is still valid, and, if so, re-send it to me?

Thanks!
Mauro

Quoted 29 lines

diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c ---
a/linux/drivers/media/common/tuners/tuner-simple.c Mon Apr
20 22:07:44 2009 +0000 +++
b/linux/drivers/media/common/tuners/tuner-simple.c Thu Apr
23 10:26:54 2009 +1000 @@ -751,6 +751,17 @@ if (4 != rc) tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);

linux/drivers/media/common/tuners/tuner-simple.c +6 -0
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer,

4);

(quoted diff) +2 -0
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d

(should be 4)\n", rc);

linux/drivers/media/common/tuners/tuner-simple.c +3 -0
+		break;
+	}
+
 	return 0;
 }

Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov
<[email protected]>

With my best regards, Dmitry.

#3 lore raw
In reply to Mauro Carvalho Chehab

Hi Mauro

Need apply this patch. I test it for compile only right now I haven't TV cards with 1216ME_MK3. I was send ask on our forum for test.

With my best regards, Dmitry.

Quoted 42 lines

Hi Dmitri,

Em 23-04-2009 02:40, Dmitri Belimov escreveu:

Quoted 4 lines

Hi All

Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It can be usefull for other tuners.

Hmm... Found this patch. It were never applied, but it may make some sense to apply it.

Could you please double-check if this patch is still valid, and, if so, re-send it to me?

Thanks!
Mauro

Quoted 24 lines

diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c ---
a/linux/drivers/media/common/tuners/tuner-simple.c Mon Apr
20 22:07:44 2009 +0000 +++
b/linux/drivers/media/common/tuners/tuner-simple.c Thu Apr
23 10:26:54 2009 +1000 @@ -751,6 +751,17 @@ if (4 != rc) tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);

(quoted diff) +6 -0
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer,

4);

(quoted diff) +2 -0
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d

(should be 4)\n", rc);

(quoted diff) +3 -0
+		break;
+	}
+
 	return 0;
 }
Quoted 6 lines
Quoted 5 lines

Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov
<[email protected]>

With my best regards, Dmitry.

drivers/media/common/tuners/tuner-simple.c +11 -0
index f8ee29e..4092200 100644
@@ -751,6 +751,17 @@ static int simple_set_radio_freq(struct dvb_frontend *fe,
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }
 
#4 lore raw
In reply to Mauro Carvalho Chehab

Hi Mauro

I found TV card and test this patch. Audio is better. Please apply.

With my best regards, Dmitry.

Quoted 42 lines

Hi Dmitri,

Em 23-04-2009 02:40, Dmitri Belimov escreveu:

Quoted 4 lines

Hi All

Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It can be usefull for other tuners.

Hmm... Found this patch. It were never applied, but it may make some sense to apply it.

Could you please double-check if this patch is still valid, and, if so, re-send it to me?

Thanks!
Mauro

Quoted 24 lines

diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c ---
a/linux/drivers/media/common/tuners/tuner-simple.c Mon Apr
20 22:07:44 2009 +0000 +++
b/linux/drivers/media/common/tuners/tuner-simple.c Thu Apr
23 10:26:54 2009 +1000 @@ -751,6 +751,17 @@ if (4 != rc) tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);

(quoted diff) +6 -0
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer,

4);

(quoted diff) +2 -0
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d

(should be 4)\n", rc);

(quoted diff) +3 -0
+		break;
+	}
+
 	return 0;
 }
Quoted 6 lines
Quoted 5 lines

Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov
<[email protected]>

With my best regards, Dmitry.

drivers/media/common/tuners/tuner-simple.c +11 -0
index f8ee29e..4092200 100644
@@ -751,6 +751,17 @@ static int simple_set_radio_freq(struct dvb_frontend *fe,
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }