Skip to contentSkip to conversation

MAINTAINERS: update IDE entry

PATCH In review Bartlomiej Zolnierkiewicz 4 participants 7 messages Apr 23, 2009 – Apr 26, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: update IDE entry

By a popular demand quilt tree was replaced by a git one.

---
 MAINTAINERS |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
Index: b/MAINTAINERS
===================================================================
@@ -2743,7 +2743,7 @@ IDE SUBSYSTEM
 P:	Bartlomiej Zolnierkiewicz
 M:	[email protected]
 L:	[email protected]
-T:	quilt kernel.org/pub/linux/kernel/people/bart/pata-2.6/
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6.git
 S:	Maintained
 F:	Documentation/ide/
 F:	drivers/ide/
#1 lore raw

Hello.

Quoted 12 lines · Bartlomiej Zolnierkiewicz

By a popular demand quilt tree was replaced by a git one.

---
 MAINTAINERS |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/MAINTAINERS
===================================================================

MAINTAINERS IDE SUBSYSTEM · line 2747

Quoted 6 lines
MAINTAINERS +1 -1
@@ -2743,7 +2743,7 @@ IDE SUBSYSTEM
 P:	Bartlomiej Zolnierkiewicz
 M:	[email protected]
 L:	[email protected]
-T:	quilt kernel.org/pub/linux/kernel/people/bart/pata-2.6/
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6.git
 

Does that mean that the patches that have been already accepeted into
the git tree, can't be updated afterwards (i.e. I have a habit of sometimes sending several takes of the same patch)?

WBR, Sergei

#2 lore raw
Quoted 11 lines · On Friday 24 April 2009 10:08:48 Sergei Shtylyov wrote:

Hello.

Quoted 7 lines · Bartlomiej Zolnierkiewicz

By a popular demand quilt tree was replaced by a git one.

---
 MAINTAINERS |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

MAINTAINERS IDE SUBSYSTEM · line 2747

Quoted 11 lines

Index: b/MAINTAINERS
===================================================================

MAINTAINERS +1 -1
@@ -2743,7 +2743,7 @@ IDE SUBSYSTEM
 P:	Bartlomiej Zolnierkiewicz
 M:	[email protected]
 L:	[email protected]
-T:	quilt kernel.org/pub/linux/kernel/people/bart/pata-2.6/
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6.git
 

Does that mean that the patches that have been already accepeted into
the git tree, can't be updated afterwards (i.e. I have a habit of sometimes sending several takes of the same patch)?

Yes, please just send incremental updates once the patch has been merged.

Thanks,
Bart

#3 lore raw

Hi,

Quoted 28 lines · Bartlomiej Zolnierkiewicz
Quoted 11 lines · On Friday 24 April 2009 10:08:48 Sergei Shtylyov wrote:

Hello.

Quoted 7 lines · Bartlomiej Zolnierkiewicz

By a popular demand quilt tree was replaced by a git one.

---
 MAINTAINERS |    2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

MAINTAINERS IDE SUBSYSTEM · line 2746

Quoted 11 lines

Index: b/MAINTAINERS
===================================================================

MAINTAINERS +0 -0
@@ -2743,7 +2743,7 @@ IDE SUBSYSTEM

 P: Bartlomiej Zolnierkiewicz
 M: [email protected]
 L: [email protected]

MAINTAINERS +1 -1
-T: quilt kernel.org/pub/linux/kernel/people/bart/pata-2.6/
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6.git

  Does that mean that the patches that have been already accepeted into the git tree, can't be updated afterwards (i.e. I have a habit of sometimes sending several takes of the same patch)?

Quoted 1 line

Yes, please just send incremental updates once the patch has been merged.

Or, you can interactively rebase the tree to the commit right before the patch to be replaced and then add the updated patch in place of the old one. There's a very hands-on example in the manpage in section "INTERACTIVE MODE."

A problem with that might be that others who've pulled from your branch will see the rewritten history with a new SHA1 commit, but that would be still ok since we'll be pulling from the linux-next branch and the for-linus branch is the one that is cast in stone once Linus pulls from you.

Signature · 2 lines
Regards/Gruss,
Boris
#4 lore raw
Quoted 34 lines · On Friday 24 April 2009 18:41:42 Borislav Petkov wrote:

Hi,

Quoted 28 lines · Bartlomiej Zolnierkiewicz
Quoted 11 lines · On Friday 24 April 2009 10:08:48 Sergei Shtylyov wrote:

Hello.

Quoted 7 lines · Bartlomiej Zolnierkiewicz

By a popular demand quilt tree was replaced by a git one.

---
 MAINTAINERS |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

MAINTAINERS IDE SUBSYSTEM · line 2747

Quoted 11 lines

Index: b/MAINTAINERS
===================================================================

MAINTAINERS +1 -1
@@ -2743,7 +2743,7 @@ IDE SUBSYSTEM
 P: Bartlomiej Zolnierkiewicz
 M: [email protected]
 L: [email protected]
-T: quilt kernel.org/pub/linux/kernel/people/bart/pata-2.6/
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6.git
 

Does that mean that the patches that have been already accepeted into
the git tree, can't be updated afterwards (i.e. I have a habit of sometimes sending several takes of the same patch)?

Quoted 1 line

Yes, please just send incremental updates once the patch has been merged.

Quoted 8 lines

Or, you can interactively rebase the tree to the commit right before the patch to be replaced and then add the updated patch in place of the old one. There's a very hands-on example in the manpage in section "INTERACTIVE MODE."

A problem with that might be that others who've pulled from your branch will see the rewritten history with a new SHA1 commit, but that would be still ok since we'll be pulling from the linux-next branch and the for-linus branch is the one that is cast in stone once Linus pulls from you.

I don't think that it will be ok to people who have already based their work on a earlier version of the tree. Also sometimes people may need to pull ide tree into their tree (block tree comes to mind) so rebasing should be avoided as much as possible.

Moreover, I would prefer getting patches which don't need updating. ;-)

Thanks,
Bart

#5 lore raw
Quoted 1 line · Bartlomiej Zolnierkiewicz

Moreover, I would prefer getting patches which don't need updating. ;-)

Sounds like a good idea, let's do that! :0)

Signature · 2 lines
Regards/Gruss,
    Boris.
#6 lore raw
Quoted 5 lines · Borislav Petkov
Quoted 1 line · Bartlomiej Zolnierkiewicz

Moreover, I would prefer getting patches which don't need updating. ;-)

Sounds like a good idea, let's do that! :0)

Great. :-)

To rebase or not seems to be an issue people have different opinions about. Some trees get rebased regularly while others seldomly or never. Not being a maintainer, I prefer trees which don't get rebased but being able to provide cross-tree sync points is one of the biggest benefits and as long as they can be established when necessary, I guess to-each-his/her-own.

Thanks.

Signature · 1 line
tejun