Skip to contentSkip to conversation

ptrace: remove PT_DTRACE from avr32, mn10300, parisc, s390, sh, xtensa

PATCH In review Oleg Nesterov 6 participants 6 messages Apr 23, 2009 – Apr 24, 2009

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 2/4 ptrace: remove PT_DTRACE from avr32, mn10300, parisc, s390, sh, xtensa

avr32, mn10300, parisc, s390, sh, xtensa:

they never set PT_DTRACE, but clear it after do_execve().

 arch/avr32/kernel/process.c       |    2 --
 arch/mn10300/kernel/process.c     |    3 ---
 arch/parisc/hpux/fs.c             |    5 -----
 arch/parisc/kernel/process.c      |    5 -----
 arch/parisc/kernel/sys_parisc32.c |    5 -----
 arch/s390/kernel/compat_linux.c   |    3 ---
 arch/s390/kernel/process.c        |    3 ---
 arch/sh/kernel/process_32.c       |    5 -----
 arch/sh/kernel/process_64.c       |    5 -----
 arch/xtensa/kernel/process.c      |    5 -----
 10 files changed, 41 deletions(-)
arch/avr32/kernel/process.c renamed from arch/avr32/kernel/process.c~DT_2_CLEAR +0 -2
@@ -394,8 +394,6 @@ asmlinkage int sys_execve(char __user *u
 		goto out;
 
 	error = do_execve(filename, uargv, uenvp, regs);
-	if (error == 0)
-		current->ptrace &= ~PT_DTRACE;
 	putname(filename);
 
 out:
arch/mn10300/kernel/process.c renamed from arch/mn10300/kernel/process.c~DT_2_CLEAR +0 -3
@@ -281,9 +281,6 @@ asmlinkage long sys_execve(char __user *
 	error = PTR_ERR(filename);
 	if (!IS_ERR(filename)) {
 		error = do_execve(filename, argv, envp, __frame);
-		if (error == 0)
-			current->ptrace &= ~PT_DTRACE;
-
 		putname(filename);
 	}
 
arch/parisc/hpux/fs.c renamed from arch/parisc/hpux/fs.c~DT_2_CLEAR +0 -5
@@ -44,11 +44,6 @@ int hpux_execve(struct pt_regs *regs)
 	error = do_execve(filename, (char __user * __user *) regs->gr[25],
 		(char __user * __user *) regs->gr[24], regs);
 
-	if (error == 0) {
-		task_lock(current);
-		current->ptrace &= ~PT_DTRACE;
-		task_unlock(current);
-	}
 	putname(filename);
 
 out:
arch/parisc/kernel/process.c renamed from arch/parisc/kernel/process.c~DT_2_CLEAR +0 -5
@@ -349,11 +349,6 @@ asmlinkage int sys_execve(struct pt_regs
 		goto out;
 	error = do_execve(filename, (char __user * __user *) regs->gr[25],
 		(char __user * __user *) regs->gr[24], regs);
-	if (error == 0) {
-		task_lock(current);
-		current->ptrace &= ~PT_DTRACE;
-		task_unlock(current);
-	}
 	putname(filename);
 out:
 
arch/parisc/kernel/sys_parisc32.c renamed from arch/parisc/kernel/sys_parisc32.c~DT_2_CLEAR +0 -5
@@ -77,11 +77,6 @@ asmlinkage int sys32_execve(struct pt_re
 		goto out;
 	error = compat_do_execve(filename, compat_ptr(regs->gr[25]),
 				 compat_ptr(regs->gr[24]), regs);
-	if (error == 0) {
-		task_lock(current);
-		current->ptrace &= ~PT_DTRACE;
-		task_unlock(current);
-	}
 	putname(filename);
 out:
 
arch/s390/kernel/compat_linux.c renamed from arch/s390/kernel/compat_linux.c~DT_2_CLEAR +0 -3
@@ -461,9 +461,6 @@ asmlinkage long sys32_execve(void)
 		result = rc;
 		goto out_putname;
 	}
-	task_lock(current);
-	current->ptrace &= ~PT_DTRACE;
-	task_unlock(current);
 	current->thread.fp_regs.fpc=0;
 	asm volatile("sfpc %0,0" : : "d" (0));
 	result = regs->gprs[2];
arch/s390/kernel/process.c renamed from arch/s390/kernel/process.c~DT_2_CLEAR +0 -3
@@ -265,9 +265,6 @@ SYSCALL_DEFINE0(vfork)
 
 asmlinkage void execve_tail(void)
 {
-	task_lock(current);
-	current->ptrace &= ~PT_DTRACE;
-	task_unlock(current);
 	current->thread.fp_regs.fpc = 0;
 	if (MACHINE_HAS_IEEE)
 		asm volatile("sfpc %0,%0" : : "d" (0));
arch/sh/kernel/process_32.c renamed from arch/sh/kernel/process_32.c~DT_2_CLEAR +0 -5
@@ -366,11 +366,6 @@ asmlinkage int sys_execve(char __user *u
 		goto out;
 
 	error = do_execve(filename, uargv, uenvp, regs);
-	if (error == 0) {
-		task_lock(current);
-		current->ptrace &= ~PT_DTRACE;
-		task_unlock(current);
-	}
 	putname(filename);
 out:
 	return error;
arch/sh/kernel/process_64.c renamed from arch/sh/kernel/process_64.c~DT_2_CLEAR +0 -5
@@ -529,11 +529,6 @@ asmlinkage int sys_execve(char *ufilenam
 			  (char __user * __user *)uargv,
 			  (char __user * __user *)uenvp,
 			  pregs);
-	if (error == 0) {
-		task_lock(current);
-		current->ptrace &= ~PT_DTRACE;
-		task_unlock(current);
-	}
 	putname(filename);
 out:
 	return error;
arch/xtensa/kernel/process.c renamed from arch/xtensa/kernel/process.c~DT_2_CLEAR +0 -5
@@ -331,11 +331,6 @@ long xtensa_execve(char __user *name, ch
 	if (IS_ERR(filename))
 		goto out;
 	error = do_execve(filename, argv, envp, regs);
-	if (error == 0) {
-		task_lock(current);
-		current->ptrace &= ~PT_DTRACE;
-		task_unlock(current);
-	}
 	putname(filename);
 out:
 	return error;
maintainer Acked-by on v1 2/4
#3 lore raw
In reply to Oleg Nesterov

Cheers!
-Chris

Quoted 21 lines · Oleg Nesterov

avr32, mn10300, parisc, s390, sh, xtensa:

they never set PT_DTRACE, but clear it after do_execve().

 arch/xtensa/kernel/process.c      |    5 -----
arch/xtensa/kernel/process.c renamed from arch/xtensa/kernel/process.c~DT_2_CLEAR +0 -5
@@ -331,11 +331,6 @@ long xtensa_execve(char __user *name, ch
 	if (IS_ERR(filename))
 		goto out;
 	error = do_execve(filename, argv, envp, regs);
-	if (error == 0) {
-		task_lock(current);
-		current->ptrace &= ~PT_DTRACE;
-		task_unlock(current);
-	}
 	putname(filename);
 out:
 	return error;