Skip to contentSkip to conversation

powernow-k8.c: mess cleanup

PATCH In review Luis Henriques 2 participants 2 messages Apr 23, 2009 – Apr 24, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powernow-k8.c: mess cleanup

Mess cleanup in powernow_k8_acpi_pst_values() function.

---
 arch/x86/kernel/cpu/cpufreq/powernow-k8.c |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
arch/x86/kernel/cpu/cpufreq/powernow-k8.c +9 -7
index 4709ead..6c31f95 100644
@@ -1,3 +1,4 @@
+
 /*
  *   (c) 2003-2006 Advanced Micro Devices, Inc.
  *  Your use of this code is subject to the terms and conditions of the
@@ -809,13 +810,14 @@ static void powernow_k8_acpi_pst_values(struct powernow_k8_data *data,
 	if (!data->acpi_data.state_count || (cpu_family == CPU_HW_PSTATE))
 		return;
 
-	control = data->acpi_data.states[index].control; data->irt = (control
-			>> IRT_SHIFT) & IRT_MASK; data->rvo = (control >>
-				RVO_SHIFT) & RVO_MASK; data->exttype = (control
-					>> EXT_TYPE_SHIFT) & EXT_TYPE_MASK;
-	data->plllock = (control >> PLL_L_SHIFT) & PLL_L_MASK; data->vidmvs = 1
-		<< ((control >> MVS_SHIFT) & MVS_MASK); data->vstable =
-		(control >> VST_SHIFT) & VST_MASK; }
+	control = data->acpi_data.states[index].control;
+	data->irt = (control >> IRT_SHIFT) & IRT_MASK;
+	data->rvo = (control >> RVO_SHIFT) & RVO_MASK;
+	data->exttype = (control >> EXT_TYPE_SHIFT) & EXT_TYPE_MASK;
+	data->plllock = (control >> PLL_L_SHIFT) & PLL_L_MASK;
+	data->vidmvs = 1 << ((control >> MVS_SHIFT) & MVS_MASK);
+	data->vstable = (control >> VST_SHIFT) & VST_MASK;
+}
 
 static int powernow_k8_cpu_init_acpi(struct powernow_k8_data *data)
 {
Signature · 1 line
1.6.2.4
#1 lore raw
Quoted 3 lines · Luis Henriques

Mess cleanup in powernow_k8_acpi_pst_values() function.

Introduced by me in 0e64a0c982c06a6b8f5e2a7f29eb108fdf257b2f

I have no idea wtf I did there, nor how I missed it before submitting.

Dave