Skip to contentSkip to conversation

usb/storage/usual-tables.c: add MODULE_LICENSE

PATCH In review Adrian Bunk 2 participants 3 messages Apr 27, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb/storage/usual-tables.c: add MODULE_LICENSE

This patch adds the missing MODULE_LICENSE("GPL").

---

drivers/usb/storage/usual-tables.c +2 -0
index 468bde7..d62ea8f 100644
@@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
+
+MODULE_LICENSE("GPL");
#1 lore raw
Quoted 11 lines · Adrian Bunk

This patch adds the missing MODULE_LICENSE("GPL").

---

drivers/usb/storage/usual-tables.c +0 -0
index 468bde7..d62ea8f 100644

drivers/usb/storage/usual-tables.c int usb_usual_ignore_device(struct usb_interface *intf) · line 118

Quoted 5 lines
drivers/usb/storage/usual-tables.c +2 -0
@@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
+
+MODULE_LICENSE("GPL");

Why is this needed? This .c file gets built into either the libusual module, or the usb-storage module, both of which have module licenses, right?

confused,

greg k-h

#2 lore raw
Quoted 7 lines · Greg KH
Quoted 6 lines · Adrian Bunk

This patch adds the missing MODULE_LICENSE("GPL").

---

Quoted 14 lines

drivers/usb/storage/usual-tables.c int usb_usual_ignore_device(struct usb_interface *intf) · line 118

Quoted 10 lines
drivers/usb/storage/usual-tables.c +2 -0
index 468bde7..d62ea8f 100644
@@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
+
+MODULE_LICENSE("GPL");

Why is this needed? This .c file gets built into either the libusual module, or the usb-storage module, both of which have module licenses, right?

My fault, I ran into it some time ago, and missed that the actual problem was fixed by commit dfc15e8955338fedf5c5d15622c4042c1e4ee332

Quoted 3 lines

confused,

greg k-h

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed