Skip to contentSkip to conversation

Enable PTHREADS_DEBUG_SUPPORT on all uClibc builds

PATCH In review Tom Rini 4 participants 5 messages Apr 28, 2009

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 Enable PTHREADS_DEBUG_SUPPORT on all uClibc builds

As has been reported, building uClibc with PTHREADS_DEBUG_SUPPORT=n means that task-sdk-bare won't install due to missing uclibc-thread-db. The following enables it everywhere it was disabled and bumps PRs. This should be fine given that we already have separate debug packages and the extra files end up in an additional package.

recipes/uclibc/uclibc-0.9.27/wrt54/uClibc.config +1 -1
index 5fddbed..1a24121 100644
@@ -63,7 +63,7 @@ LDSO_BASE_FILENAME="ld.so"
 UCLIBC_CTOR_DTOR=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 UCLIBC_HAS_LFS=y
 # MALLOC is not set
 # MALLOC_SIMPLE is not set
recipes/uclibc/uclibc-0.9.28/avr32/uClibc.config +1 -1
index 478c713..065b961 100644
@@ -63,7 +63,7 @@ LDSO_RUNPATH=y
 UCLIBC_CTOR_DTOR=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 UCLIBC_HAS_LFS=y
 UCLIBC_STATIC_LDCONFIG=y
 # MALLOC is not set
recipes/uclibc/uclibc-0.9.28/wrt54/uClibc.config +1 -1
index 14779b7..d28b0a1 100644
@@ -66,7 +66,7 @@ LDSO_RUNPATH=y
 UCLIBC_CTOR_DTOR=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 UCLIBC_HAS_LFS=y
 UCLIBC_STATIC_LDCONFIG=y
 # MALLOC is not set
recipes/uclibc/uclibc-0.9.29/bfin/uClibc.machine +1 -1
index 0c56523..33a294f 100644
@@ -73,7 +73,7 @@ LDSO_RUNPATH=y
 UCLIBC_CTOR_DTOR=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 LINUXTHREADS_OLD=y
 UCLIBC_HAS_LFS=y
 MALLOC=y
recipes/uclibc/uclibc-0.9.30.1/bfin/uClibc.machine +1 -1
index 0c56523..33a294f 100644
@@ -73,7 +73,7 @@ LDSO_RUNPATH=y
 UCLIBC_CTOR_DTOR=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 LINUXTHREADS_OLD=y
 UCLIBC_HAS_LFS=y
 MALLOC=y
recipes/uclibc/uclibc-0.9.30.1/uClibc.distro +1 -1
index 77f6091..31029a3 100644
@@ -17,7 +17,7 @@ UCLIBC_CTOR_DTOR=y
 LDSO_GNU_HASH_SUPPORT=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 LINUXTHREADS_OLD=y
 UCLIBC_HAS_LFS=y
 # MALLOC is not set
recipes/uclibc/uclibc-0.9.30/bfin/uClibc.machine +1 -1
index 0c56523..33a294f 100644
@@ -73,7 +73,7 @@ LDSO_RUNPATH=y
 UCLIBC_CTOR_DTOR=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 LINUXTHREADS_OLD=y
 UCLIBC_HAS_LFS=y
 MALLOC=y
recipes/uclibc/uclibc-0.9.30/uClibc.distro +1 -1
index b072b2f..d8eed91 100644
@@ -17,7 +17,7 @@ UCLIBC_CTOR_DTOR=y
 LDSO_GNU_HASH_SUPPORT=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 LINUXTHREADS_OLD=y
 UCLIBC_HAS_LFS=y
 # MALLOC is not set
recipes/uclibc/uclibc-nptl/uClibc.distro +1 -1
index 8537080..e52db5c 100644
@@ -18,7 +18,7 @@ LDSO_GNU_HASH_SUPPORT=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
 UCLIBC_HAS_THREADS_NATIVE=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 # LINUXTHREADS_OLD is not set
 UCLIBC_HAS_LFS=y
 # MALLOC is not set
recipes/uclibc/uclibc-svn/uClibc.distro +1 -1
index 2b1406c..2f5e073 100644
@@ -17,7 +17,7 @@ UCLIBC_CTOR_DTOR=y
 LDSO_GNU_HASH_SUPPORT=y
 # HAS_NO_THREADS is not set
 UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
 LINUXTHREADS_OLD=y
 UCLIBC_HAS_LFS=y
 # MALLOC is not set
recipes/uclibc/uclibc_0.9.27.bb +1 -1
index 1357e58..56575da 100644
@@ -1,5 +1,5 @@
 DEFAULT_PREFERENCE = "1"
-PR = "r12"
+PR = "r13"
 
 require uclibc.inc
 
recipes/uclibc/uclibc_0.9.28.bb +1 -1
index 1b0f2e0..adf7a74 100644
@@ -1,5 +1,5 @@
 DEFAULT_PREFERENCE = "1"
-PR = "r17"
+PR = "r18"
 
 require uclibc.inc
 
recipes/uclibc/uclibc_0.9.29.bb +1 -1
index aba1830..f6bc689 100644
@@ -7,7 +7,7 @@
 # on whether the base patches apply to the selected (SRCDATE) svn release.
 #
 UCLIBC_BASE ?= "0.9.29"
-PR = "r30"
+PR = "r31"
 
 require uclibc.inc
 
recipes/uclibc/uclibc_0.9.30.1.bb +1 -1
index d159ab3..ab6dcb9 100644
@@ -7,7 +7,7 @@
 # on whether the base patches apply to the selected (SRCDATE) svn release.
 #
 UCLIBC_BASE ?= "0.9.30.1"
-PR = "r1"
+PR = "r2"
 DEFAULT_PREFERENCE = "1"
 
 require uclibc.inc
recipes/uclibc/uclibc_0.9.30.bb +1 -1
index bbe809f..0a374ce 100644
@@ -7,7 +7,7 @@
 # on whether the base patches apply to the selected (SRCDATE) svn release.
 #
 UCLIBC_BASE ?= "0.9.30"
-PR = "r6"
+PR = "r7"
 DEFAULT_PREFERENCE = "1"
 
 require uclibc.inc
recipes/uclibc/uclibc_svn.bb +1 -1
index 654cb6e..127cea7 100644
@@ -8,7 +8,7 @@
 #
 UCLIBC_BASE ?= "0.9.30"
 PV = "${UCLIBC_BASE}+svnr${SRCREV}"
-PR = "r0"
+PR = "r1"
 #DEFAULT_PREFERENCE = "2"
 #DEFAULT_PREFERENCE is 0 (empty), releases have a preference of 1 so take
 # precedence.
Signature · 1 line
Tom Rini
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Tom Rini

As has been reported, building uClibc with PTHREADS_DEBUG_SUPPORT=n means that task-sdk-bare won't install due to missing uclibc-thread-db. The following enables it everywhere it was disabled and bumps PRs. This should be fine given that we already have separate debug packages and the extra files end up in an additional package.

Quoted 206 lines
recipes/uclibc/uclibc-0.9.27/wrt54/uClibc.config +1 -1
index 5fddbed..1a24121 100644
@@ -63,7 +63,7 @@ LDSO_BASE_FILENAME="ld.so"
  UCLIBC_CTOR_DTOR=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  UCLIBC_HAS_LFS=y
  # MALLOC is not set
  # MALLOC_SIMPLE is not set
recipes/uclibc/uclibc-0.9.28/avr32/uClibc.config +1 -1
index 478c713..065b961 100644
@@ -63,7 +63,7 @@ LDSO_RUNPATH=y
  UCLIBC_CTOR_DTOR=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  UCLIBC_HAS_LFS=y
  UCLIBC_STATIC_LDCONFIG=y
  # MALLOC is not set
recipes/uclibc/uclibc-0.9.28/wrt54/uClibc.config +1 -1
index 14779b7..d28b0a1 100644
@@ -66,7 +66,7 @@ LDSO_RUNPATH=y
  UCLIBC_CTOR_DTOR=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  UCLIBC_HAS_LFS=y
  UCLIBC_STATIC_LDCONFIG=y
  # MALLOC is not set
recipes/uclibc/uclibc-0.9.29/bfin/uClibc.machine +1 -1
index 0c56523..33a294f 100644
@@ -73,7 +73,7 @@ LDSO_RUNPATH=y
  UCLIBC_CTOR_DTOR=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  LINUXTHREADS_OLD=y
  UCLIBC_HAS_LFS=y
  MALLOC=y
recipes/uclibc/uclibc-0.9.30.1/bfin/uClibc.machine +1 -1
index 0c56523..33a294f 100644
@@ -73,7 +73,7 @@ LDSO_RUNPATH=y
  UCLIBC_CTOR_DTOR=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  LINUXTHREADS_OLD=y
  UCLIBC_HAS_LFS=y
  MALLOC=y
recipes/uclibc/uclibc-0.9.30.1/uClibc.distro +1 -1
index 77f6091..31029a3 100644
@@ -17,7 +17,7 @@ UCLIBC_CTOR_DTOR=y
  LDSO_GNU_HASH_SUPPORT=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  LINUXTHREADS_OLD=y
  UCLIBC_HAS_LFS=y
  # MALLOC is not set
recipes/uclibc/uclibc-0.9.30/bfin/uClibc.machine +1 -1
index 0c56523..33a294f 100644
@@ -73,7 +73,7 @@ LDSO_RUNPATH=y
  UCLIBC_CTOR_DTOR=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  LINUXTHREADS_OLD=y
  UCLIBC_HAS_LFS=y
  MALLOC=y
recipes/uclibc/uclibc-0.9.30/uClibc.distro +1 -1
index b072b2f..d8eed91 100644
@@ -17,7 +17,7 @@ UCLIBC_CTOR_DTOR=y
  LDSO_GNU_HASH_SUPPORT=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  LINUXTHREADS_OLD=y
  UCLIBC_HAS_LFS=y
  # MALLOC is not set
recipes/uclibc/uclibc-nptl/uClibc.distro +1 -1
index 8537080..e52db5c 100644
@@ -18,7 +18,7 @@ LDSO_GNU_HASH_SUPPORT=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
  UCLIBC_HAS_THREADS_NATIVE=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  # LINUXTHREADS_OLD is not set
  UCLIBC_HAS_LFS=y
  # MALLOC is not set
recipes/uclibc/uclibc-svn/uClibc.distro +1 -1
index 2b1406c..2f5e073 100644
@@ -17,7 +17,7 @@ UCLIBC_CTOR_DTOR=y
  LDSO_GNU_HASH_SUPPORT=y
  # HAS_NO_THREADS is not set
  UCLIBC_HAS_THREADS=y
-# PTHREADS_DEBUG_SUPPORT is not set
+PTHREADS_DEBUG_SUPPORT=y
  LINUXTHREADS_OLD=y
  UCLIBC_HAS_LFS=y
  # MALLOC is not set
recipes/uclibc/uclibc_0.9.27.bb +1 -1
index 1357e58..56575da 100644
@@ -1,5 +1,5 @@
  DEFAULT_PREFERENCE = "1"
-PR = "r12"
+PR = "r13"
 
  require uclibc.inc
 
recipes/uclibc/uclibc_0.9.28.bb +1 -1
index 1b0f2e0..adf7a74 100644
@@ -1,5 +1,5 @@
  DEFAULT_PREFERENCE = "1"
-PR = "r17"
+PR = "r18"
 
  require uclibc.inc
 
recipes/uclibc/uclibc_0.9.29.bb +1 -1
index aba1830..f6bc689 100644
@@ -7,7 +7,7 @@
  # on whether the base patches apply to the selected (SRCDATE) svn release.
  #
  UCLIBC_BASE ?= "0.9.29"
-PR = "r30"
+PR = "r31"
 
  require uclibc.inc
 
recipes/uclibc/uclibc_0.9.30.1.bb +1 -1
index d159ab3..ab6dcb9 100644
@@ -7,7 +7,7 @@
  # on whether the base patches apply to the selected (SRCDATE) svn release.
  #
  UCLIBC_BASE ?= "0.9.30.1"
-PR = "r1"
+PR = "r2"
  DEFAULT_PREFERENCE = "1"
 
  require uclibc.inc
recipes/uclibc/uclibc_0.9.30.bb +1 -1
index bbe809f..0a374ce 100644
@@ -7,7 +7,7 @@
  # on whether the base patches apply to the selected (SRCDATE) svn release.
  #
  UCLIBC_BASE ?= "0.9.30"
-PR = "r6"
+PR = "r7"
  DEFAULT_PREFERENCE = "1"
 
  require uclibc.inc
recipes/uclibc/uclibc_svn.bb +1 -1
index 654cb6e..127cea7 100644
@@ -8,7 +8,7 @@
  #
  UCLIBC_BASE ?= "0.9.30"
  PV = "${UCLIBC_BASE}+svnr${SRCREV}"
-PR = "r0"
+PR = "r1"
  #DEFAULT_PREFERENCE = "2"
  #DEFAULT_PREFERENCE is 0 (empty), releases have a preference of 1 so take
  # precedence.
Acked-by
#2 lore raw
Quoted 10 lines · Koen Kooi
Quoted 7 lines · Tom Rini

As has been reported, building uClibc with PTHREADS_DEBUG_SUPPORT=n means that task-sdk-bare won't install due to missing uclibc-thread-db. The following enables it everywhere it was disabled and bumps PRs. This should be fine given that we already have separate debug packages and the extra files end up in an additional package.

You should also bump PR for uclibc_nptl recipe.

author
#4 lore raw
In reply to Tom Rini
Quoted 5 lines · Tom Rini

As has been reported, building uClibc with PTHREADS_DEBUG_SUPPORT=n means that task-sdk-bare won't install due to missing uclibc-thread-db. The following enables it everywhere it was disabled and bumps PRs. This should be fine given that we already have separate debug packages and the extra files end up in an additional package.

wogline had a bit of a concern on IRC, so some grepping in 0.9.{27,28,29} (I had checked 30 before) shows that really all that changes is that libpthread is built so that libpthread_db is used for debugging (and thus some debug stuff, that we would have end up in the -dbg packages anyhow) ends up in a different file.

Signature · 1 line
Tom Rini