Resolve use of non-existent GPIO routines in msp71xx reset

MIPS Applied Shane McDonald 2 participants 2 messages Apr 28, 2009 MIPS

Share & tools

Shane McDonald

author

2009-04-28 05:52 UTC #0 lore raw

There have been a number of compile problems with the msp71xx configuration ever since it was included in the linux-mips.org repository. This patch resolves compilation problems with attempting to reset the board using non-existent GPIO routines.

This patch has been compile-tested against the current HEAD.

Signed-off-by Shane McDonald <[email protected]>

---
 arch/mips/pmc-sierra/msp71xx/msp_setup.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

arch/mips/pmc-sierra/msp71xx/msp_setup.c +2 -6

index c936756..a54e85b 100644
@@ -21,7 +21,6 @@
 
 #if defined(CONFIG_PMC_MSP7120_GW)
 #include <msp_regops.h>
-#include <msp_gpio.h>
 #define MSP_BOARD_RESET_GPIO	9
 #endif

@@ -88,11 +87,8 @@ void msp7120_reset(void)
 	 * as GPIO char driver may not be enabled and it would look up
 	 * data inRAM!
 	 */
-	set_value_reg32(GPIO_CFG3_REG,
-			basic_mode_mask(MSP_BOARD_RESET_GPIO),
-			basic_mode(MSP_GPIO_OUTPUT, MSP_BOARD_RESET_GPIO));
-	set_reg32(GPIO_DATA3_REG,
-			basic_data_mask(MSP_BOARD_RESET_GPIO));
+	set_value_reg32(GPIO_CFG3_REG, 0xf000, 0x8000);
+	set_reg32(GPIO_DATA3_REG, 8);
 
 	/*
 	 * In case GPIO9 doesn't reset the board (jumper configurable!)

Signature · 1 line

1.5.6.5

Ralf Baechle

Applied

2009-04-28 09:17 UTC #1 lore raw

Quoted 6 lines · Shane McDonald

There have been a number of compile problems with the msp71xx configuration ever since it was included in the linux-mips.org repository. This patch resolves compilation problems with attempting to reset the board using non-existent GPIO routines.
This patch has been compile-tested against the current HEAD.

Thanks, applied to 2.6.23 and up.

Ralf