ASoC: TWL4030: Fix gain control for earpiece amplifier
PATCH 1/1 ASoC: TWL4030: Fix gain control for earpiece amplifier
The gain control for earpiece amplifier uses 0dB ~ 12dB according to the TRM, but the present code is implemented to -6dB ~ 6dB.
Signed-off-by Joonyoung Shim <[email protected]>
--- sound/soc/codecs/twl4030.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
sound/soc/codecs/twl4030.c +7 -1
@@ -785,6 +785,12 @@ static DECLARE_TLV_DB_SCALE(analog_tlv, -2400, 200, 0); static DECLARE_TLV_DB_SCALE(output_tvl, -1200, 600, 1);/* +* Gain control for earpiece amplifier +* 0 dB to 12 dB in 6 dB steps (mute instead of -6) +*/ +static DECLARE_TLV_DB_SCALE(output_ear_tvl, -600, 600, 1); + +/* * Capture gain after the ADCs * from 0 dB to 31 dB in 1 dB steps */
@@ -859,7 +865,7 @@ static const struct snd_kcontrol_new twl4030_snd_controls[] = { 4, 3, 0, output_tvl),SOC_SINGLE_TLV_TWL4030 ("Earpiece Playback Volume" , -TWL4030_REG_EAR_CTL ,4 ,3 ,0 , output_tvl), +TWL4030_REG_EAR_CTL ,4 ,3 ,0 , output_ear_tvl),/* Common capture gain controls */ SOC_DOUBLE_R_TLV("TX1 Digital Capture Volume",
Signature · 1 line
1.6.0.4
Quoted 2 lines · On Tuesday 28 April 2009 12:18:05 ext Joonyoung Shim wrote:
The gain control for earpiece amplifier uses 0dB ~ 12dB according to the TRM, but the present code is implemented to -6dB ~ 6dB.
You are right on this...
Acked-by Peter Ujfalusi <[email protected]>