remove s_async_list
PATCH 1/1 remove s_async_list
Remove the unused s_async_list in the superblock, a leftover of the broken async inode deletion code that leaked into mainline. Having this in the middle of the sync/unmount path is not helpful for the following cleanups.
fs/super.c +0 -7
@@ -37,7 +37,6 @@#include <linux/kobject.h> #include <linux/mutex.h> #include <linux/file.h> -#include <linux/async.h> #include <asm/uaccess.h> #include "internal.h"
@@ -71,7 +70,6 @@ static struct super_block *alloc_super(sINIT_HLIST_HEAD (&s->s_anon);INIT_LIST_HEAD (&s->s_inodes);INIT_LIST_HEAD (&s->s_dentry_lru); -INIT_LIST_HEAD (&s->s_async_list);init_rwsem (&s->s_umount);mutex_init (&s->s_lock);lockdep_set_class (&s->s_umount, &type->s_umount_key);
@@ -281,11 +279,6 @@ void generic_shutdown_super(struct superlock_super (sb); sb->s_flags &= ~MS_ACTIVE ; -/* -* wait for asynchronous fs operations to finish before going further -*/ -async_synchronize_full_domain (&sb->s_async_list); -/* bad name - it should be evict_inodes() */ invalidate_inodes (sb);lock_kernel ();
include/linux/fs.h +0 -5
@@ -1372,11 +1372,6 @@ struct super_block {* generic_show_options() */ char *s_options; - -/* -* storage for asynchronous operations -*/ -struct list_head s_async_list; };extern struct timespec current_fs_time (struct super_block *sb);
fs/sync.c +0 -1
@@ -94,7 +94,6 @@ restart: sb->s_count++;spin_unlock (&sb_lock);down_read (&sb->s_umount); -async_synchronize_full_domain (&sb->s_async_list);if (sb->s_root)__sync_filesystem (sb, wait);up_read (&sb->s_umount);
Jan Kara
reviewerQuoted 4 lines · Christoph Hellwig
Remove the unused
s_async_listin the superblock, a leftover of the broken async inode deletion code that leaked into mainline. Having this in the middle of the sync/unmount path is not helpful for the following cleanups.
I was wondering what it's used for when cleaning up the sync path ;)
BTW, fs/sync.c also includes <linux/async.h> which can be removed now, doesn't it?
Quoted 1 line
Signed-off-by Christoph Hellwig <[email protected]>
Honza
Quoted 61 lines
Index:
linux-2.6/fs/super.c
===================================================================fs/super.c +0
-7@@ -37,7 +37,6 @@#include <linux/kobject.h> #include <linux/mutex.h> #include <linux/file.h> -#include <linux/async.h> #include <asm/uaccess.h> #include "internal.h" @@ -71,7 +70,6 @@ static struct super_block *alloc_super(sINIT_HLIST_HEAD (&s->s_anon);INIT_LIST_HEAD (&s->s_inodes);INIT_LIST_HEAD (&s->s_dentry_lru); -INIT_LIST_HEAD (&s->s_async_list);init_rwsem (&s->s_umount);mutex_init (&s->s_lock);lockdep_set_class (&s->s_umount, &type->s_umount_key);@@ -281,11 +279,6 @@ void generic_shutdown_super(struct superlock_super (sb); sb->s_flags &= ~MS_ACTIVE ; -/* -* wait for asynchronous fs operations to finish before going further -*/ -async_synchronize_full_domain (&sb->s_async_list); -/* bad name - it should be evict_inodes() */ invalidate_inodes (sb);lock_kernel ();Index:
linux-2.6/include/linux/fs.h
===================================================================include/linux/fs.h +0
-5@@ -1372,11 +1372,6 @@ struct super_block {* generic_show_options() */ char *s_options; - -/* -* storage for asynchronous operations -*/ -struct list_head s_async_list; };extern struct timespec current_fs_time (struct super_block *sb);Index:
linux-2.6/fs/sync.c
===================================================================fs/sync.c +0
-1@@ -94,7 +94,6 @@ restart: sb->s_count++;spin_unlock (&sb_lock);down_read (&sb->s_umount); -async_synchronize_full_domain (&sb->s_async_list);if (sb->s_root)__sync_filesystem (sb, wait);up_read (&sb->s_umount);
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 8 lines · Jan Kara
Quoted 4 lines · Christoph Hellwig
Remove the unused
s_async_listin the superblock, a leftover of the broken async inode deletion code that leaked into mainline. Having this in the middle of the sync/unmount path is not helpful for the following cleanups.I was wondering what it's used for when cleaning up the sync path ;)
BTW,fs/sync.calso includes <linux/async.h> which can be removed now, doesn't it?
Yeah. Updated version below:
fs/super.c +0 -7
@@ -37,7 +37,6 @@#include <linux/kobject.h> #include <linux/mutex.h> #include <linux/file.h> -#include <linux/async.h> #include <asm/uaccess.h> #include "internal.h"
@@ -71,7 +70,6 @@ static struct super_block *alloc_super(sINIT_HLIST_HEAD (&s->s_anon);INIT_LIST_HEAD (&s->s_inodes);INIT_LIST_HEAD (&s->s_dentry_lru); -INIT_LIST_HEAD (&s->s_async_list);init_rwsem (&s->s_umount);mutex_init (&s->s_lock);lockdep_set_class (&s->s_umount, &type->s_umount_key);
@@ -281,11 +279,6 @@ void generic_shutdown_super(struct superlock_super (sb); sb->s_flags &= ~MS_ACTIVE ; -/* -* wait for asynchronous fs operations to finish before going further -*/ -async_synchronize_full_domain (&sb->s_async_list); -/* bad name - it should be evict_inodes() */ invalidate_inodes (sb);lock_kernel ();
include/linux/fs.h +0 -5
@@ -1372,11 +1372,6 @@ struct super_block {* generic_show_options() */ char *s_options; - -/* -* storage for asynchronous operations -*/ -struct list_head s_async_list; };extern struct timespec current_fs_time (struct super_block *sb);
fs/sync.c +0 -2
@@ -12,7 +12,6 @@#include <linux/linkage.h> #include <linux/pagemap.h> #include <linux/quotaops.h> -#include <linux/async.h> #define VALID_FLAGS (SYNC_FILE_RANGE_WAIT_BEFORE|SYNC_FILE_RANGE_WRITE| \ SYNC_FILE_RANGE_WAIT_AFTER)
@@ -94,7 +93,6 @@ restart: sb->s_count++;spin_unlock (&sb_lock);down_read (&sb->s_umount); -async_synchronize_full_domain (&sb->s_async_list);if (sb->s_root)__sync_filesystem (sb, wait);up_read (&sb->s_umount);