Skip to contentSkip to conversation

CRISv32: Fix typo compile error in ARTPEC-3 gpio driver.

PATCH New Jesper Nilsson 1 participant 1 message Apr 28, 2009 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 CRISv32: Fix typo compile error in ARTPEC-3 gpio driver.

Quoted 5 lines · Robert P. J. Day
Quoted 1 line · Mikael Starvik

should that not be "spin_unlock_irqrestore()"?

um ... the code is correct, or my observation is correct? in any
event, i'll leave this with you.

Hi, I've just added the following patch to the CRIS-tree:

=============
Subject: [PATCH] CRISv32: Fix typo compile error in ARTPEC-3 gpio driver.

arch/cris/arch-v32/drivers/mach-a3/gpio.c:
+spin_lock_irqrestore(&gpio_lock, flags);
arch/cris/arch-v32/drivers/mach-a3/gpio.c:
+spin_lock_irqrestore(&gpio_lock, flags);

should that not be "spin_unlock_irqrestore()"?

The code in question was inside an (most often) undefined ifdef.

---
 arch/cris/arch-v32/drivers/mach-a3/gpio.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/cris/arch-v32/drivers/mach-a3/gpio.c +2 -2
index 7a87bc0..97357cf 100644
@@ -681,7 +681,7 @@ static int virtual_gpio_ioctl(struct file *file, unsigned int cmd,
 		shadow |= ~readl(dir_oe[priv->minor]) |
 			(arg & changeable_bits[priv->minor]);
 		i2c_write(VIRT_I2C_ADDR, (void *)&shadow, sizeof(shadow));
-		spin_lock_irqrestore(&gpio_lock, flags);
+		spin_unlock_irqrestore(&gpio_lock, flags);
 		break;
 	case IO_CLRBITS:
 		spin_lock_irqsave(&gpio_lock, flags);
@@ -690,7 +690,7 @@ static int virtual_gpio_ioctl(struct file *file, unsigned int cmd,
 		shadow |= ~readl(dir_oe[priv->minor]) &
 			~(arg & changeable_bits[priv->minor]);
 		i2c_write(VIRT_I2C_ADDR, (void *)&shadow, sizeof(shadow));
-		spin_lock_irqrestore(&gpio_lock, flags);
+		spin_unlock_irqrestore(&gpio_lock, flags);
 		break;
 	case IO_HIGHALARM:
 		/* Set alarm when bits with 1 in arg go high. */
Signature · 6 lines
1.6.1


/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- [email protected]