Skip to contentSkip to conversation

xfsdump: add .gitignore

PATCH In review Christoph Hellwig 4 participants 6 messages Apr 29, 2009 – May 4, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfsdump: add .gitignore

This one is pretty ugly due to all the symlinked files, any better suggestions?

.gitignore new file +134 -0
Index: xfsdump-dev/.gitignore
===================================================================
@@ -0,0 +1,134 @@
+# object files
+*.o
+
+# build system
+.census
+Logs/
+include/config.h
+include/builddefs
+install-sh
+
+# magic diretory symlinks
+#include/disk
+#include/xfs
+
+# Makepgs
+build/src-manifest
+build/xfsdump-*.tar.gz
+doc/CHANGES.gz
+xfsdump-*
+
+# autoconf generated files
+aclocal.m4
+autom4te.cache/
+config.guess
+config.log
+config.status
+config.sub
+configure
+
+# libtool
+libtool
+ltmain.sh
+*.lo
+*.la
+.libs
+
+# gettext
+po/xfsdump.pot
+po/*.mo
+
+# quilt stuff
+.pc/
+patches/
+
+# binaries
+dump/xfsdump
+invutil/xfsinvutil
+restore/xfsrestore
+
+# @%#% symlinked sourced files
+dump/arch_xlate.[ch]
+dump/cldmgr.[ch]
+dump/content.h
+dump/content_common.[ch]
+dump/content_inode.h
+dump/dlog.[ch]
+dump/drive.[ch]
+dump/drive_minrmt.c
+dump/drive_scsitape.c
+dump/drive_simple.c
+dump/exit.h
+dump/fs.[ch]
+dump/getdents.[ch]
+dump/global.[ch]
+dump/hsmapi.[ch]
+dump/inv_api.c
+dump/inv_core.c
+dump/inv_files.c
+dump/inv_fstab.c
+dump/inv_idx.c
+dump/inv_mgr.c
+dump/inv_priv.h
+dump/inv_stobj.c
+dump/inventory.h
+dump/lock.[ch]
+dump/main.c
+dump/media.h
+dump/mlog.[ch]
+dump/openutil.[ch]
+dump/path.[ch]
+dump/qlock.[ch]
+dump/rec_hdr.h
+dump/ring.[ch]
+dump/sproc.[ch]
+dump/stream.[ch]
+dump/ts_mtio.h
+dump/types.h
+dump/util.[ch]
+
+invutil/global.h
+invutil/inv_files.c
+invutil/inv_priv.h
+invutil/inventory.h
+invutil/mlog.h
+invutil/types.h
+invutil/util.h
+
+restore/arch_xlate.[ch]
+restore/cldmgr.[ch]
+restore/content.h
+restore/content_inode.h
+restore/dlog.[ch]
+restore/drive.[ch]
+restore/drive_minrmt.c
+restore/drive_scsitape.c
+restore/drive_simple.c
+restore/exit.h
+restore/fs.[ch]
+restore/getdents.[ch]
+restore/global.[ch]
+restore/hsmapi.[ch]
+restore/inv_api.c
+restore/inv_core.c
+restore/inv_files.c
+restore/inv_fstab.c
+restore/inv_idx.c
+restore/inv_mgr.c
+restore/inv_priv.h
+restore/inv_stobj.c
+restore/inventory.h
+restore/lock.[ch]
+restore/main.c
+restore/media.h
+restore/mlog.[ch]
+restore/openutil.[ch]
+restore/path.[ch]
+restore/qlock.[ch]
+restore/rec_hdr.h
+restore/ring.[ch]
+restore/sproc.[ch]
+restore/stream.[ch]
+restore/ts_mtio.h
+restore/types.h
+restore/util.[ch]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 136 lines · Christoph Hellwig

This one is pretty ugly due to all the symlinked files, any better suggestions?

Index: xfsdump-dev/.gitignore
===================================================================

.gitignore new file +124 -0
@@ -0,0 +1,134 @@
+# object files
+*.o
+
+# build system
+.census
+Logs/
+include/config.h
+include/builddefs
+install-sh
+
+# magic diretory symlinks
+#include/disk
+#include/xfs
+
+# Makepgs
+build/src-manifest
+build/xfsdump-*.tar.gz
+doc/CHANGES.gz
+xfsdump-*
+
+# autoconf generated files
+aclocal.m4
+autom4te.cache/
+config.guess
+config.log
+config.status
+config.sub
+configure
+
+# libtool
+libtool
+ltmain.sh
+*.lo
+*.la
+.libs
+
+# gettext
+po/xfsdump.pot
+po/*.mo
+
+# quilt stuff
+.pc/
+patches/
+
+# binaries
+dump/xfsdump
+invutil/xfsinvutil
+restore/xfsrestore
+
+# @%#% symlinked sourced files
+dump/arch_xlate.[ch]
+dump/cldmgr.[ch]
+dump/content.h
+dump/content_common.[ch]
+dump/content_inode.h
+dump/dlog.[ch]
+dump/drive.[ch]
+dump/drive_minrmt.c
+dump/drive_scsitape.c
+dump/drive_simple.c
+dump/exit.h
+dump/fs.[ch]
+dump/getdents.[ch]
+dump/global.[ch]
+dump/hsmapi.[ch]
+dump/inv_api.c
+dump/inv_core.c
+dump/inv_files.c
+dump/inv_fstab.c
+dump/inv_idx.c
+dump/inv_mgr.c
+dump/inv_priv.h
+dump/inv_stobj.c
+dump/inventory.h
+dump/lock.[ch]
+dump/main.c
+dump/media.h
+dump/mlog.[ch]
+dump/openutil.[ch]
+dump/path.[ch]
+dump/qlock.[ch]
+dump/rec_hdr.h
+dump/ring.[ch]
+dump/sproc.[ch]
+dump/stream.[ch]
+dump/ts_mtio.h
+dump/types.h
+dump/util.[ch]
+
+invutil/global.h
+invutil/inv_files.c
+invutil/inv_priv.h
+invutil/inventory.h
+invutil/mlog.h
+invutil/types.h
+invutil/util.h
+
+restore/arch_xlate.[ch]
+restore/cldmgr.[ch]
+restore/content.h
+restore/content_inode.h
+restore/dlog.[ch]
+restore/drive.[ch]
+restore/drive_minrmt.c
+restore/drive_scsitape.c
+restore/drive_simple.c
+restore/exit.h
+restore/fs.[ch]
+restore/getdents.[ch]
+restore/global.[ch]
+restore/hsmapi.[ch]
+restore/inv_api.c
+restore/inv_core.c
+restore/inv_files.c
+restore/inv_fstab.c
+restore/inv_idx.c
+restore/inv_mgr.c
+restore/inv_priv.h
+restore/inv_stobj.c
+restore/inventory.h
+restore/lock.[ch]
+restore/main.c
+restore/media.h
+restore/mlog.[ch]

.gitignore line 134

Quoted 10 lines
.gitignore new file +10 -0
+restore/openutil.[ch]
+restore/path.[ch]
+restore/qlock.[ch]
+restore/rec_hdr.h
+restore/ring.[ch]
+restore/sproc.[ch]
+restore/stream.[ch]
+restore/ts_mtio.h
+restore/types.h
+restore/util.[ch]

could add cscope/ here too, but, *shrug*

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#3 lore raw
In reply to Christoph Hellwig

Get rid of the symlinked files by creating a local library for the commonality? ;-)Probably easier said than done - I haven't looked at the code in a while - but I
I think the traditional library model is better than a heap of symlinks :) (I realise you just want a .gitignore file but .... ;-)

--Tim

Quoted 146 lines · Christoph Hellwig

This one is pretty ugly due to all the symlinked files, any better suggestions?

Index: xfsdump-dev/.gitignore
===================================================================

.gitignore 2009-04-29 15:48:26.996484383 +0200 renamed from dev/null 1970-01-01 00:00:00.000000000 +0000 +134 -0
@@ -0,0 +1,134 @@
+# object files
+*.o
+
+# build system
+.census
+Logs/
+include/config.h
+include/builddefs
+install-sh
+
+# magic diretory symlinks
+#include/disk
+#include/xfs
+
+# Makepgs
+build/src-manifest
+build/xfsdump-*.tar.gz
+doc/CHANGES.gz
+xfsdump-*
+
+# autoconf generated files
+aclocal.m4
+autom4te.cache/
+config.guess
+config.log
+config.status
+config.sub
+configure
+
+# libtool
+libtool
+ltmain.sh
+*.lo
+*.la
+.libs
+
+# gettext
+po/xfsdump.pot
+po/*.mo
+
+# quilt stuff
+.pc/
+patches/
+
+# binaries
+dump/xfsdump
+invutil/xfsinvutil
+restore/xfsrestore
+
+# @%#% symlinked sourced files
+dump/arch_xlate.[ch]
+dump/cldmgr.[ch]
+dump/content.h
+dump/content_common.[ch]
+dump/content_inode.h
+dump/dlog.[ch]
+dump/drive.[ch]
+dump/drive_minrmt.c
+dump/drive_scsitape.c
+dump/drive_simple.c
+dump/exit.h
+dump/fs.[ch]
+dump/getdents.[ch]
+dump/global.[ch]
+dump/hsmapi.[ch]
+dump/inv_api.c
+dump/inv_core.c
+dump/inv_files.c
+dump/inv_fstab.c
+dump/inv_idx.c
+dump/inv_mgr.c
+dump/inv_priv.h
+dump/inv_stobj.c
+dump/inventory.h
+dump/lock.[ch]
+dump/main.c
+dump/media.h
+dump/mlog.[ch]
+dump/openutil.[ch]
+dump/path.[ch]
+dump/qlock.[ch]
+dump/rec_hdr.h
+dump/ring.[ch]
+dump/sproc.[ch]
+dump/stream.[ch]
+dump/ts_mtio.h
+dump/types.h
+dump/util.[ch]
+
+invutil/global.h
+invutil/inv_files.c
+invutil/inv_priv.h
+invutil/inventory.h
+invutil/mlog.h
+invutil/types.h
+invutil/util.h
+
+restore/arch_xlate.[ch]
+restore/cldmgr.[ch]
+restore/content.h
+restore/content_inode.h
+restore/dlog.[ch]
+restore/drive.[ch]
+restore/drive_minrmt.c
+restore/drive_scsitape.c
+restore/drive_simple.c
+restore/exit.h
+restore/fs.[ch]
+restore/getdents.[ch]
+restore/global.[ch]
+restore/hsmapi.[ch]
+restore/inv_api.c
+restore/inv_core.c
+restore/inv_files.c
+restore/inv_fstab.c
+restore/inv_idx.c
+restore/inv_mgr.c
+restore/inv_priv.h
+restore/inv_stobj.c
+restore/inventory.h
+restore/lock.[ch]
+restore/main.c
+restore/media.h
+restore/mlog.[ch]
+restore/openutil.[ch]
+restore/path.[ch]
+restore/qlock.[ch]
+restore/rec_hdr.h
+restore/ring.[ch]
+restore/sproc.[ch]
+restore/stream.[ch]
+restore/ts_mtio.h
+restore/types.h
+restore/util.[ch]
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#4 lore raw
Quoted 4 lines · Timothy Shimmin

Get rid of the symlinked files by creating a local library for the commonality? ;-)Probably easier said than done - I haven't looked at the code in a while - but I
I think the traditional library model is better than a heap of symlinks :)

It probably is. I'll put it on my todo list..

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#5 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 4 lines · Timothy Shimmin

Get rid of the symlinked files by creating a local library for the commonality? ;-)Probably easier said than done - I haven't looked at the code in a while - but I
I think the traditional library model is better than a heap of symlinks :)

It probably is. I'll put it on my todo list..

Not sure how well if fits the library model, unfortunately. The symlinked files need to be compiled for dump and then recompiled for restore as there's a bunch of #ifdef DUMP and #ifdef RESTORE sections. I guess two libraries could be created, if separate build dirs were used under common.

Bill

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs