Skip to contentSkip to conversation

wusb: hwa-hc: Drop unused pci_suspend/resume hooks.

PATCH In review Paul Mundt 4 participants 4 messages Apr 30, 2009

Subsystems (2)
USB Linux-next tree
lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 wusb: hwa-hc: Drop unused pci_suspend/resume hooks.

CC drivers/usb/host/hwa-hc.o
drivers/usb/host/hwa-hc.c:601: warning: initialization from incompatible pointer type drivers/usb/host/hwa-hc.c:602: warning: initialization from incompatible pointer type

The prototype for these changed, so the message itself was dropped. As the only thing these hooks were doing was printing out the message for debugging, there is not much point in keeping them around. So, just kill them off.

Cc Inaky Perez-Gonzalez <[email protected]>
Cc David Vrabel <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Signed-off-by Paul Mundt <[email protected]>

---

 drivers/usb/host/hwa-hc.c |   21 ---------------------
 1 file changed, 21 deletions(-)
drivers/usb/host/hwa-hc.c +0 -21
index cbf30e5..88b0321 100644
@@ -172,25 +172,6 @@ error_cluster_id_get:
 
 }
 
-static int hwahc_op_suspend(struct usb_hcd *usb_hcd, pm_message_t msg)
-{
-	struct wusbhc *wusbhc = usb_hcd_to_wusbhc(usb_hcd);
-	struct hwahc *hwahc = container_of(wusbhc, struct hwahc, wusbhc);
-	dev_err(wusbhc->dev, "%s (%p [%p], 0x%lx) UNIMPLEMENTED\n", __func__,
-		usb_hcd, hwahc, *(unsigned long *) &msg);
-	return -ENOSYS;
-}
-
-static int hwahc_op_resume(struct usb_hcd *usb_hcd)
-{
-	struct wusbhc *wusbhc = usb_hcd_to_wusbhc(usb_hcd);
-	struct hwahc *hwahc = container_of(wusbhc, struct hwahc, wusbhc);
-
-	dev_err(wusbhc->dev, "%s (%p [%p]) UNIMPLEMENTED\n", __func__,
-		usb_hcd, hwahc);
-	return -ENOSYS;
-}
-
 /*
  * No need to abort pipes, as when this is called, all the children
  * has been disconnected and that has done it [through

@@ -598,8 +579,6 @@ static struct hc_driver hwahc_hc_driver = {
 	.flags = HCD_USB2,		/* FIXME */
 	.reset = hwahc_op_reset,
 	.start = hwahc_op_start,
-	.pci_suspend = hwahc_op_suspend,
-	.pci_resume = hwahc_op_resume,
 	.stop = hwahc_op_stop,
 	.get_frame_number = hwahc_op_get_frame_number,
 	.urb_enqueue = hwahc_op_urb_enqueue,
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Paul Mundt

CC drivers/usb/host/hwa-hc.o
drivers/usb/host/hwa-hc.c:601: warning: initialization from incompatible pointer type drivers/usb/host/hwa-hc.c:602: warning: initialization from incompatible pointer type

The prototype for these changed, so the message itself was dropped. As the only thing these hooks were doing was printing out the message for debugging, there is not much point in keeping them around. So, just kill them off.

Acked-by David Vrabel <[email protected]>

Greg, can you pick this one up, please.

David

#2 lore raw
Quoted 5 lines · David Vrabel
Quoted 4 lines · Paul Mundt

CC drivers/usb/host/hwa-hc.o
drivers/usb/host/hwa-hc.c:601: warning: initialization from incompatible pointer type drivers/usb/host/hwa-hc.c:602: warning: initialization from incompatible pointer type

Quoted 7 lines
Quoted 3 lines

The prototype for these changed, so the message itself was dropped. As the only thing these hooks were doing was printing out the message for debugging, there is not much point in keeping them around. So, just kill them off.

Acked-by David Vrabel <[email protected]>

Greg, can you pick this one up, please.

I don't seem to have it in my archive, can you resend it to me with your ack?

thanks,

greg k-h

#3 lore raw
Quoted 10 lines · Greg KH
Quoted 9 lines · David Vrabel
Quoted 7 lines · Paul Mundt

CC drivers/usb/host/hwa-hc.o
drivers/usb/host/hwa-hc.c:601: warning: initialization from incompatible pointer type drivers/usb/host/hwa-hc.c:602: warning: initialization from incompatible pointer type

The prototype for these changed, so the message itself was dropped. As the only thing these hooks were doing was printing out the message for debugging, there is not much point in keeping them around. So, just kill them off.

Quoted 6 lines
Quoted 3 lines
Acked-by David Vrabel <[email protected]>

Greg, can you pick this one up, please.

I don't seem to have it in my archive, can you resend it to me with your ack?

Nevermind, I found it...

thanks,

greg k-h