radio_si470x: Drop unused label

PATCH In review Nicola Soranzo 2 participants 2 messages Apr 30, 2009 Media (V4L/DVB)

lore

Share & tools

lore

Nicola Soranzo

author

2009-04-30 14:16 UTC #0 lore raw

PATCH 1/1 radio_si470x: Drop unused label

Fix this warning:

/home/nicola/v4l-dvb/v4l/radio-si470x.c: In function 'si470x_fops_release':
/home/nicola/v4l-dvb/v4l/radio-si470x.c:1218: warning: label 'unlock' defined but not used

Priority: normal

Signed-off-by Nicola Soranzo <[email protected]>

---

linux/drivers/media/radio/radio-si470x.c +0 -2

diff -r 83712d149893 -r 97be9e920832 linux/drivers/media/radio/radio-si470x.c
@@ -1214,8 +1214,6 @@
 		retval = si470x_stop(radio);
 		usb_autopm_put_interface(radio->intf);
 	}
-
-unlock:
 	mutex_unlock(&radio->disconnect_lock);
 
 done:

Alexey Klimov

2009-04-30 19:43 UTC #1 lore raw

(added Tobias and Mauro on c/c)

Quoted 21 lines · Nicola Soranzo

Fix this warning:
/home/nicola/v4l-dvb/v4l/radio-si470x.c: In function 'si470x_fops_release':
/home/nicola/v4l-dvb/v4l/radio-si470x.c:1218: warning: label 'unlock' defined but not used
Priority: normal
Signed-off-by Nicola Soranzo <[email protected]>
---
diff -r 83712d149893 -r 97be9e920832 linux/drivers/media/radio/radio-si470x.c
linux/drivers/media/radio/radio-si470x.c Thu Apr 30 16:10:24 2009 +0200 renamed from linux/drivers/media/radio/radio-si470x.c Wed Apr 29 18:01:48 2009 -0300 +0 -2
@@ -1214,8 +1214,6 @@
                retval = si470x_stop(radio);
                usb_autopm_put_interface(radio->intf);
        }
-
-unlock:
        mutex_unlock(&radio->disconnect_lock);
 

Quoted 1 line

done:

Looks good. Thank you.
When i built latest up-to-date git kernel i noticed that this warning showed there also.
Probably, it's better this patch reach 2.6.30 kernel. Now we are at rc4.

Signature · 1 line

Best regards, Klimov Alexey