Skip to contentSkip to conversation

virtio: add missing include to virtio_net.h

PATCH Applied Grant Likely 3 participants 6 messages Apr 28, 2009 – May 5, 2009

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio: add missing include to virtio_net.h

From: Grant Likely <[email protected]>

virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h. Discovered when hacking on virtio-over-pci patches.

---

 include/linux/virtio_net.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/virtio_net.h +1 -0
index 242348b..cec79ad 100644
@@ -4,6 +4,7 @@
  * compatible drivers/servers. */
 #include <linux/types.h>
 #include <linux/virtio_config.h>
+#include <linux/if_ether.h>
 
 /* The ID for virtio_net */
 #define VIRTIO_ID_NET	1
maintainer
#1 lore raw

From: Grant Likely <[email protected]>
Date: Tue, 28 Apr 2009 09:46:54 -0600

[ Grant, please CC: netdev on networking patches, thanks. ]

Quoted 4 lines

virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h. Discovered when hacking on virtio-over-pci patches.

Rusty, ACK?

I haven't been able to get responses from Rusty on virtio net patches, so if he doesn't start responding soon I'm going to integrates the fixes I've seen lately as they all look reasonable to me.

Quoted 24 lines

---

 include/linux/virtio_net.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/virtio_net.h +1 -1
index 242348b..cec79ad 100644
@@ -4,6 +4,7 @@
  * compatible drivers/servers. */
 #include <linux/types.h>
 #include <linux/virtio_config.h>
+#include <linux/if_ether.h>
 
 /* The ID for virtio_net */
 #define VIRTIO_ID_NET	1
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 4 lines · David Miller

From: Grant Likely <[email protected]>
Date: Tue, 28 Apr 2009 09:46:54 -0600

[ Grant, please CC: netdev on networking patches, thanks. ]

Oops, sorry about that; I had in my head "virtio" and it didn't even occur to me that it was also netdev. :-)

g.

Quoted 38 lines
Quoted 5 lines

virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h. Discovered when hacking on virtio-over-pci patches.

Rusty, ACK?

I haven't been able to get responses from Rusty on virtio net patches, so if he doesn't start responding soon I'm going to integrates the fixes I've seen lately as they all look reasonable to me.

Quoted 24 lines

---

 include/linux/virtio_net.h |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/virtio_net.h +1 -1
index 242348b..cec79ad 100644
@@ -4,6 +4,7 @@
   * compatible drivers/servers. */
  #include <linux/types.h>
  #include <linux/virtio_config.h>
+#include <linux/if_ether.h>
 
  /* The ID for virtio_net */
  #define VIRTIO_ID_NET        1
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
maintainer
#5 lore raw

From: Rusty Russell <[email protected]>
Date: Tue, 5 May 2009 13:54:22 +0930

Quoted 7 lines · Grant Likely
Quoted 4 lines

From: Grant Likely <[email protected]>

virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h. Discovered when hacking on virtio-over-pci patches.

Thanks, I've applied this.

Rusty, all of this is in net-2.6 already.

Thanks for paying attention! :-)