Skip to contentSkip to conversation

(blk_t) cast in ext2fs_new_block2()

PATCH In review Nick Dokos 2 participants 2 messages May 1, 2009 – May 4, 2009

lore
Share & tools
lore

Nick Dokos

author
#0 lore raw

PATCH 5/6 (blk_t) cast in ext2fs_new_block2()

Found by code inspection after similar gratuitous cast in ext2fs_get_free_blocks2() (first patch in this series).

---
 lib/ext2fs/alloc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
lib/ext2fs/alloc.c +1 -1
index 9f11673..a7c8860 100644
@@ -170,7 +170,7 @@ errcode_t ext2fs_new_block2(ext2_filsys fs, blk64_t goal,
 					   (i - fs->super->s_first_data_block) /
 					   EXT2_BLOCKS_PER_GROUP(fs->super));
 
-		if (!ext2fs_fast_test_block_bitmap2(map, (blk_t) i)) {
+		if (!ext2fs_fast_test_block_bitmap2(map, i)) {
 			*ret = i;
 			return 0;
 		}
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 24 lines · Nick Dokos

Found by code inspection after similar gratuitous cast in ext2fs_get_free_blocks2() (first patch in this series).

---
 lib/ext2fs/alloc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
lib/ext2fs/alloc.c +1 -1
index 9f11673..a7c8860 100644
@@ -170,7 +170,7 @@ errcode_t ext2fs_new_block2(ext2_filsys fs, blk64_t goal,
 					   (i - fs->super->s_first_data_block) /
 					   EXT2_BLOCKS_PER_GROUP(fs->super));
 
-		if (!ext2fs_fast_test_block_bitmap2(map, (blk_t) i)) {
+		if (!ext2fs_fast_test_block_bitmap2(map, i)) {
 			*ret = i;
 			return 0;
 		}
Signature · 1 line
1.6.0.6

-VAL