Skip to contentSkip to conversation

cs5536: define dma_sff_read_status() method

PATCH In review Sergei Shtylyov 2 participants 3 messages Apr 7, 2009 – May 5, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cs5536: define dma_sff_read_status() method

The driver somehow got merged with the initializer for the dma_sff_read_status() method missing which caused kernel panic on bootup.

This should fix the kernel.org bug #13026...

---
This patch is against the recent Linus' tree.
It should go into 2.6.29-stable as the driver was merged/broken in 2.6.29 time.

 drivers/ide/cs5536.c |    1 +
 1 files changed, 1 insertion(+)
drivers/ide/cs5536.c +1 -0
Index: linux-2.6/drivers/ide/cs5536.c
===================================================================
@@ -236,6 +236,7 @@ static const struct ide_dma_ops cs5536_d
 	.dma_test_irq		= ide_dma_test_irq,
 	.dma_lost_irq		= ide_dma_lost_irq,
 	.dma_timer_expiry	= ide_dma_sff_timer_expiry,
+	.dma_sff_read_status	= ide_dma_sff_read_status,
 };
 
 static const struct ide_port_info cs5536_info = {
#1 lore raw
Quoted 10 lines · Sergei Shtylyov

The driver somehow got merged with the initializer for the dma_sff_read_status() method missing which caused kernel panic on bootup.

This should fix the kernel.org bug #13026...

---
This patch is against the recent Linus' tree.
It should go into 2.6.29-stable as the driver was merged/broken in 2.6.29 time.

It doesn't apply to the 2.6.29-stable tree at all.

Care to redo your patch to apply there?

thanks,

greg k-h

#2 lore raw
Quoted 7 lines · Greg KH
Quoted 6 lines

The driver somehow got merged with the initializer for the dma_sff_read_status() method missing which caused kernel panic on bootup.

This should fix the kernel.org bug #13026...

Quoted 7 lines
Quoted 3 lines

---
This patch is against the recent Linus' tree.
It should go into 2.6.29-stable as the driver was merged/broken in 2.6.29 time.

It doesn't apply to the 2.6.29-stable tree at all.

Care to redo your patch to apply there?

Hm, I thought it was obvious enough... will redo.

Quoted 3 lines

thanks,

greg k-h

MBR, Sergei