Fix wrong register read address and add interrupt acknowledge.
PATCH 1/1 Fix wrong register read address and add interrupt acknowledge.
The receive interrupt routine checks the wrong register if the receive fifo is empty. Further an explicit interrupt acknowledge write is introduced. In some circumstances another interrupt was issued.
--- drivers/serial/nwpserial.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/serial/nwpserial.c +3 -1
@@ -145,11 +145,13 @@ static irqreturn_t nwpserial_interrupt(int irq, void *dev_id) ch =dcr_read (up->dcr_host,UART_RX );if (up->port.ignore_status_mask !=NWPSERIAL_STATUS_RXVALID )tty_insert_flip_char (tty, ch,TTY_NORMAL ); - }while (dcr_read (up->dcr_host,UART_RX ) &UART_LSR_DR ); + }while (dcr_read (up->dcr_host,UART_LSR ) &UART_LSR_DR );tty_flip_buffer_push (tty); ret =IRQ_HANDLED ; +/* clear interrupt */ +dcr_write (up->dcr_host,UART_IIR ,1 ); out:spin_unlock (&up->port.lock);return ret;
--
1.5.4.5
Quoted 4 lines · Benjamin Krill
The receive interrupt routine checks the wrong register if the receive fifo is empty. Further an explicit interrupt acknowledge write is introduced. In some circumstances another interrupt was issued.
The one-line summary of your patch is too vague. It should mention the name of the driver somehow.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Quoted 8 lines · Timur Tabi
Quoted 4 lines · Benjamin Krill
The receive interrupt routine checks the wrong register if the receive fifo is empty. Further an explicit interrupt acknowledge write is introduced. In some circumstances another interrupt was issued.
The one-line summary of your patch is too vague. It should mention the name of the driver somehow.
That is quite true. Although resending the patch just for that seems overkill. The maintainer can edit the summary rather easily.
josh
Quoted 5 lines · * Josh Boyer | 2009-05-05 19:09:19 [-0400]:
Quoted 1 line · Timur Tabi
On Tue, May 5, 2009 at 2:11 PM, Benjamin Krill <[email protected]> wrote:
That is quite true. Although resending the patch just for that seems overkill. The maintainer can edit the summary rather easily.
Ben, could you please merge this patch in your next tree?
cheers
ben