xfs: update max log size
PATCH 1/1 xfs: update max log size
Commit a6634fba3dec4a92f0a2c4e30c80b634c0576ad5 in xfsprogs increased the maximum log size supported by mkfs. Merged back the changes to xfs_fs.h so the growfs enforced the same limit and the headers are in sync.
fs/xfs/xfs_fs.h +7 -4
@@ -239,10 +239,13 @@ typedef struct xfs_fsop_resblks {* Minimum and maximum sizes need for growth checks */ #define XFS_MIN_AG_BLOCKS 64 -#define XFS_MIN_LOG_BLOCKS 512 -#define XFS_MAX_LOG_BLOCKS (64 * 1024) -#define XFS_MIN_LOG_BYTES (256 * 1024) -#define XFS_MAX_LOG_BYTES (128 * 1024 * 1024) +#define XFS_MIN_LOG_BLOCKS 512ULL +#define XFS_MAX_LOG_BLOCKS (1024 * 1024ULL) +#define XFS_MIN_LOG_BYTES (10 * 1024 * 1024ULL) + +/* keep the maximum size under 2^31 by a small amount */ +#define XFS_MAX_LOG_BYTES \ + ((2 * 1024 * 1024 * 1024ULL) - XFS_MIN_LOG_BYTES)/* * Structures for XFS_IOC_FSGROWFSDATA, XFS_IOC_FSGROWFSLOG & XFS_IOC_FSGROWFSRT
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 5 lines · Christoph Hellwig
Commit
a6634fba3dec4a92f0a2c4e30c80b634c0576ad5in xfsprogs increased the maximum log size supported by mkfs. Merged back the changes toxfs_fs.hso the growfs enforced the same limit and the headers are in sync.Signed-off-by Christoph Hellwig <[email protected]>
Ok, looks like kernelspace only cares about this during xfs_growfs_log_private(), and that's not actually implemented yet, right? So no worries about kernel<->userspace version correlation I think.
Quoted 23 lines
Index:
xfs/fs/xfs/xfs_fs.h
===================================================================fs/xfs/xfs_fs.h +7
-4@@ -239,10 +239,13 @@ typedef struct xfs_fsop_resblks {* Minimum and maximum sizes need for growth checks */ #define XFS_MIN_AG_BLOCKS 64 -#define XFS_MIN_LOG_BLOCKS 512 -#define XFS_MAX_LOG_BLOCKS (64 * 1024) -#define XFS_MIN_LOG_BYTES (256 * 1024) -#define XFS_MAX_LOG_BYTES (128 * 1024 * 1024) +#define XFS_MIN_LOG_BLOCKS 512ULL +#define XFS_MAX_LOG_BLOCKS (1024 * 1024ULL) +#define XFS_MIN_LOG_BYTES (10 * 1024 * 1024ULL) + +/* keep the maximum size under 2^31 by a small amount */ +#define XFS_MAX_LOG_BYTES \ + ((2 * 1024 * 1024 * 1024ULL) - XFS_MIN_LOG_BYTES)/* * Structures for XFS_IOC_FSGROWFSDATA, XFS_IOC_FSGROWFSLOG & XFS_IOC_FSGROWFSRT
Quoted 5 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 10 lines · Eric Sandeen
Quoted 5 lines · Christoph Hellwig
Commit
a6634fba3dec4a92f0a2c4e30c80b634c0576ad5in xfsprogs increased the maximum log size supported by mkfs. Merged back the changes toxfs_fs.hso the growfs enforced the same limit and the headers are in sync.Signed-off-by Christoph Hellwig <[email protected]>Ok, looks like kernelspace only cares about this during
xfs_growfs_log_private(), and that's not actually implemented yet, right? So no worries about kernel<->userspace version correlation I think.
Indeed, I just did a quick grep what's actually using it.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs