Skip to contentSkip to conversation

mpc5121/clocks: make debug output more readable

PATCH Superseded Wolfram Sang 3 participants 4 messages May 8, 2009 – May 15, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpc5121/clocks: make debug output more readable

- Drop KERN_ levels for printks which print to the same line
- use '=' in output to connect key/value pairs

Cc John Rigby <[email protected]>
Cc Grant Likely <[email protected]>
---
 arch/powerpc/platforms/512x/clock.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
arch/powerpc/platforms/512x/clock.c +3 -4
Index: .kernel/arch/powerpc/platforms/512x/clock.c
===================================================================
@@ -83,12 +83,11 @@ static void dump_clocks(void)
 	mutex_lock(&clocks_mutex);
 	printk(KERN_INFO "CLOCKS:\n");
 	list_for_each_entry(p, &clocks, node) {
-		printk(KERN_INFO "  %s %ld", p->name, p->rate);
+		printk(KERN_INFO "  %s=%ld", p->name, p->rate);
 		if (p->parent)
-			printk(KERN_INFO " %s %ld", p->parent->name,
-			       p->parent->rate);
+			printk(" %s=%ld", p->parent->name, p->parent->rate);
 		if (p->flags & CLK_HAS_CTRL)
-			printk(KERN_INFO " reg/bit %d/%d", p->reg, p->bit);
+			printk(" reg/bit=%d/%d", p->reg, p->bit);
 		printk("\n");
 	}
 	mutex_unlock(&clocks_mutex);
Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#1 lore raw
Quoted 1 line · Wolfram Sang

- Drop KERN_ levels for printks which print to the same line

Those should use KERN_CONT nowadays.

Quoted 17 lines

- use '=' in output to connect key/value pairs

Cc John Rigby <[email protected]>
Cc Grant Likely <[email protected]>
---
 arch/powerpc/platforms/512x/clock.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Index: .kernel/arch/powerpc/platforms/512x/clock.c
===================================================================

arch/powerpc/platforms/512x/clock.c +0 -0
@@ -83,12 +83,11 @@ static void dump_clocks(void)
 	mutex_lock(&clocks_mutex);
 	printk(KERN_INFO "CLOCKS:\n");

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 90

Quoted 10 lines
arch/powerpc/platforms/512x/clock.c +3 -4
 	list_for_each_entry(p, &clocks, node) {
-		printk(KERN_INFO "  %s %ld", p->name, p->rate);
+		printk(KERN_INFO "  %s=%ld", p->name, p->rate);
 		if (p->parent)
-			printk(KERN_INFO " %s %ld", p->parent->name,
-			       p->parent->rate);
+			printk(" %s=%ld", p->parent->name, p->parent->rate);
 		if (p->flags & CLK_HAS_CTRL)
-			printk(KERN_INFO " reg/bit %d/%d", p->reg, p->bit);
+			printk(" reg/bit=%d/%d", p->reg, p->bit);
                               ^
			       KERN_CONT

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 93

Quoted 3 lines
arch/powerpc/platforms/512x/clock.c +0 -0
 		printk("\n");
 	}
 	mutex_unlock(&clocks_mutex);

With kind regards,

Geert Uytterhoeven
Software Architect
Techsoft Centre

Technology and Software Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   [email protected]
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010

#2 lore raw
In reply to Wolfram Sang
Quoted 3 lines · Wolfram Sang

- Drop KERN_ levels for printks which print to the same line
- use '=3D' in output to connect key/value pairs

Personally, I'd rather see the printks converted to pr_info()/pr_cont().

g.

Quoted 11 lines
Cc John Rigby <[email protected]>
Cc Grant Likely <[email protected]>

---
=A0arch/powerpc/platforms/512x/clock.c | =A0 =A07 +++---- =A01 file changed, 3 insertions(+), 4 deletions(-)

Index: .kernel/arch/powerpc/platforms/512x/clock.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 86

Quoted 7 lines
arch/powerpc/platforms/512x/clock.c +0 -1
@@ -83,12 +83,11 @@ static void dump_clocks(void)
 =A0 =A0 =A0 =A0mutex_lock(&clocks_mutex);
 =A0 =A0 =A0 =A0printk(KERN_INFO "CLOCKS:\n");
 =A0 =A0 =A0 =A0list_for_each_entry(p, &clocks, node) {
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_INFO " =A0%s %ld", p->name, p->=

rate);

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 86

Quoted 1 line
arch/powerpc/platforms/512x/clock.c +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_INFO " =A0%s=3D%ld", p->name, p=

->rate);

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 88

Quoted 2 lines
arch/powerpc/platforms/512x/clock.c +0 -1
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (p->parent)
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_INFO " %s %ld",=

p->parent->name,

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 89

Quoted 1 line
arch/powerpc/platforms/512x/clock.c +0 -1
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0p->parent->r=

ate);

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 88

Quoted 1 line
arch/powerpc/platforms/512x/clock.c +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(" %s=3D%ld", p->pare=

nt->name, p->parent->rate);

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 91

Quoted 2 lines
arch/powerpc/platforms/512x/clock.c +0 -1
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (p->flags & CLK_HAS_CTRL)
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_INFO " reg/bit =

%d/%d", p->reg, p->bit);

arch/powerpc/platforms/512x/clock.c static void dump_clocks(void) · line 90

Quoted 1 line
arch/powerpc/platforms/512x/clock.c +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(" reg/bit=3D%d/%d", =

p->reg, p->bit);

Quoted 6 lines
arch/powerpc/platforms/512x/clock.c +0 -1
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0printk("\n");
 =A0 =A0 =A0 =A0}
 =A0 =A0 =A0 =A0mutex_unlock(&clocks_mutex);
 
--

Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | Wo=

lfram Sang =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0|

Quoted 1 line

Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | http://www.p=

engutronix.de/ =A0|

Quoted 10 lines

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkoEJsUACgkQD27XaX1/VRuQggCgm7auPJpCpTVleUD30B86X/jW lZsAnR91XB0YVCBp95aGyEqUU8+LXaHv
=3D6IcQ
-----END PGP SIGNATURE-----

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

#3 lore raw

PATCH v2 1/1 mpc5121/clocks: make debug output more readable

- refactor printk with pr_info/pr_cont
- use '=' in output to connect key/value pairs

Cc John Rigby <[email protected]>
Cc Grant Likely <[email protected]>
---
 arch/powerpc/platforms/512x/clock.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
powerpc/platforms/512x/clock.c renamed from powerpc/platforms/512x/clock.c.orig +4 -4
Index: arch/powerpc/platforms/512x/clock.c
===================================================================
@@ -83,13 +83,13 @@ static void dump_clocks(void)
 	mutex_lock(&clocks_mutex);
 	printk(KERN_INFO "CLOCKS:\n");
 	list_for_each_entry(p, &clocks, node) {
-		printk(KERN_INFO "  %s %ld", p->name, p->rate);
+		pr_info("  %s=%ld", p->name, p->rate);
 		if (p->parent)
-			printk(KERN_INFO " %s %ld", p->parent->name,
+			pr_cont(" %s=%ld", p->parent->name,
 			       p->parent->rate);
 		if (p->flags & CLK_HAS_CTRL)
-			printk(KERN_INFO " reg/bit %d/%d", p->reg, p->bit);
-		printk("\n");
+			pr_cont(" reg/bit=%d/%d", p->reg, p->bit);
+		pr_cont("\n");
 	}
 	mutex_unlock(&clocks_mutex);
 }
Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |