Skip to contentSkip to conversation

Set bit 1 in disabled processor's _STA

PATCH In review Glauber Costa 3 participants 22 messages May 15, 2009 – May 18, 2009 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Set bit 1 in disabled processor's _STA

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

---
 kvm/bios/acpi-dsdt.dsl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kvm/bios/acpi-dsdt.dsl +1 -1
index c756fed..c53816c 100755
@@ -56,7 +56,7 @@ DefinitionBlock (
             }                                                               \
             Method (_STA) {                                                 \
                 If (CRST(nr)) { Return(0xF) }                               \
-                Else { Return(0x9) }                                        \
+                Else { Return(0xB) }                                        \
             }                                                               \
         }                                                                   \
 
Signature · 1 line
1.5.6.6
#1 lore raw
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA). This patch breaks resume from hibernate on windows 2008/vista.

Quoted 25 lines
---
 kvm/bios/acpi-dsdt.dsl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kvm/bios/acpi-dsdt.dsl +1 -1
index c756fed..c53816c 100755
@@ -56,7 +56,7 @@ DefinitionBlock (
             }                                                               \
             Method (_STA) {                                                 \
                 If (CRST(nr)) { Return(0xF) }                               \
-                Else { Return(0x9) }                                        \
+                Else { Return(0xB) }                                        \
             }                                                               \
         }                                                                   \
 
Signature · 6 lines
1.5.6.6

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
Gleb.

#2 lore raw
Quoted 10 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA).

Yes, that is what happens. But then, by checking "show hidden devices", the disabled processor appears, but are listed as malfunctioning.

Because of this, SVVP tests break without this patch.

Quoted 1 line

This patch breaks resume from hibernate on windows 2008/vista.

Oh god... do you have any idea why?

which bits should we set for everything to work?
It appears to me that having bit 2 cleared should do the right thing, but your test clearly indicate otherwise.

#3 lore raw
Quoted 9 lines · Glauber Costa
Quoted 8 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

Quoted 7 lines
Quoted 2 lines

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA).

Yes, that is what happens. But then, by checking "show hidden devices", the disabled processor appears, but are listed as malfunctioning.

Because of this, SVVP tests break without this patch.

What kind of error?

Quoted 4 lines
Quoted 1 line

This patch breaks resume from hibernate on windows 2008/vista.

Oh god... do you have any idea why?

which bits should we set for everything to work?

Bit 1 should not be set :) What I think is happening windows finds more CPUs on resume then it had before hibernate.

Quoted 2 lines

It appears to me that having bit 2 cleared should do the right thing, but your test clearly indicate otherwise.

--
Gleb.

#4 lore raw
Quoted 10 lines · Gleb Natapov
Quoted 9 lines · Glauber Costa
Quoted 8 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA).

Yes, that is what happens. But then, by checking "show hidden devices", the disabled processor appears, but are listed as malfunctioning.

Because of this, SVVP tests break without this patch.

What kind of error?

Message 4/15/2009 4:07:04.635 AM Checking Intel Processor
Error 4/15/2009 4:07:04.635 AM ERROR: Device (QEMU Virtual CPU version 0.9.1) is not currently enabled, or has some problem

File:    Line: 0 
Error Type:   BOOL 
Error Code:   0x1 
Error Text:   Error 0x00000001 

Alternatively, if you go to the device manager, and "Show hidden processors", you'll see the processors appear, but marked with a "!". Clicking into details, there is a message saying that the device is malfunctioning.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

This patch breaks resume from hibernate on windows 2008/vista.

Oh god... do you have any idea why?

which bits should we set for everything to work?

Bit 1 should not be set :) What I think is happening windows finds more CPUs on resume then it had before hibernate.

It does not make sense to me at first. resume should not be a much different use case than plain boot. If it does the right thing on bootup, why would it mess up in case of resume?

#5 lore raw
Quoted 35 lines · Glauber Costa
Quoted 10 lines · Gleb Natapov
Quoted 9 lines · Glauber Costa
Quoted 8 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA).

Yes, that is what happens. But then, by checking "show hidden devices", the disabled processor appears, but are listed as malfunctioning.

Because of this, SVVP tests break without this patch.

What kind of error?

Message 4/15/2009 4:07:04.635 AM Checking Intel Processor
Error 4/15/2009 4:07:04.635 AM ERROR: Device (QEMU Virtual CPU version 0.9.1) is not currently enabled, or has some problem

File:    Line: 0 
Error Type:   BOOL 
Error Code:   0x1 
Error Text:   Error 0x00000001 

Alternatively, if you go to the device manager, and "Show hidden processors", you'll see the processors appear, but marked with a "!". Clicking into details, there is a message saying that the device is malfunctioning.

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

This patch breaks resume from hibernate on windows 2008/vista.

Oh god... do you have any idea why?

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

which bits should we set for everything to work?

Bit 1 should not be set :) What I think is happening windows finds more CPUs on resume then it had before hibernate.

It does not make sense to me at first. resume should not be a much different use case than plain boot. If it does the right thing on bootup, why would it mess up in case of resume?

I wish I had an answer to this. It may be a bug. On boot windows calculates number of processors from madt tables, but on resume it does the same by executing _STA method of each defined CPU.

--
Gleb.

#6 lore raw
Quoted 40 lines · Gleb Natapov
Quoted 39 lines · Glauber Costa
Quoted 10 lines · Gleb Natapov
Quoted 9 lines · Glauber Costa
Quoted 8 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA).

Yes, that is what happens. But then, by checking "show hidden devices", the disabled processor appears, but are listed as malfunctioning.

Because of this, SVVP tests break without this patch.

What kind of error?

Message 4/15/2009 4:07:04.635 AM Checking Intel Processor
Error 4/15/2009 4:07:04.635 AM ERROR: Device (QEMU Virtual CPU version 0.9.1) is not currently enabled, or has some problem

File:    Line: 0 
Error Type:   BOOL 
Error Code:   0x1 
Error Text:   Error 0x00000001 

Alternatively, if you go to the device manager, and "Show hidden processors", you'll see the processors appear, but marked with a "!". Clicking into details, there is a message saying that the device is malfunctioning.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

This patch breaks resume from hibernate on windows 2008/vista.

Oh god... do you have any idea why?

which bits should we set for everything to work?

Bit 1 should not be set :) What I think is happening windows finds more CPUs on resume then it had before hibernate.

Quoted 6 lines
Quoted 3 lines

It does not make sense to me at first. resume should not be a much different use case than plain boot. If it does the right thing on bootup, why would it mess up in case of resume?

I wish I had an answer to this. It may be a bug. On boot windows calculates number of processors from madt tables, but on resume it does the same by executing _STA method of each defined CPU.

I admitedly know almost nothing about windows, but one thing jumped to my eyes:
By looking at the device manager, hidden devices, the "working" cpu seems to be cpu1, not cpu0. Maybe this is related to this problem?

#7 lore raw
Quoted 3 lines · Glauber Costa

I admitedly know almost nothing about windows, but one thing jumped to my eyes:
By looking at the device manager, hidden devices, the "working" cpu seems to be cpu1, not cpu0. Maybe this is related to this problem?

I think this is just peculiarity of a device manager GUI. For me it shows CPUs in the order: 10-14 0-9 so working CPU appears to be fifth on the cpu list.

--
Gleb.

#8 lore raw
In reply to Gleb Natapov
Quoted 11 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA). This patch breaks resume from hibernate on windows 2008/vista.

The last change on that piece of code was made by you under the comment:

1) Disabled processor's _STA method should return 0 (this fixes Vista's BSOD on resuming after hibernate problem)

However, you did not changed it to 0, but to 9 instead. What did you meant?

It appears that windows won't accept bit 0 without bit 1 being set.

However, it works fine in my use case if _STA returns 0 or 8. The only real problem is, as I said, setting bit 0 but not bit 1. Does any among 0 or 8 works for your hibernate use case?

#9 lore raw
Quoted 13 lines · Glauber Costa
Quoted 11 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA). This patch breaks resume from hibernate on windows 2008/vista.

Quoted 7 lines

The last change on that piece of code was made by you under the comment:

1) Disabled processor's _STA method should return 0 (this fixes Vista's BSOD on resuming after hibernate problem)

However, you did not changed it to 0, but to 9 instead. What did you meant?

I wrote commit message before changing it to 9 :( I don't remember why I changed it to 9, but I think it was because of Linux CPU hot-plug.

Quoted 5 lines

It appears that windows won't accept bit 0 without bit 1 being set.

However, it works fine in my use case if _STA returns 0 or 8. The only real problem is, as I said, setting bit 0 but not bit 1. Does any among 0 or 8 works for your hibernate use case?

Can you check Linux cpu hot-plug please.

--
Gleb.

#10 lore raw
Quoted 24 lines · Gleb Natapov
Quoted 13 lines · Glauber Costa
Quoted 11 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA). This patch breaks resume from hibernate on windows 2008/vista.

Quoted 7 lines

The last change on that piece of code was made by you under the comment:

1) Disabled processor's _STA method should return 0 (this fixes Vista's BSOD on resuming after hibernate problem)

However, you did not changed it to 0, but to 9 instead. What did you meant?

I wrote commit message before changing it to 9 :( I don't remember why I changed it to 9, but I think it was because of Linux CPU hot-plug.

Quoted 6 lines
Quoted 5 lines

It appears that windows won't accept bit 0 without bit 1 being set.

However, it works fine in my use case if _STA returns 0 or 8. The only real problem is, as I said, setting bit 0 but not bit 1. Does any among 0 or 8 works for your hibernate use case?

Can you check Linux cpu hot-plug please.

Yeah, unfortunately neither work for linux cpu hotplug. Anything without bit 0 set won't work. So valid values appear to be 0x1, 0x3, 0x9, 0xB.

#11 lore raw
Quoted 25 lines · Glauber Costa
Quoted 24 lines · Gleb Natapov
Quoted 13 lines · Glauber Costa
Quoted 11 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa

This patch sets bits 1 in disabled processor's _STA. According to the ACPI spec, this bit means:
"Set if the device is enabled and decoding its resources."

Without it, Windows 2008 device manager shows the processors as malfunctioning hardware.

If you uncheck "show hidden devices" option in View menu of the device manager you should see only enabled CPUs (bit 2 of _STA). This patch breaks resume from hibernate on windows 2008/vista.

Quoted 7 lines

The last change on that piece of code was made by you under the comment:

1) Disabled processor's _STA method should return 0 (this fixes Vista's BSOD on resuming after hibernate problem)

However, you did not changed it to 0, but to 9 instead. What did you meant?

I wrote commit message before changing it to 9 :( I don't remember why I changed it to 9, but I think it was because of Linux CPU hot-plug.

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines

It appears that windows won't accept bit 0 without bit 1 being set.

However, it works fine in my use case if _STA returns 0 or 8. The only real problem is, as I said, setting bit 0 but not bit 1. Does any among 0 or 8 works for your hibernate use case?

Can you check Linux cpu hot-plug please.

Yeah, unfortunately neither work for linux cpu hotplug. Anything without bit 0 set won't work. So valid values appear to be 0x1, 0x3, 0x9, 0xB.

Theoretically we can provide different values for different OSes, but this is just a guess work since there is no any documentation how CPU hot-plug should work on x86.

--
Gleb.

#12 lore raw
Quoted 5 lines · Gleb Natapov

Theoretically we can provide different values for different OSes, but this is just a guess work since there is no any documentation how CPU hot-plug should work on x86.

ACPI in fact supports this, but I hope we don't have to do that.

Signature · 1 line
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
#13 lore raw
Quoted 8 lines · Avi Kivity
Quoted 5 lines · Gleb Natapov

Theoretically we can provide different values for different OSes, but this is just a guess work since there is no any documentation how CPU hot-plug should work on x86.

ACPI in fact supports this, but I hope we don't have to do that.

I believe it actually makes sense. It may even ease the acception into upstream projects. Note that cpu hotplug is totally non specified by ACPI. This implementation is "what linux expects", and does not work on windows at all (and I imagine it may not work on other OSes as well). For this case, it might make sense to provide different values for different OSes.

#14 lore raw
In reply to Avi Kivity
Quoted 9 lines · Avi Kivity
Quoted 5 lines · Gleb Natapov

Theoretically we can provide different values for different OSes, but this is just a guess work since there is no any documentation how CPU hot-plug should work on x86.

ACPI in fact supports this, but I hope we don't have to do that.

ACPI way is what I am talking about. Implement _OS object.

--
Gleb.

#15 lore raw
Quoted 9 lines · Gleb Natapov
Quoted 7 lines · Avi Kivity
Quoted 5 lines · Gleb Natapov

Theoretically we can provide different values for different OSes, but this is just a guess work since there is no any documentation how CPU hot-plug should work on x86.

Quoted 5 lines
Quoted 3 lines

ACPI in fact supports this, but I hope we don't have to do that.

ACPI way is what I am talking about. Implement _OS object.

/*
* The story of _OSI(Linux)
*
* From pre-history through Linux-2.6.22,
* Linux responded TRUE upon a BIOS OSI(Linux) query.
*
* Unfortunately, reference BIOS writers got wind of this
* and put OSI(Linux) in their example code, quickly exposing
* this string as ill-conceived and opening the door to
* an un-bounded number of BIOS incompatibilities.
*
* For example, OSI(Linux) was used on resume to re-POST a
* video card on one system, because Linux at that time
* could not do a speedy restore in its native driver.
* But then upon gaining quick native restore capability,
* Linux has no way to tell the BIOS to skip the time-consuming
* POST -- putting Linux at a permanent performance disadvantage.
* On another system, the BIOS writer used OSI(Linux)
* to infer native OS support for IPMI! On other systems,
* OSI(Linux) simply got in the way of Linux claiming to
* be compatible with other operating systems, exposing
* BIOS issues such as skipped device initialization.
*
* So "Linux" turned out to be a really poor chose of
* OSI string, and from Linux-2.6.23 onward we respond FALSE. *
* BIOS writers should NOT query _OSI(Linux) on future systems.
* Linux will complain on the console when it sees it, and return FALSE.
* To get Linux to return TRUE for your system will require
* a kernel source update to add a DMI entry,
* or boot with "acpi_osi=Linux"
*/

// Looks like no real content in this message?

Signature · 2 lines
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
#16 lore raw
Quoted 48 lines · Avi Kivity
Quoted 4 lines · Gleb Natapov
Quoted 2 lines · Avi Kivity

Gleb Natapov wrote:

Quoted 9 lines
Quoted 7 lines
Quoted 4 lines

Theoretically we can provide different values for different OSes, but this is just a guess work since there is no any documentation how CPU hot-plug should work on x86.

ACPI in fact supports this, but I hope we don't have to do that.

ACPI way is what I am talking about. Implement _OS object.

/*
* The story of _OSI(Linux)
*
* From pre-history through Linux-2.6.22,
* Linux responded TRUE upon a BIOS OSI(Linux) query.
*
* Unfortunately, reference BIOS writers got wind of this
* and put OSI(Linux) in their example code, quickly exposing
* this string as ill-conceived and opening the door to
* an un-bounded number of BIOS incompatibilities.
*
* For example, OSI(Linux) was used on resume to re-POST a
* video card on one system, because Linux at that time
* could not do a speedy restore in its native driver.
* But then upon gaining quick native restore capability,
* Linux has no way to tell the BIOS to skip the time-consuming
* POST -- putting Linux at a permanent performance disadvantage.
* On another system, the BIOS writer used OSI(Linux)
* to infer native OS support for IPMI! On other systems,
* OSI(Linux) simply got in the way of Linux claiming to
* be compatible with other operating systems, exposing
* BIOS issues such as skipped device initialization.
*
* So "Linux" turned out to be a really poor chose of
* OSI string, and from Linux-2.6.23 onward we respond FALSE. *
* BIOS writers should NOT query _OSI(Linux) on future systems.
* Linux will complain on the console when it sees it, and return FALSE.
* To get Linux to return TRUE for your system will require
* a kernel source update to add a DMI entry,
* or boot with "acpi_osi=Linux"
*/

Quoted 2 lines

// Looks like no real content in this message?

Now I recall something on LKML about this. Well, in this case Linux shouldn't have used ACPI to invent its own way to do cpu hot-plug. Interesting whether _OSI(Windows) will evaluate to TRUE on Linux.

--
Gleb.

#17 lore raw
Quoted 49 lines · Gleb Natapov
Quoted 48 lines · Avi Kivity
Quoted 4 lines · Gleb Natapov
Quoted 2 lines · Avi Kivity

Gleb Natapov wrote:

Quoted 9 lines
Quoted 7 lines
Quoted 4 lines

Theoretically we can provide different values for different OSes, but this is just a guess work since there is no any documentation how CPU hot-plug should work on x86.

ACPI in fact supports this, but I hope we don't have to do that.

ACPI way is what I am talking about. Implement _OS object.

/*
* The story of _OSI(Linux)
*
* From pre-history through Linux-2.6.22,
* Linux responded TRUE upon a BIOS OSI(Linux) query.
*
* Unfortunately, reference BIOS writers got wind of this
* and put OSI(Linux) in their example code, quickly exposing
* this string as ill-conceived and opening the door to
* an un-bounded number of BIOS incompatibilities.
*
* For example, OSI(Linux) was used on resume to re-POST a
* video card on one system, because Linux at that time
* could not do a speedy restore in its native driver.
* But then upon gaining quick native restore capability,
* Linux has no way to tell the BIOS to skip the time-consuming
* POST -- putting Linux at a permanent performance disadvantage.
* On another system, the BIOS writer used OSI(Linux)
* to infer native OS support for IPMI! On other systems,
* OSI(Linux) simply got in the way of Linux claiming to
* be compatible with other operating systems, exposing
* BIOS issues such as skipped device initialization.
*
* So "Linux" turned out to be a really poor chose of
* OSI string, and from Linux-2.6.23 onward we respond FALSE. *
* BIOS writers should NOT query _OSI(Linux) on future systems.
* Linux will complain on the console when it sees it, and return FALSE.
* To get Linux to return TRUE for your system will require
* a kernel source update to add a DMI entry,
* or boot with "acpi_osi=Linux"
*/

Quoted 4 lines
Quoted 2 lines

// Looks like no real content in this message?

Now I recall something on LKML about this. Well, in this case Linux shouldn't have used ACPI to invent its own way to do cpu hot-plug.

It didn't.
History shows that this method is what is used in some unisys machines, which seems to be the only ones implementing this around.

#18 lore raw
Quoted 5 lines · Glauber Costa
Quoted 2 lines

Now I recall something on LKML about this. Well, in this case Linux shouldn't have used ACPI to invent its own way to do cpu hot-plug.

It didn't.
History shows that this method is what is used in some unisys machines, which seems to be the only ones implementing this around.

The questions are: What is "this" that linux currently implements, how windows expects CPU hot-plug to work, are there any real x86 hardware that supports CPU host-plug and what should we do about all this.

--
Gleb.

#19 lore raw
Quoted 9 lines · Gleb Natapov
Quoted 5 lines · Glauber Costa
Quoted 2 lines

Now I recall something on LKML about this. Well, in this case Linux shouldn't have used ACPI to invent its own way to do cpu hot-plug.

It didn't.
History shows that this method is what is used in some unisys machines, which seems to be the only ones implementing this around.

The questions are: What is "this" that linux currently implements, how windows expects CPU hot-plug to work, are there any real x86 hardware that supports CPU host-plug and what should we do about all this.

as I said, there are unisys machines that implements cpu hotplug. The way they do it, is the way Linux kernel currently expects. The same way we implement on our BIOS.

#20 lore raw
Quoted 7 lines · Glauber Costa
Quoted 6 lines · Gleb Natapov
Quoted 5 lines · Glauber Costa
Quoted 2 lines

Now I recall something on LKML about this. Well, in this case Linux shouldn't have used ACPI to invent its own way to do cpu hot-plug.

It didn't.
History shows that this method is what is used in some unisys machines, which seems to be the only ones implementing this around.

Quoted 6 lines
Quoted 3 lines

The questions are: What is "this" that linux currently implements, how windows expects CPU hot-plug to work, are there any real x86 hardware that supports CPU host-plug and what should we do about all this.

as I said, there are unisys machines that implements cpu hotplug. The way they do it, is the way Linux kernel currently expects. The same way we implement on our BIOS.

I read that document too. And "based on some input from Natalie of Unisys" does not sound promising. Are those Unisys machines certified to run Windows 2008? Because if they are, they surely do something different from what we are doing.

--
Gleb.

#21 lore raw
Quoted 8 lines · Gleb Natapov
Quoted 7 lines · Glauber Costa
Quoted 6 lines · Gleb Natapov
Quoted 5 lines · Glauber Costa
Quoted 2 lines

Now I recall something on LKML about this. Well, in this case Linux shouldn't have used ACPI to invent its own way to do cpu hot-plug.

It didn't.
History shows that this method is what is used in some unisys machines, which seems to be the only ones implementing this around.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

The questions are: What is "this" that linux currently implements, how windows expects CPU hot-plug to work, are there any real x86 hardware that supports CPU host-plug and what should we do about all this.

as I said, there are unisys machines that implements cpu hotplug. The way they do it, is the way Linux kernel currently expects. The same way we implement on our BIOS.

I read that document too. And "based on some input from Natalie of Unisys" does not sound promising.

I'm not saying it is promising. Nothing un-specified is. Google search for the mails exchanged on the time of development of this also point in the direction that this is probably all we have.

Quoted 3 lines

Are those Unisys machines certified to run
Windows 2008? Because if they are, they surely do something different from what we are doing.

Unless they have a time machine, it is unlikely. Windows 2008 did not exist at the time