Allow selecting mv643xx_eth on Pegasos again
Subsystems (2)
PATCH 1/1 Allow selecting mv643xx_eth on Pegasos again
Since PPC_MUTIPLATFORM was removed, it was impossible to select the driver for mv643xx_eth on the Pegasos. Fix by allowing to select the driver on CHRP platforms; Pegasos is a CHRP platform and the driver will not work without arch/powerpc/platforms/chrp/pegasos_eth.
drivers/net/Kconfig +1 -1
@@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND config MV643XX_ETH tristate "Marvell Discovery (643XX) and Orion ethernet support" - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) || PLAT_ORION + depends on MV64X60 || PPC_CHRP || PLAT_ORION select INET_LRO select PHYLIB help
Quoted 2 lines
-----Original Message-----
From: [email protected]
[mailto:linuxppc-dev-
Quoted 1 line
[email protected]] On Behalf Of Gabriel
Paubert
Quoted 3 lines
Sent: Monday, May 18, 2009 12:38 PM
To: Lennert Buytenhek
Cc: [email protected]; LinuxPPC; [email protected];
[email protected]; David Miller
Quoted 5 lines
Subject: [PATCH] Allow selecting
mv643xx_ethon Pegasos again =20
SincePPC_MUTIPLATFORMwas removed, it was impossible to select the driver formv643xx_ethon the Pegasos. Fix by allowing to select the driver on CHRP platforms; Pegasos is a CHRP platform and the
driver
drivers/net/Kconfig
Quoted 13 lines
will not work without
arch/powerpc/platforms/chrp/pegasos_eth. =20Signed-off-by Gabriel Paubert <[email protected]>=20
drivers/net/Kconfig +0
-0@@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND=20
configMV643XX_ETHdrivers/net/Kconfig +0
-1tristate "Marvell Discovery (643XX) and Orion ethernet support" - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) ||
PLAT_ORION
drivers/net/Kconfig config UGETH_TX_ON_DEMAND · line 2357
Quoted 4 lines
drivers/net/Kconfig +1
-0+ depends on MV64X60 || PPC_CHRP || PLAT_ORION select INET_LRO select PHYLIB help
This got fixed here:
http://git.kernel.org/?p=3Dlinux/kernel/git/davem/net-next-2.6.git;a=3Dco=
mmi tdiff;h=3D952ee9df26c487f2d73b2dced58ec904f19ea0f8
Cheers,
Emil.
Quoted 29 lines · On Mon, May 18, 2009 at 10:48:58AM -0700, Medve Emilian-EMMEDVE1 wrote:
Quoted 2 lines
-----Original Message-----
From: [email protected][mailto:linuxppc-dev-
Quoted 1 line
[email protected]] On Behalf Of Gabriel
Paubert
Quoted 3 lines
Sent: Monday, May 18, 2009 12:38 PM
To: Lennert Buytenhek
Cc: [email protected]; LinuxPPC; [email protected];[email protected]; David Miller
Quoted 5 lines
Subject: [PATCH] Allow selecting
mv643xx_ethon Pegasos againSince
PPC_MUTIPLATFORMwas removed, it was impossible to select the driver formv643xx_ethon the Pegasos. Fix by allowing to select the driver on CHRP platforms; Pegasos is a CHRP platform and thedriver
drivers/net/Kconfig config UGETH_TX_ON_DEMAND · line 2354
Quoted 13 lines
will not work without
arch/powerpc/platforms/chrp/pegasos_eth.Signed-off-by Gabriel Paubert <[email protected]>drivers/net/Kconfig +0
-1@@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND config MV643XX_ETH tristate "Marvell Discovery (643XX) and Orion ethernet support" - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) ||
PLAT_ORION
Quoted 8 lines
drivers/net/Kconfig config UGETH_TX_ON_DEMAND · line 2357
Quoted 4 lines
drivers/net/Kconfig +1
-0+ depends on MV64X60 || PPC_CHRP || PLAT_ORION select INET_LRO select PHYLIB helpThis got fixed here:
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commi
tdiff;h=952ee9df26c487f2d73b2dced58ec904f19ea0f8
Ok, I was not aware of it, but the fact is that MV64360 no more exists and the only non MV64X60 platform that may need it is the Pegasos (to my knowledge) and it relies on some platform specific code enabled by PPC_CHRP.
Regards,
Gabriel
Hello Gabriel,
Quoted 5 lines
-----Original Message-----
From: Gabriel Paubert [mailto:[email protected]]
Sent: Monday, May 18, 2009 1:48 PM
To: Medve Emilian-EMMEDVE1
Cc: Lennert Buytenhek; [email protected]; LinuxPPC; [email protected];
[email protected]; David
Quoted 4 lines
Miller
Subject: Re: [PATCH] Allow selectingmv643xx_ethon Pegasos again =20
On Mon, May 18, 2009 at 10:48:58AM -0700, Medve Emilian-EMMEDVE1
Quoted 2 lines · wrote:
Quoted 2 lines
Quoted 2 lines
-----Original Message-----
From: =
Quoted 2 lines
Quoted 2 lines
[mailto:linuxppc-dev-
Quoted 1 line
[email protected]] On Behalf Of
Gabriel
Quoted 8 lines
Quoted 8 lines
Paubert
Quoted 3 lines
Sent: Monday, May 18, 2009 12:38 PM
To: Lennert Buytenhek
Cc: [email protected]; LinuxPPC; [email protected];[email protected]; David Miller
Quoted 3 lines
Subject: [PATCH] Allow selecting
mv643xx_ethon Pegasos againSince
PPC_MUTIPLATFORMwas removed, it was impossible to select
the
Quoted 17 lines
Quoted 17 lines
Quoted 2 lines
driver for
mv643xx_ethon the Pegasos. Fix by allowing to select the driver on CHRP platforms; Pegasos is a CHRP platform and thedriver
drivers/net/Kconfig config UGETH_TX_ON_DEMAND · line 2354
Quoted 13 lines
will not work without
arch/powerpc/platforms/chrp/pegasos_eth.Signed-off-by Gabriel Paubert <[email protected]>drivers/net/Kconfig +0
-1@@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND config MV643XX_ETH tristate "Marvell Discovery (643XX) and Orion ethernet support" - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) ||
PLAT_ORION
Quoted 7 lines
Quoted 7 lines
drivers/net/Kconfig config UGETH_TX_ON_DEMAND · line 2357
Quoted 4 lines
drivers/net/Kconfig +1
-0+ depends on MV64X60 || PPC_CHRP || PLAT_ORION select INET_LRO select PHYLIB helpThis got fixed here:
http://git.kernel.org/?p=3Dlinux/kernel/git/davem/net-next-2.6.git;a=3Dco=
mmi
Quoted 4 lines
Quoted 1 line
tdiff;h=3D952ee9df26c487f2d73b2dced58ec904f19ea0f8
=20
Ok, I was not aware of it, but the fact is that MV64360 no more exists and the only non MV64X60 platform that may need it is the Pegasos (to
my
Quoted 2 lines
knowledge) and it relies on some platform specific code enabled by
PPC_CHRP.
You're correct. MV64360 seems to be stale. Do you want to re-spin your patch to get rid of it?
(I wouldn't create a dependency between MV643XX_ETH and PPC_CHRP.) =20
Cheers,
Emil.
Hello Medve
Quoted 3 lines · On Mon, May 18, 2009 at 01:15:12PM -0700, Medve Emilian-EMMEDVE1 wrote:
You're correct. MV64360 seems to be stale. Do you want to re-spin your patch to get rid of it?
No problem, bu should I respin in from the current official git or on top of yours?
Quoted 2 lines
(I wouldn't create a dependency between
MV643XX_ETHandPPC_CHRP.)
Fine with me.
Regards,
Gabriel
Hello Gabriel,
Quoted 5 lines
-----Original Message-----
From: Gabriel Paubert [mailto:[email protected]]
Sent: Monday, May 18, 2009 5:19 PM
To: Medve Emilian-EMMEDVE1
Cc: Lennert Buytenhek; [email protected]; LinuxPPC; [email protected];
[email protected]; David
Quoted 6 lines
Miller
Subject: Re: [PATCH] Allow selectingmv643xx_ethon Pegasos again =20
Hello Medve
=20
On Mon, May 18, 2009 at 01:15:12PM -0700, Medve Emilian-EMMEDVE1
Quoted 2 lines · wrote:
Quoted 2 lines
You're correct. MV64360 seems to be stale. Do you want to re-spin
your
Quoted 5 lines
Quoted 1 line
patch to get rid of it?
=20
=20
No problem, bu should I respin in from the current official git or on top of yours?
Top of the tree should be good.
Cheers,
Emil.
Quoted 6 lines
Quoted 1 line
(I wouldn't create a dependency between
MV643XX_ETHandPPC_CHRP.)=20
Fine with me.
=20
Regards,
Gabriel
PATCH v2 1/1 Allow selecting mv643xx_eth on Pegasos again
Since PPC_MUTIPLATFORM was removed, it was impossible to select the driver for mv643xx_eth on the Pegasos. Fix it and take the opportunity to remove the stale MV64360 config option.
drivers/net/Kconfig +1 -1
@@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND config MV643XX_ETH tristate "Marvell Discovery (643XX) and Orion ethernet support" - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) || PLAT_ORION + depends on MV64X60 || PPC32 || PLAT_ORION select INET_LRO select PHYLIB help
David Miller
maintainerFrom: Gabriel Paubert <[email protected]>
Date: Tue, 19 May 2009 01:21:13 +0200
Quoted 5 lines
Since
PPC_MUTIPLATFORMwas removed, it was impossible to select the driver formv643xx_ethon the Pegasos. Fix it and take the opportunity to remove the stale MV64360 config option.Signed-off-by Gabriel Paubert <[email protected]>
This patch doesn't even apply to net-next-2.6, please send me changes relative to that.
PATCH v3 1/1 Remove obsolete MV64360 config option
drivers/net/Kconfig +1 -1
@@ -2350,7 +2350,7 @@ config UGETH_TX_ON_DEMAND config MV643XX_ETH tristate "Marvell Discovery (643XX) and Orion ethernet support" - depends on MV64360 || MV64X60 || PPC32 || PLAT_ORION + depends on MV64X60 || PPC32 || PLAT_ORION select INET_LRO select PHYLIB help
Re: [PATCH v3] Remove obsolete MV64360 config option
From: Gabriel Paubert <[email protected]>
Date: Tue, 19 May 2009 09:40:45 +0200
Quoted 1 line
Signed-off-by Gabriel Paubert <[email protected]>
Applied to net-next-2.6, thanks.