Skip to contentSkip to conversation

common: fix inline--weak error spotted by gcc 4.4

PATCH New Kim Phillips 2 participants 2 messages May 19, 2009 – May 20, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 common: fix inline--weak error spotted by gcc 4.4

cmd_ide.c:547: error: inline function 'ide_inb' cannot be declared weak

removing the inline attribute fixes it.

---
 common/cmd_ide.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
common/cmd_ide.c +2 -2
index 782ad1c..d86bf37 100644
@@ -532,7 +532,7 @@ __ide_outb(int dev, int port, unsigned char val)
 		dev, port, val, (ATA_CURR_BASE(dev)+CONFIG_SYS_ATA_PORT_ADDR(port)));
 	outb(val, (ATA_CURR_BASE(dev)+CONFIG_SYS_ATA_PORT_ADDR(port)));
 }
-void inline ide_outb (int dev, int port, unsigned char val)
+void ide_outb (int dev, int port, unsigned char val)
 		__attribute__((weak, alias("__ide_outb")));
 
 unsigned char inline
@@ -544,7 +544,7 @@ __ide_inb(int dev, int port)
 		dev, port, (ATA_CURR_BASE(dev)+CONFIG_SYS_ATA_PORT_ADDR(port)), val);
 	return val;
 }
-unsigned char inline ide_inb(int dev, int port)
+unsigned char ide_inb(int dev, int port)
 			__attribute__((weak, alias("__ide_inb")));
 
 #ifdef CONFIG_TUNE_PIO
Signature · 1 line
1.6.3.1
#1 lore raw

PATCH 2/2 common: fix inline--weak error spotted by gcc 4.4

Dear Kim Phillips,

Quoted 8 lines · In message <[email protected]> you wrote:

cmd_ide.c:547: error: inline function 'ide_inb' cannot be declared weak

removing the inline attribute fixes it.

---
 common/cmd_ide.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Applied (to master) as agreed.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A little suffering is good for the soul.
	-- Kirk, "The Corbomite Maneuver", stardate 1514.0