bc47xx : export ssb_watchdog_timer_set
Subsystems (4)
PATCH 1/1 bc47xx : export ssb_watchdog_timer_set
Hi,
this patch export ssb_watchdog_timer_set to allow to use it in a Linux watchdog driver.
drivers/ssb/embedded.c +1 -0
@@ -29,6 +29,7 @@ int ssb_watchdog_timer_set(struct ssb_bus *bus, u32 ticks) }return -ENODEV ; } +EXPORT_SYMBOL (ssb_watchdog_timer_set);u32 ssb_gpio_in (struct ssb_bus *bus,u32 mask) {
Quoted 7 lines · matthieu castet
Hi,
this patch export
ssb_watchdog_timer_setto allow to use it in a Linux watchdog driver.Signed-off-by Matthieu CASTET <[email protected]>
What is the merge path for ssb nowadays? I used to take these patches (and I'm still happy to do so), but maybe Ralf is (or should be) taking them now?
John
Signature · 2 lines
John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready.
Quoted 7 lines · On Tuesday 19 May 2009 00:41:28 John W. Linville wrote:
Quoted 6 lines · matthieu castet
Hi,
this patch export
ssb_watchdog_timer_setto allow to use it in a Linux watchdog driver.
Quoted 5 lines
Quoted 1 line
Signed-off-by Matthieu CASTET <[email protected]>What is the merge path for ssb nowadays? I used to take these patches (and I'm still happy to do so), but maybe Ralf is (or should be) taking them now?
That depends on his speed. Last time I submitted a patch through his path, it bitrotted for several months before it finally hit mainline.
Signature · 1 line
Greetings, Michael.
Quoted 6 lines · Michael Buesch
Quoted 3 lines
What is the merge path for ssb nowadays? I used to take these patches (and I'm still happy to do so), but maybe Ralf is (or should be) taking them now?
That depends on his speed. Last time I submitted a patch through his path, it bitrotted for several months before it finally hit mainline.
Maybe because I felt drivers/ssb/ was outside my jurisdiction - and unlike what alot of people may seem to think I'm not a full time MIPS kernel hacker.
I can deal with SSB patch if you so desire - but I have no experience with SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I queue them up. I can keep them either in the usual MIPS trees on linux-mips.org or I could create a separate linux-ssb tree, depending on what seems to be sensible. Also, reading the entry in the maintainers file I wonder if netdev is really the list of a choice?
Ralf
Quoted 3 lines · On Tuesday 19 May 2009 19:09:57 Ralf Baechle wrote:
Maybe because I felt
drivers/ssb/was outside my jurisdiction - and unlike what alot of people may seem to think I'm not a full time MIPS kernel hacker.
Ok nice.
Quoted 3 lines
I can deal with SSB patch if you so desire - but I have no experience with SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I queue them up.
**Fwoo..
[stamp here]
..mppp**
Done. :)
Quoted 4 lines
I can keep them either in the usual MIPS trees on linux-mips.org or I could create a separate linux-ssb tree, depending on what seems to be sensible. Also, reading the entry in the maintainers file I wonder if netdev is really the list of a choice?
Yes it is, because the bus is only used on networking devices. (Ethernet cards, wireless cards, and network routers)
I don't think you need to create a separate tree. ssb is pretty mature. There won't be that many patches.
Signature · 1 line
Greetings, Michael.
Quoted 23 lines · Michael Buesch
Quoted 3 lines · On Tuesday 19 May 2009 19:09:57 Ralf Baechle wrote:
Maybe because I felt
drivers/ssb/was outside my jurisdiction - and unlike what alot of people may seem to think I'm not a full time MIPS kernel hacker.Ok nice.
Quoted 3 lines
I can deal with SSB patch if you so desire - but I have no experience with SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I queue them up.
**Fwoo..
[stamp here]..mppp**Done. :)
Quoted 4 lines
I can keep them either in the usual MIPS trees on linux-mips.org or I could create a separate linux-ssb tree, depending on what seems to be sensible. Also, reading the entry in the maintainers file I wonder if netdev is really the list of a choice?
Quoted 4 lines
Yes it is, because the bus is only used on networking devices. (Ethernet cards, wireless cards, and network routers)
I don't think you need to create a separate tree. ssb is pretty mature. There won't be that many patches.
OK, now I'm confused again -- should I take SSB patches, or is Ralf going to do it? :-)
John
Signature · 2 lines
John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready.
Quoted 33 lines · John W. Linville
From: "John W. Linville" <[email protected]>
Date: Tue, 19 May 2009 13:35:03 -0400
To: Michael Buesch <[email protected]>
Cc: Ralf Baechle <[email protected]>,
matthieu castet <[email protected]>, [email protected], [email protected]
Subject: Re: [PATCH] bc47xx : exportssb_watchdog_timer_set
Content-Type: text/plain; charset=us-asciiQuoted 23 lines · Michael Buesch
Quoted 3 lines · On Tuesday 19 May 2009 19:09:57 Ralf Baechle wrote:
Maybe because I felt
drivers/ssb/was outside my jurisdiction - and unlike what alot of people may seem to think I'm not a full time MIPS kernel hacker.Ok nice.
Quoted 3 lines
I can deal with SSB patch if you so desire - but I have no experience with SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I queue them up.
**Fwoo..
[stamp here]..mppp**Done. :)
Quoted 4 lines
I can keep them either in the usual MIPS trees on linux-mips.org or I could create a separate linux-ssb tree, depending on what seems to be sensible. Also, reading the entry in the maintainers file I wonder if netdev is really the list of a choice?
Quoted 7 lines
Quoted 4 lines
Yes it is, because the bus is only used on networking devices. (Ethernet cards, wireless cards, and network routers)
I don't think you need to create a separate tree. ssb is pretty mature. There won't be that many patches.OK, now I'm confused again -- should I take SSB patches, or is Ralf going to do it? :-)
My decoder ring says, I'll do it from now on :)
Cheers,
Ralf
Quoted 6 lines · Ralf Baechle
Quoted 2 lines · John W. Linville
OK, now I'm confused again -- should I take SSB patches, or is Ralf going to do it? :-)
My decoder ring says, I'll do it from now on :)
ACK
Signature · 2 lines
John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready.
Quoted 39 lines · On Wednesday 20 May 2009 09:15:13 Ralf Baechle wrote:
Quoted 38 lines · John W. Linville
From: "John W. Linville" <[email protected]>
Date: Tue, 19 May 2009 13:35:03 -0400
To: Michael Buesch <[email protected]>
Cc: Ralf Baechle <[email protected]>,
matthieu castet <[email protected]>, [email protected], [email protected]
Subject: Re: [PATCH] bc47xx : exportssb_watchdog_timer_set
Content-Type: text/plain; charset=us-asciiQuoted 27 lines · Michael Buesch
Quoted 3 lines · On Tuesday 19 May 2009 19:09:57 Ralf Baechle wrote:
Maybe because I felt
drivers/ssb/was outside my jurisdiction - and unlike what alot of people may seem to think I'm not a full time MIPS kernel hacker.Ok nice.
Quoted 3 lines
I can deal with SSB patch if you so desire - but I have no experience with SSB, so I'd have somebody to rubberstamp non-trivial SSB patches before I queue them up.
**Fwoo..
[stamp here]..mppp**Done. :)
Quoted 4 lines
I can keep them either in the usual MIPS trees on linux-mips.org or I could create a separate linux-ssb tree, depending on what seems to be sensible. Also, reading the entry in the maintainers file I wonder if netdev is really the list of a choice?
Yes it is, because the bus is only used on networking devices. (Ethernet cards, wireless cards, and network routers)
I don't think you need to create a separate tree. ssb is pretty mature. There won't be that many patches.
Quoted 4 lines
Quoted 2 lines
OK, now I'm confused again -- should I take SSB patches, or is Ralf going to do it? :-)
My decoder ring says, I'll do it from now on :)
Ok, nice. :)
Matthieu, can you resend them to Ralf? He doesn't have them, yet.
Signature · 1 line
Greetings, Michael.
Hi,
Quoted 6 lines · Michael Buesch
On Wednesday 20 May 2009 09:15:13 Ralf Baechle wrote:
Ok, nice. :)
Matthieu, can you resend them to Ralf? He doesn't have them, yet.
Off course.
BTW what's the procedure for submitting patch on mips ?
I already CC linux-mips, on the first patch submission.
Now that it is acked by maintainer, I should resend it to linux-mips + Ralf ?
Thanks
Matthieu
Quoted 7 lines · On Tuesday 19 May 2009 00:10:07 matthieu castet wrote:
Hi,
this patch export
ssb_watchdog_timer_setto allow to use it in a Linux watchdog driver.Signed-off-by Matthieu CASTET <[email protected]>
Well, you need to be careful. The watchdog is also used for system reboot. Make sure to disable the watchdog driver when the bcm47xx system code wants to use it.
Otherwise, ack. You can submit this to [email protected].
Signature · 1 line
Greetings, Michael.
Quoted 12 lines · Michael Buesch
Quoted 6 lines · On Tuesday 19 May 2009 00:10:07 matthieu castet wrote:
Hi,
this patch export
ssb_watchdog_timer_setto allow to use it in a Linux watchdog driver.Signed-off-by Matthieu CASTET <[email protected]>Well, you need to be careful. The watchdog is also used for system reboot. Make sure to disable the watchdog driver when the bcm47xx system code wants to use it.
It shouldn't be a problem : the system code always disable irq before using watchdog to reboot/halt (unless I miss other watchdog usage).
Matthieu