Skip to contentSkip to conversation

Improvements and fixes to HW Breakpoint interface

PATCH In review K.Prasad 2 participants 2 messages May 19, 2009

lore
Share & tools
lore

K.Prasad

author
#0 lore raw

cover Improvements and fixes to HW Breakpoint interface

Hi Alan,
Please find a couple of patches that contain improvements to the HW Breakpoint
interface code (discovered while porting the infrastructure on another architecture) and a minor fix - the details of which are described in the patch header.

These patches can be applied over the patchset submitted over -tip here:
http://lkml.org/lkml/2009/5/15/139.

As they carry some of your suggestions, I will be glad to have it reviewed by you.

Hi Frederic,
There's a minor style issue in the ksym tracer plugin (declaration of a
function in .c file) which has now been corrected. Kindly review the same.

Thanks,
K.Prasad

#1 lore raw
Quoted 5 lines · K.Prasad

Hi Alan,
Please find a couple of patches that contain improvements to the HW Breakpoint
interface code (discovered while porting the infrastructure on another architecture) and a minor fix - the details of which are described in the patch header.

Quoted 8 lines

These patches can be applied over the patchset submitted over -tip here:
http://lkml.org/lkml/2009/5/15/139.

As they carry some of your suggestions, I will be glad to have it reviewed by you.

Hi Frederic,
There's a minor style issue in the ksym tracer plugin (declaration of a
function in .c file) which has now been corrected. Kindly review the same.

The ftrace part looks good, indeed such style issue is usually warned by checkpatch.pl Thanks.

Ingo,

What do you think of the current state of the hardware breakpoint patchset? If I'm not wrong, it has not yet been applied in -tip. Do you have mixed feelings about it?
IIRC it has been mostly (fully?) acked by Alan Stern, I've also reviewed the ftrace patch.

Frederic.