Skip to contentSkip to conversation

ipv6: route templates missing protocol value

PATCH In review Stephen Hemminger 2 participants 2 messages May 20, 2009 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 1/1 ipv6: route templates missing protocol value

The IPV6 routing templates are missing the protocol value so when they are used, the routes have the protocol RTPROT_UNSPEC (0). This confuses Zebra routing protocol daemon that makes kernel routes a special case. This was first noticed by Jean-Mickael Guerin who wrote this patch.

---
 net/ipv6/route.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
net/ipv6/route.c +3 -0
@@ -137,6 +137,7 @@ static struct rt6_info ip6_null_entry_te
 		}
 	},
 	.rt6i_flags	= (RTF_REJECT | RTF_NONEXTHOP),
+	.rt6i_protocol	= RTPROT_KERNEL,
 	.rt6i_metric	= ~(u32) 0,
 	.rt6i_ref	= ATOMIC_INIT(1),
 };
@@ -159,6 +160,7 @@ static struct rt6_info ip6_prohibit_entr
 		}
 	},
 	.rt6i_flags	= (RTF_REJECT | RTF_NONEXTHOP),
+	.rt6i_protocol	= RTPROT_KERNEL,
 	.rt6i_metric	= ~(u32) 0,
 	.rt6i_ref	= ATOMIC_INIT(1),
 };
@@ -176,6 +178,7 @@ static struct rt6_info ip6_blk_hole_entr
 		}
 	},
 	.rt6i_flags	= (RTF_REJECT | RTF_NONEXTHOP),
+	.rt6i_protocol	= RTPROT_KERNEL,
 	.rt6i_metric	= ~(u32) 0,
 	.rt6i_ref	= ATOMIC_INIT(1),
 };
maintainer
#3 lore raw

From: Stephen Hemminger <[email protected]>
Date: Wed, 20 May 2009 12:30:38 -0700

Quoted 7 lines

The IPV6 routing templates are missing the protocol value so when they are used, the routes have the protocol RTPROT_UNSPEC (0). This confuses Zebra routing protocol daemon that makes kernel routes a special case. This was first noticed by Jean-Mickael Guerin who wrote this patch.

What's wrong with Jean-Mickael Guerin's patch? He provided a signoff and everything.

Are you Napoleon? :-)