qemu-kvm: Handle -no-shutodwn
PATCH 1/1 qemu-kvm: Handle -no-shutodwn
Plain QEMU has the parameter -no-shutdown. This avoids termination of the qemu process when VM got shutdown (e.g. to still use the QEMU-Monitor with stopped VM). This parameter has no effect on qemu-kvm, today.
This patch introduces identical handling, as in qemu, of -no-shutdown for qemu-kvm:
* termination of qemu-kvm process on a VM shutdown get only avoided once
* second shutdown of VM cause termination of qemu-kvm (like in qemu)
---
qemu-kvm.c | 9 ++++++--- sysemu.h | 1 + vl.c | 7 +++++++ 3 files changed, 14 insertions(+), 3 deletions(-)
qemu-kvm.c +6 -3
@@ -597,9 +597,12 @@ int kvm_main_loop(void)while (1 ) {main_loop_wait (1000 ); -if (qemu_shutdown_requested ()) -break ; -else if (qemu_powerdown_requested ()) +if (qemu_shutdown_requested ()) { +if (qemu_no_shutdown ()) { +vm_stop (0 ); + }else +break ; + }else if (qemu_powerdown_requested ())qemu_system_powerdown ();else if (qemu_reset_requested ())qemu_kvm_system_reset ();
sysemu.h +1 -0
@@ -35,6 +35,7 @@ void cpu_disable_ticks(void);void qemu_system_reset_request (void );void qemu_system_shutdown_request (void );void qemu_system_powerdown_request (void ); +int qemu_no_shutdown (void );int qemu_shutdown_requested (void );int qemu_reset_requested (void );int qemu_powerdown_requested (void );
vl.c +7 -0
@@ -3644,6 +3644,13 @@ static int powerdown_requested;static int debug_requested;static int vmstop_requested; +int qemu_no_shutdown (void ) +{ +int r = no_shutdown; + no_shutdown =0 ; +return r; +} +int qemu_shutdown_requested (void ) {int r = shutdown_requested;
Signature · 8 lines
Daniel Gollub Geschaeftsfuehrer: Ralph Dehner FOSS Developer Unternehmenssitz: Vohburg B1 Systems GmbH Amtsgericht: Ingolstadt Mobil: +49-(0)-160 47 73 970 Handelsregister: HRB 3537 EMail: [email protected] http://www.b1-systems.de Adresse: B1 Systems GmbH, Osterfeldstraße 7, 85088 Vohburg http://pgpkeys.pca.dfn.de/pks/lookup?op=get&search=0xED14B95C2F8CA78D
Avi Kivity
AppliedQuoted 11 lines · Daniel Gollub
Plain QEMU has the parameter -no-shutdown. This avoids termination of the qemu process when VM got shutdown (e.g. to still use the QEMU-Monitor with stopped VM). This parameter has no effect on qemu-kvm, today.
This patch introduces identical handling, as in qemu, of -no-shutdown for qemu-kvm:
* termination of qemu-kvm process on a VM shutdown get only avoided once
* second shutdown of VM cause termination of qemu-kvm (like in qemu)
Applied, thanks.
What is the reason for the wierd semantics? I'd expect -no-shutdown to keep functioning even after the first shutdown.
Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 8 lines · Avi Kivity
Quoted 7 lines · Daniel Gollub
Plain QEMU has the parameter -no-shutdown. This avoids termination of the qemu process when VM got shutdown (e.g. to still use the QEMU-Monitor with stopped VM). This parameter has no effect on qemu-kvm, today.
This patch introduces identical handling, as in qemu, of -no-shutdown for qemu-kvm:
Quoted 8 lines
Quoted 4 lines
* termination of qemu-kvm process on a VM shutdown get only avoided once
* second shutdown of VM cause termination of qemu-kvm (like in qemu)Applied, thanks.
What is the reason for the wierd semantics?
No idea.
Quoted 2 lines
I'd expect -no-shutdown to
keep functioning even after the first shutdown.
I would prefer something like this as well. But this way it's 1:1 the same behavior as with plain QEMU. I'll prepare a propsoal + patch for changing this in QEMU. If this gets accepted i'll changed it for qemu-kvm as well.
Best Regards,
Daniel
Signature · 8 lines
Daniel Gollub Geschaeftsfuehrer: Ralph Dehner FOSS Developer Unternehmenssitz: Vohburg B1 Systems GmbH Amtsgericht: Ingolstadt Mobil: +49-(0)-160 47 73 970 Handelsregister: HRB 3537 EMail: [email protected] http://www.b1-systems.de Adresse: B1 Systems GmbH, Osterfeldstraße 7, 85088 Vohburg http://pgpkeys.pca.dfn.de/pks/lookup?op=get&search=0xED14B95C2F8CA78D