linux-user: add tee systemcall support
PATCH 1/1 linux-user: add tee systemcall support
--- linux-user/syscall.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
linux-user/syscall.c +0 -0
@@ -6580,6 +6580,14 @@ abi_long do_syscall(void *cpu_env, int num,
abi_long arg1,
break;
#endif
+#ifdef TARGET_NR_tee
+ case TARGET_NR_tee:
+ {
+ ret = get_errno(tee(arg1,arg2,arg3,arg4));
+ }
+ break;
+#endif
+
default:
unimplemented:
gemu_log("qemu: Unsupported syscall: %d\n", num);Signature · 1 line
1.6.0
hi all,
Quoted 1 line
Subject: [Qemu-devel] [PATCH ] linux-user: add tee systemcall support
Is there any thing wrong with this patch. Please give some feedback So if there is anything wrong i will be able to correct it.
Thanks & Regards
vibi sreenivasan
linux-user/syscall.c abi_long do_syscall(void *cpu_env, int num, · line 6580
Quoted 11 lines
Signed-off-by vibi <[email protected]>---
linux-user/syscall.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)linux-user/syscall.c +0
-0@@ -6580,6 +6580,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
break;
Quoted 13 lines
linux-user/syscall.c +8
-0#endif +#ifdef TARGET_NR_tee +case TARGET_NR_tee: + { + ret =get_errno (tee (arg1,arg2,arg3,arg4)); + } +break ; +#endif +default : unimplemented:gemu_log ("qemu: Unsupported syscall: %d\n" , num);
hi all,
Quoted 1 line
Subject: [Qemu-devel] [PATCH ] linux-user: add tee systemcall support
Is there any thing wrong with this patch. Please give some feedback So if there is anything wrong i will be able to correct it.
Thanks & Regards
vibi sreenivasan
linux-user/syscall.c abi_long do_syscall(void *cpu_env, int num, · line 6580
Quoted 11 lines
Signed-off-by vibi <[email protected]>---
linux-user/syscall.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)linux-user/syscall.c +0
-0@@ -6580,6 +6580,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
break;
Quoted 13 lines
linux-user/syscall.c +8
-0#endif +#ifdef TARGET_NR_tee +case TARGET_NR_tee: + { + ret =get_errno (tee (arg1,arg2,arg3,arg4)); + } +break ; +#endif +default : unimplemented:gemu_log ("qemu: Unsupported syscall: %d\n" , num);
Quoted 6 lines · vibi sreenivasan
hi all,
Quoted 1 line
Subject: [Qemu-devel] [PATCH ] linux-user: add tee systemcall support
Is there any thing wrong with this patch. Please give some feedback So if there is anything wrong i will be able to correct it.
The implementation of tee appears fine. However, the tee testcases I found all also used splice. What did you use to test this, or do you plan to implement splice too?
Quoted 33 lines
Thanks & Regards
vibi sreenivasanlinux-user/syscall.c abi_long do_syscall(void *cpu_env, int num, · line 6580
Quoted 11 lines
Signed-off-by vibi <[email protected]>---
linux-user/syscall.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)linux-user/syscall.c +0
-0@@ -6580,6 +6580,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,break;Quoted 13 lines
linux-user/syscall.c +8
-0#endif +#ifdef TARGET_NR_tee +case TARGET_NR_tee: + { + ret =get_errno (tee (arg1,arg2,arg3,arg4)); + } +break ; +#endif +default : unimplemented:gemu_log ("qemu: Unsupported syscall: %d\n" , num);
hi ,
thanks for looking into my code.
Quoted 10 lines · Riku Voipio
Quoted 6 lines · vibi sreenivasan
hi all,
Quoted 1 line
Subject: [Qemu-devel] [PATCH ] linux-user: add tee systemcall support
Is there any thing wrong with this patch. Please give some feedback So if there is anything wrong i will be able to correct it.
The implementation of tee appears fine. However, the tee testcases I found all also used splice. What did you use to test this
i used a small test code
----------------------------------------------------------------------------------------
#define _GNU_SOURCE
#include <fcntl.h>
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#define die(X) do { perror(#X);exit(EXIT_FAILURE); } while(0)
#define SZ 255
#define TEST_STRING "This is a test to check the presence of tee system call\n\
This print states that tee system call is present\n"
int main(void)
{
int pipe1[2], pipe2[2],strln = strlen(TEST_STRING);
char data[SZ] = {0};
if (pipe(pipe1) || pipe(pipe2))
die("perror");
if (write(pipe1[1], TEST_STRING, strln) < 0)
die("write");
if(tee(pipe1[0], pipe2[1], strln, SPLICE_F_MOVE) != strln)
die("tee");
if(read(pipe2[0], data, SZ - 1) < 0)
die("read");
printf("%s",data);
fflush(stdout);
}----------------------------------------------------------------------------------------------
Quoted 3 lines
, or do
you plan to implement splice too?
yes i am plannig to implement splice & vmsplice. Also i have a plan to look in to adding support for unimplemented syscalls (got that idea from TODO),if any.
Before that i was trying to make sure that i am going in the right path.
thanks & regards
vibi sreenivasan
Quoted 37 lines
Quoted 33 lines
Thanks & Regards
vibi sreenivasanlinux-user/syscall.c abi_long do_syscall(void *cpu_env, int num, · line 6580
Quoted 11 lines
Signed-off-by vibi <[email protected]>---
linux-user/syscall.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)linux-user/syscall.c +0
-0@@ -6580,6 +6580,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,break;Quoted 13 lines
linux-user/syscall.c +8
-0#endif +#ifdef TARGET_NR_tee +case TARGET_NR_tee: + { + ret =get_errno (tee (arg1,arg2,arg3,arg4)); + } +break ; +#endif +default : unimplemented:gemu_log ("qemu: Unsupported syscall: %d\n" , num);
Quoted 6 lines · vibi sreenivasan
yes i am plannig to implement splice & vmsplice. Also i have a plan to look in to adding support for unimplemented syscalls (got that idea from TODO),if any.
Before that i was trying to make sure that i am going in the right path.
looks good, worked also fine with tests.
dropped to my linux-user git tree:
https://git.maemo.org/projects/qemu/gitweb?p=qemu;a=shortlog;h=refs/heads/linux-user-for-upstream
Quoted 43 lines
thanks & regards
vibi sreenivasanQuoted 37 lines
Quoted 33 lines
Thanks & Regards
vibi sreenivasanlinux-user/syscall.c abi_long do_syscall(void *cpu_env, int num, · line 6580
Quoted 11 lines
Signed-off-by vibi <[email protected]>---
linux-user/syscall.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)linux-user/syscall.c +0
-0@@ -6580,6 +6580,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,break;Quoted 13 lines
linux-user/syscall.c +8
-0#endif +#ifdef TARGET_NR_tee +case TARGET_NR_tee: + { + ret =get_errno (tee (arg1,arg2,arg3,arg4)); + } +break ; +#endif +default : unimplemented:gemu_log ("qemu: Unsupported syscall: %d\n" , num);
hi,
Quoted 7 lines
looks good, worked also fine with tests.
dropped to my linux-user git tree:
https://git.maemo.org/projects/qemu/gitweb?p=qemu;a=shortlog;h=refs/heads/linux-user-for-upstream
is there a separate development tree for linux user?
regards
vibi sreenivasan
vibi sreenivasan <[email protected]> writes:
Hi,
Quoted 11 lines
hi,
Quoted 7 lines
looks good, worked also fine with tests.
dropped to my linux-user git tree:
https://git.maemo.org/projects/qemu/gitweb?p=qemu;a=shortlog;h=refs/heads/linux-user-for-upstream
is there a separate development tree for linux user?
I would rather say that there's no "maintainer" for the linux-user stuff (according to the MAINTAINERS) but there are people interested in getting it working who have a git tree.
Regards,
Arnaud
hi,
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
looks good, worked also fine with tests.
dropped to my linux-user git tree:
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
https://git.maemo.org/projects/qemu/gitweb?p=qemu;a=shortlog;h=refs/heads/linux-user-for-upstream
is there a separate development tree for linux user?
I would rather say that there's no "maintainer" for the linux-user stuff (according to the
MAINTAINERS) but there are people interested in getting it working who have a git tree.
Thanks for that information.
So on which tree do i have to base my work on.
Thanks & Regards
Vibi Sreenivasan
Quoted 6 lines
Regards,
Arnaud