tracing/events: change the type of __str_loc_item to unsigned short
PATCH 1/1 tracing/events: change the type of __str_loc_item to unsigned short
When defining a dynamic size string, we add __str_loc_##item to the trace entry, and it stores the location of the actual string in entry->_str_data[]
'unsigned short' should be sufficient to store this information, thus we save 2 bytes per dyn-size string in the ring buffer.
[ Impact: reduce memory occupied by dyn-size strings in ring buffer ]
--- include/trace/ftrace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/trace/ftrace.h +1 -1
@@ -25,7 +25,7 @@#define __field (type, item) type item;#undef __string -#define __string (item, src) int __str_loc_##item; +#define __string (item, src) unsigned short __str_loc_##item;#undef TP_STRUCT__entry #define TP_STRUCT__entry(args...) args
-- 1.5.4.rc3
Quoted 19 lines · Li Zefan
When defining a dynamic size string, we add __str_loc_##item to the trace entry, and it stores the location of the actual string in entry->_str_data[]
'unsigned short' should be sufficient to store this information, thus we save 2 bytes per dyn-size string in the ring buffer.
[ Impact: reduce memory occupied by dyn-size strings in ring buffer ]
Signed-off-by Li Zefan <[email protected]>--- include/trace/ftrace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/trace/ftrace.h +0
-0
include/trace/ftrace.h
Quoted 9 lines
include/trace/ftrace.h +1
-2@@ -25,7 +25,7 @@#define __field (type, item) type item;#undef __string -#define __string (item, src) int __str_loc_##item; +#define __string (item, src) unsigned short __str_loc_##item;#undef TP_STRUCT__entry #define TP_STRUCT__entry(args...) args -- 1.5.4.rc3
Yeah, a max length of about 32000 is sufficient, the filter engine is bounded to MAX_FILTER_STR_VAL anyway :)
Commit-ID: b0aae68cc5508f3c2fbf728988c954db4c8b8a53 Gitweb: http://git.kernel.org/tip/b0aae68cc5508f3c2fbf728988c954db4c8b8a53 Author: Li Zefan <[email protected]> AuthorDate: Thu, 21 May 2009 13:59:18 +0800 Committer: Frederic Weisbecker <[email protected]> CommitDate: Tue, 26 May 2009 00:15:21 +0200
tracing/events: change the type of __str_loc_item to unsigned short
When defining a dynamic size string, we add __str_loc_##item to the trace entry, and it stores the location of the actual string in entry->_str_data[]
'unsigned short' should be sufficient to store this information, thus we save 2 bytes per dyn-size string in the ring buffer.
[ Impact: reduce memory occupied by dyn-size strings in ring buffer ]
LKML-Reference: <[email protected]>
--- include/trace/ftrace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/trace/ftrace.h +1 -1
@@ -25,7 +25,7 @@#define __field (type, item) type item;#undef __string -#define __string (item, src) int __str_loc_##item; +#define __string (item, src) unsigned short __str_loc_##item;#undef TP_STRUCT__entry #define TP_STRUCT__entry(args...) args