Skip to contentSkip to conversation

ide-tape: remove back-to-back REQUEST_SENSE detection

PATCH In review Borislav Petkov 3 participants 4 messages May 27, 2009 – Jun 9, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide-tape: remove back-to-back REQUEST_SENSE detection

Hi,

please include, commit id upstream:

1e75540ec5202cae63cd238c86bd880e3d496546

---
From: Tejun Heo <[email protected]>
Date: Wed, 27 May 2009 09:12:05 +0200
Subject: [PATCH] ide-tape: remove back-to-back REQUEST_SENSE detection

Impact: fix an oops which always triggers

ide_tape_issue_pc() assumed drive->pc isn't NULL on invocation when checking for back-to-back request sense issues but drive->pc can be NULL and even when it's not NULL, it's not safe to dereference it once the previous command is complete because pc could have been freed or was on stack. Kill back-to-back REQUEST_SENSE detection.

---
 drivers/ide/ide-tape.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/ide/ide-tape.c +0 -6
index 4e6181c..af7860c 100644
@@ -654,12 +654,6 @@ static ide_startstop_t idetape_issue_pc(ide_drive_t *drive,
 {
 	idetape_tape_t *tape = drive->driver_data;
 
-	if (drive->pc->c[0] == REQUEST_SENSE &&
-	    pc->c[0] == REQUEST_SENSE) {
-		printk(KERN_ERR "ide-tape: possible ide-tape.c bug - "
-			"Two request sense in serial were issued\n");
-	}
-
 	if (tape->failed_pc == NULL && pc->c[0] != REQUEST_SENSE)
 		tape->failed_pc = pc;
 
Signature · 5 lines
1.6.3.1

-- 
Regards/Gruss,
    Boris.
#1 lore raw
Quoted 5 lines · On Wednesday 27 May 2009 09:20:04 Borislav Petkov wrote:

Hi,

please include, commit id upstream:

1e75540ec5202cae63cd238c86bd880e3d496546

This is for-next branch..

The right commit is 36999a5af1b6c5379e59f0ddf434db08d03c19e4 (because it was later cherry picked into for-linus) and has my S-o-B line.

#2 lore raw
Quoted 11 lines · Bartlomiej Zolnierkiewicz
Quoted 5 lines · On Wednesday 27 May 2009 09:20:04 Borislav Petkov wrote:

Hi,

please include, commit id upstream:

1e75540ec5202cae63cd238c86bd880e3d496546

This is for-next branch..

The right commit is 36999a5af1b6c5379e59f0ddf434db08d03c19e4 (because it was later cherry picked into for-linus) and has my S-o-B line.

Thanks, had the wrong commit id noted here.

Signature · 2 lines
Regards/Gruss,
    Boris.
#3 lore raw
Quoted 6 lines · Borislav Petkov
Quoted 5 lines · Bartlomiej Zolnierkiewicz
Quoted 4 lines · On Wednesday 27 May 2009 09:20:04 Borislav Petkov wrote:

Hi,

please include, commit id upstream:

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

1e75540ec5202cae63cd238c86bd880e3d496546

This is for-next branch..

The right commit is 36999a5af1b6c5379e59f0ddf434db08d03c19e4 (because it was later cherry picked into for-linus) and has my S-o-B line.

Thanks, had the wrong commit id noted here.

Now queued up, thanks.

greg k-h