add more statics & drop some unused functions
PATCH 1/1 add more statics & drop some unused functions
A lot more functions could be made static, but they need forward declarations; this does some easy ones, and also found a few unused functions in the process.
---
linux-2.6/xfs_super.c | 2 +- linux-2.6/xfs_sync.c | 16 ---------------- linux-2.6/xfs_sync.h | 1 - xfs_ag.h | 3 --- xfs_alloc.c | 2 +- xfs_bmap.c | 2 +- xfs_bmap.h | 11 ----------- xfs_bmap_btree.c | 20 ++++++++++---------- xfs_bmap_btree.h | 1 - xfs_btree.c | 42 +----------------------------------------- xfs_btree.h | 15 --------------- xfs_inode.c | 8 ++++---- xfs_inode.h | 5 ----- xfs_itable.c | 2 +- xfs_itable.h | 5 ----- xfs_log_priv.h | 2 -- xfs_log_recover.c | 2 +- xfs_mount.c | 2 +- xfs_mount.h | 3 --- xfs_mru_cache.c | 29 ----------------------------- xfs_mru_cache.h | 1 - xfs_rw.h | 6 ------ xfs_vnodeops.c | 2 +- 23 files changed, 22 insertions(+), 160 deletions(-)
fs/xfs/linux-2.6/xfs_super.c +1 -1
@@ -688,7 +688,7 @@ xfs_barrier_test(return error; } -void +STATIC voidxfs_mountfs_check_barriers (xfs_mount_t *mp) {int error;
fs/xfs/linux-2.6/xfs_sync.c +0 -16
@@ -640,22 +640,6 @@ __xfs_inode_clear_reclaim_tag( XFS_INO_TO_AGINO(mp, ip->i_ino), XFS_ICI_RECLAIM_TAG); } -void -xfs_inode_clear_reclaim_tag ( -xfs_inode_t *ip) -{ -xfs_mount_t *mp = ip->i_mount; -xfs_perag_t *pag =xfs_get_perag (mp, ip->i_ino); - -read_lock (&pag->pag_ici_lock); -spin_lock (&ip->i_flags_lock); -__xfs_inode_clear_reclaim_tag (mp, pag, ip); -spin_unlock (&ip->i_flags_lock); -read_unlock (&pag->pag_ici_lock); -xfs_put_perag (mp, pag); -} - - STATIC void xfs_reclaim_inodes_ag( xfs_mount_t *mp,
fs/xfs/linux-2.6/xfs_sync.h +0 -1
@@ -51,7 +51,6 @@ int xfs_reclaim_inode(struct xfs_inode *int xfs_reclaim_inodes (struct xfs_mount *mp,int noblock,int mode);void xfs_inode_set_reclaim_tag (struct xfs_inode *ip); -void xfs_inode_clear_reclaim_tag (struct xfs_inode *ip);void __xfs_inode_clear_reclaim_tag (struct xfs_mount *mp,struct xfs_perag *pag,struct xfs_inode *ip);#endif
fs/xfs/xfs_ag.h +0 -3
@@ -91,9 +91,6 @@ typedef struct xfs_agf {#define XFS_AGF_BLOCK (mp) XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp))#define XFS_BUF_TO_AGF (bp) ((xfs_agf_t *)XFS_BUF_PTR(bp)) -extern int xfs_read_agf (struct xfs_mount *mp,struct xfs_trans *tp, -xfs_agnumber_t agno,int flags,struct xfs_buf **bpp); -/* * Size of the unlinked inode hash table in the agi. */
fs/xfs/xfs_alloc.c +1 -1
@@ -2248,7 +2248,7 @@ xfs_alloc_put_freelist(/* * Read in the allocation group header (free/alloc section). */ -int /* error */ +STATIC int /* error */ xfs_read_agf( struct xfs_mount *mp, /* mount point structure */ struct xfs_trans *tp, /* transaction pointer */
fs/xfs/xfs_bmap.c +1 -1
@@ -3713,7 +3713,7 @@ done:* entry (null if none). Else, *lastxp will be set to the index * of the found entry; *gotp will contain the entry. */ -xfs_bmbt_rec_host_t */* pointer to found extent entry */ +STATIC xfs_bmbt_rec_host_t * /* pointer to found extent entry */ xfs_bmap_search_multi_extents( xfs_ifork_t *ifp, /* inode fork pointer */ xfs_fileoff_t bno, /* block number searched for */
fs/xfs/xfs_bmap.h +0 -11
@@ -392,17 +392,6 @@ xfs_bmap_count_blocks(int whichfork, int *count); -/* -* Search the extent records for the entry containing block bno. -* If bno lies in a hole, point to the next entry. If bno lies -* past eof, *eofp will be set, and *prevp will contain the last -* entry (null if none). Else, *lastxp will be set to the index -* of the found entry; *gotp will contain the entry. -*/ -xfs_bmbt_rec_host_t * -xfs_bmap_search_multi_extents (struct xfs_ifork *,xfs_fileoff_t ,int *, -xfs_extnum_t *,xfs_bmbt_irec_t *,xfs_bmbt_irec_t *); -#endif /* __KERNEL__ */ #endif /* __XFS_BMAP_H__ */
fs/xfs/xfs_bmap_btree.c +10 -10
@@ -202,16 +202,6 @@ xfs_bmbt_get_state( ext_flag); } -/* Endian flipping versions of the bmbt extraction functions */ -void -xfs_bmbt_disk_get_all ( -xfs_bmbt_rec_t *r, -xfs_bmbt_irec_t *s) -{ -__xfs_bmbt_get_all (get_unaligned_be64 (&r->l0), -get_unaligned_be64 (&r->l1), s); -} -/* * Extract the blockcount field from an on disk bmap extent record. */
@@ -816,6 +806,16 @@ xfs_bmbt_trace_key( *l1 =0 ; } +/* Endian flipping versions of the bmbt extraction functions */ +STATIC void +xfs_bmbt_disk_get_all ( +xfs_bmbt_rec_t *r, +xfs_bmbt_irec_t *s) +{ +__xfs_bmbt_get_all (get_unaligned_be64 (&r->l0), +get_unaligned_be64 (&r->l1), s); +} + STATIC void xfs_bmbt_trace_record( struct xfs_btree_cur *cur,
fs/xfs/xfs_bmap_btree.h +0 -1
@@ -220,7 +220,6 @@ extern xfs_fsblock_t xfs_bmbt_get_startbextern xfs_fileoff_t xfs_bmbt_get_startoff (xfs_bmbt_rec_host_t *r);extern xfs_exntst_t xfs_bmbt_get_state (xfs_bmbt_rec_host_t *r); -extern void xfs_bmbt_disk_get_all (xfs_bmbt_rec_t *r,xfs_bmbt_irec_t *s);extern xfs_filblks_t xfs_bmbt_disk_get_blockcount (xfs_bmbt_rec_t *r);extern xfs_fileoff_t xfs_bmbt_disk_get_startoff (xfs_bmbt_rec_t *r);
fs/xfs/xfs_btree.c +1 -41
54 lines not on this page · raw message
fs/xfs/xfs_btree.h +0 -15
@@ -379,20 +379,6 @@ xfs_btree_read_bufl( int refval);/* ref count value for buffer *//* -* Get a buffer for the block, return it read in. -* Short-form addressing. -*/ -int /* error */ -xfs_btree_read_bufs ( -struct xfs_mount *mp,/* file system mount point */ -struct xfs_trans *tp,/* transaction pointer */ -xfs_agnumber_t agno,/* allocation group number */ -xfs_agblock_t agbno,/* allocation group block number */ -uint lock,/* lock flags for read_buf */ -struct xfs_buf **bpp,/* buffer for agno/agbno */ -int refval);/* ref count value for buffer */ - -/* * Read-ahead the block, don't wait for it, don't return a buffer. * Long-form addressing. */
@@ -432,7 +418,6 @@ int xfs_btree_decrement(struct xfs_btreeint xfs_btree_lookup (struct xfs_btree_cur *,xfs_lookup_t ,int *);int xfs_btree_update (struct xfs_btree_cur *,union xfs_btree_rec *);int xfs_btree_new_iroot (struct xfs_btree_cur *,int *,int *); -int xfs_btree_kill_iroot (struct xfs_btree_cur *);int xfs_btree_insert (struct xfs_btree_cur *,int *);int xfs_btree_delete (struct xfs_btree_cur *,int *);int xfs_btree_get_rec (struct xfs_btree_cur *,union xfs_btree_rec **,int *);
fs/xfs/xfs_inode.c +4 -4
@@ -642,7 +642,7 @@ xfs_iformat_btree(return 0 ; } -void +STATIC voidxfs_dinode_from_disk (xfs_icdinode_t *to,xfs_dinode_t *from)
@@ -1238,7 +1238,7 @@ xfs_isize_check(* In that case the pages will still be in memory, but the inode size * will never have been updated. */ -xfs_fsize_t +STATIC xfs_fsize_txfs_file_last_byte (xfs_inode_t *ip) {
@@ -3828,7 +3828,7 @@ xfs_iext_inline_to_direct(/* * Resize an extent indirection array to new_size bytes. */ -void +STATIC voidxfs_iext_realloc_indirect (xfs_ifork_t *ifp,/* inode fork pointer */ int new_size)/* new indirection array size */
@@ -3853,7 +3853,7 @@ xfs_iext_realloc_indirect(/* * Switch from indirection array to linear (direct) extent allocations. */ -void +STATIC voidxfs_iext_indirect_to_direct (xfs_ifork_t *ifp)/* inode fork pointer */ {
fs/xfs/xfs_inode.h +0 -5
@@ -520,7 +520,6 @@ void xfs_ipin(xfs_inode_t *);void xfs_iunpin (xfs_inode_t *);int xfs_iflush (xfs_inode_t *,uint );void xfs_ichgtime (xfs_inode_t *,int ); -xfs_fsize_t xfs_file_last_byte (xfs_inode_t *);void xfs_lock_inodes (xfs_inode_t **,int ,uint );void xfs_lock_two_inodes (xfs_inode_t *,xfs_inode_t *,uint );
@@ -588,8 +587,6 @@ int xfs_itobp(struct xfs_mount *, struc struct xfs_buf **, uint);int xfs_iread (struct xfs_mount *,struct xfs_trans *,struct xfs_inode *,xfs_daddr_t ,uint ); -void xfs_dinode_from_disk (struct xfs_icdinode *, -struct xfs_dinode *);void xfs_dinode_to_disk (struct xfs_dinode *,struct xfs_icdinode *);void xfs_idestroy_fork (struct xfs_inode *,int );
@@ -608,8 +605,6 @@ void xfs_iext_remove_inline(xfs_ifork_tvoid xfs_iext_remove_direct (xfs_ifork_t *,xfs_extnum_t ,int );void xfs_iext_remove_indirect (xfs_ifork_t *,xfs_extnum_t ,int );void xfs_iext_realloc_direct (xfs_ifork_t *,int ); -void xfs_iext_realloc_indirect (xfs_ifork_t *,int ); -void xfs_iext_indirect_to_direct (xfs_ifork_t *);void xfs_iext_direct_to_inline (xfs_ifork_t *,xfs_extnum_t );void xfs_iext_inline_to_direct (xfs_ifork_t *,int );void xfs_iext_destroy (xfs_ifork_t *);
fs/xfs/xfs_itable.c +1 -1
@@ -39,7 +39,7 @@#include "xfs_error.h" #include "xfs_btree.h" -int +STATIC intxfs_internal_inum (xfs_mount_t *mp,xfs_ino_t ino)
fs/xfs/xfs_itable.h +0 -5
@@ -99,11 +99,6 @@ xfs_bulkstat_one(void *dibuff, int *stat); -int -xfs_internal_inum ( -xfs_mount_t *mp, -xfs_ino_t ino); - typedef int (*inumbers_fmt_pf)( void __user *ubuffer, /* buffer to write to */ const xfs_inogrp_t *buffer, /* buffer to read from */
fs/xfs/xfs_log_priv.h +0 -2
@@ -451,8 +451,6 @@ extern int xlog_find_tail(xlog_t *log,extern int xlog_recover (xlog_t *log);extern int xlog_recover_finish (xlog_t *log);extern void xlog_pack_data (xlog_t *log,xlog_in_core_t *iclog,int ); -extern void xlog_recover_process_iunlinks (xlog_t *log); -extern struct xfs_buf *xlog_get_bp (xlog_t *,int );extern void xlog_put_bp (struct xfs_buf *);
fs/xfs/xfs_log_recover.c +1 -1
@@ -3237,7 +3237,7 @@ xlog_recover_process_one_iunlink(* freeing of the inode and its removal from the list must be * atomic. */ -void +STATIC voidxlog_recover_process_iunlinks (xlog_t *log) {
fs/xfs/xfs_mount.c +1 -1
@@ -1568,7 +1568,7 @@ xfs_mod_sb(xfs_trans_t *tp, __int64_t fi* * The m_sb_lock must be held when this routine is called. */ -int +STATIC int xfs_mod_incore_sb_unlocked( xfs_mount_t *mp, xfs_sb_field_t field,
fs/xfs/xfs_mount.h +0 -3
@@ -415,13 +415,10 @@ typedef struct xfs_mod_sb {extern int xfs_log_sbcount (xfs_mount_t *,uint );extern int xfs_mountfs (xfs_mount_t *mp); -extern void xfs_mountfs_check_barriers (xfs_mount_t *mp);extern void xfs_unmountfs (xfs_mount_t *);extern int xfs_unmountfs_writesb (xfs_mount_t *);extern int xfs_mod_incore_sb (xfs_mount_t *,xfs_sb_field_t ,int64_t ,int ); -extern int xfs_mod_incore_sb_unlocked (xfs_mount_t *,xfs_sb_field_t , -int64_t ,int );extern int xfs_mod_incore_sb_batch (xfs_mount_t *,xfs_mod_sb_t *,uint ,int );extern int xfs_mount_log_sb (xfs_mount_t *,__int64_t );
fs/xfs/xfs_mru_cache.c +0 -29
@@ -564,35 +564,6 @@ xfs_mru_cache_lookup( }/* -* To look up an element using its key, but leave its location in the internal -* lists alone, call xfs_mru_cache_peek(). If the element isn't found, this -* function returns NULL. -* -* See the comments above the declaration of the xfs_mru_cache_lookup() function -* for important locking information pertaining to this call. -*/ -void * -xfs_mru_cache_peek ( -xfs_mru_cache_t *mru, -unsigned long key) -{ -xfs_mru_cache_elem_t *elem; - -ASSERT (mru && mru->lists); -if (!mru || !mru->lists) -return NULL ; - -spin_lock (&mru->lock); - elem =radix_tree_lookup (&mru->store, key); -if (!elem) -spin_unlock (&mru->lock); -else -__release (mru_lock);/* help sparse not be stupid */ - -return elem ? elem->value :NULL ; -} - -/* * To release the internal data structure spinlock after having performed an * xfs_mru_cache_lookup() or an xfs_mru_cache_peek(), call xfs_mru_cache_done() * with the data store pointer.
fs/xfs/xfs_mru_cache.h +0 -1
@@ -49,7 +49,6 @@ int xfs_mru_cache_insert(struct xfs_mru_void *xfs_mru_cache_remove (struct xfs_mru_cache *mru,unsigned long key);void xfs_mru_cache_delete (struct xfs_mru_cache *mru,unsigned long key);void *xfs_mru_cache_lookup (struct xfs_mru_cache *mru,unsigned long key); -void *xfs_mru_cache_peek (struct xfs_mru_cache *mru,unsigned long key);void xfs_mru_cache_done (struct xfs_mru_cache *mru);#endif /* __XFS_MRU_CACHE_H__ */
fs/xfs/xfs_rw.h +0 -6
@@ -78,10 +78,4 @@ extern int xfs_read_buf(struct xfs_mountextern void xfs_ioerror_alert (char *func,struct xfs_mount *mp,xfs_buf_t *bp,xfs_daddr_t blkno); -/* -* Prototypes for functions in xfs_vnodeops.c. -*/ -extern int xfs_free_eofblocks (struct xfs_mount *mp,struct xfs_inode *ip, -int flags); -#endif /* __XFS_RW_H__ */
fs/xfs/xfs_vnodeops.c +1 -1
@@ -702,7 +702,7 @@ xfs_fsync(* when the link count isn't zero and by xfs_dm_punch_hole() when * punching a hole to EOF. */ -int +STATIC int xfs_free_eofblocks( xfs_mount_t *mp, xfs_inode_t *ip,
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 3 lines · Eric Sandeen
A lot more functions could be made static, but they need forward declarations; this does some easy ones, and also found a few unused functions in the process.
Looks good to me.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Christoph Hellwig
Quoted 3 lines · Eric Sandeen
A lot more functions could be made static, but they need forward declarations; this does some easy ones, and also found a few unused functions in the process.
Looks good to me.
Felix, do you plan to merge this one?
Thanks,
-Eric
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 10 lines · Eric Sandeen
Quoted 7 lines · Christoph Hellwig
Quoted 3 lines · Eric Sandeen
A lot more functions could be made static, but they need forward declarations; this does some easy ones, and also found a few unused functions in the process.
Looks good to me.
Felix, do you plan to merge this one?
Yep, will merge and push it to oss shortly.
Felix
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 10 lines · Eric Sandeen
Quoted 7 lines · Christoph Hellwig
Quoted 3 lines · Eric Sandeen
A lot more functions could be made static, but they need forward declarations; this does some easy ones, and also found a few unused functions in the process.
Looks good to me.
Felix, do you plan to merge this one?
Eric, this patch doesn't apply cleanly now:
Applying xfs: add more statics & drop some unused functions
error: patch failed: fs/xfs/linux-2.6/xfs_sync.c:640
error: fs/xfs/linux-2.6/xfs_sync.c: patch does not apply
error: patch failed: fs/xfs/linux-2.6/xfs_sync.h:51
error: fs/xfs/linux-2.6/xfs_sync.h: patch does not apply Patch failed at 0002.
Can you rebase and repost it?
Thanks,
Felix
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 26 lines · Felix Blyakher
Quoted 4 lines · Eric Sandeen
Quoted 2 lines · Christoph Hellwig
On Tue, May 26, 2009 at 02:05:09PM -0500, Eric Sandeen wrote:
Quoted 9 lines
Quoted 7 lines
Quoted 4 lines
A lot more functions could be made static, but they need forward declarations; this does some easy ones, and also found a few unused functions in the process.
Looks good to me.
Felix, do you plan to merge this one?
Eric, this patch doesn't apply cleanly now:
Applying xfs: add more statics & drop some unused functions
error: patch failed:fs/xfs/linux-2.6/xfs_sync.c:640
error:fs/xfs/linux-2.6/xfs_sync.c: patch does not apply
error: patch failed:fs/xfs/linux-2.6/xfs_sync.h:51
error:fs/xfs/linux-2.6/xfs_sync.h: patch does not apply Patch failed at 0002.
Quoted 6 lines
Can you rebase and repost it?
Thanks,
Felix
This one applies to linus' tree ok....
-Eric
fs/xfs/linux-2.6/xfs_super.c +1 -1
@@ -687,7 +687,7 @@ xfs_barrier_test(return error; } -void +STATIC voidxfs_mountfs_check_barriers (xfs_mount_t *mp) {int error;
fs/xfs/linux-2.6/xfs_sync.c +0 -15
@@ -740,21 +740,6 @@ __xfs_inode_clear_reclaim_tag( XFS_INO_TO_AGINO(mp, ip->i_ino), XFS_ICI_RECLAIM_TAG); } -void -xfs_inode_clear_reclaim_tag ( -xfs_inode_t *ip) -{ -xfs_mount_t *mp = ip->i_mount; -xfs_perag_t *pag =xfs_get_perag (mp, ip->i_ino); - -read_lock (&pag->pag_ici_lock); -spin_lock (&ip->i_flags_lock); -__xfs_inode_clear_reclaim_tag (mp, pag, ip); -spin_unlock (&ip->i_flags_lock); -read_unlock (&pag->pag_ici_lock); -xfs_put_perag (mp, pag); -} - STATIC int xfs_reclaim_inode_now( struct xfs_inode *ip,
fs/xfs/linux-2.6/xfs_sync.h +0 -1
@@ -48,7 +48,6 @@ int xfs_reclaim_inode(struct xfs_inode *ip, int locked, int sync_mode);int xfs_reclaim_inodes (struct xfs_mount *mp,int mode);void xfs_inode_set_reclaim_tag (struct xfs_inode *ip); -void xfs_inode_clear_reclaim_tag (struct xfs_inode *ip);void __xfs_inode_clear_reclaim_tag (struct xfs_mount *mp,struct xfs_perag *pag,struct xfs_inode *ip);
fs/xfs/xfs_ag.h +0 -3
@@ -91,9 +91,6 @@ typedef struct xfs_agf {#define XFS_AGF_BLOCK (mp) XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp))#define XFS_BUF_TO_AGF (bp) ((xfs_agf_t *)XFS_BUF_PTR(bp)) -extern int xfs_read_agf (struct xfs_mount *mp,struct xfs_trans *tp, -xfs_agnumber_t agno,int flags,struct xfs_buf **bpp); -/* * Size of the unlinked inode hash table in the agi. */
fs/xfs/xfs_alloc.c +1 -1
@@ -2248,7 +2248,7 @@ xfs_alloc_put_freelist(/* * Read in the allocation group header (free/alloc section). */ -int /* error */ +STATIC int /* error */ xfs_read_agf( struct xfs_mount *mp, /* mount point structure */ struct xfs_trans *tp, /* transaction pointer */
fs/xfs/xfs_bmap.c +1 -1
@@ -3713,7 +3713,7 @@ done:* entry (null if none). Else, *lastxp will be set to the index * of the found entry; *gotp will contain the entry. */ -xfs_bmbt_rec_host_t */* pointer to found extent entry */ +STATIC xfs_bmbt_rec_host_t * /* pointer to found extent entry */ xfs_bmap_search_multi_extents( xfs_ifork_t *ifp, /* inode fork pointer */ xfs_fileoff_t bno, /* block number searched for */
fs/xfs/xfs_bmap.h +0 -11
@@ -392,17 +392,6 @@ xfs_bmap_count_blocks(int whichfork, int *count); -/* -* Search the extent records for the entry containing block bno. -* If bno lies in a hole, point to the next entry. If bno lies -* past eof, *eofp will be set, and *prevp will contain the last -* entry (null if none). Else, *lastxp will be set to the index -* of the found entry; *gotp will contain the entry. -*/ -xfs_bmbt_rec_host_t * -xfs_bmap_search_multi_extents (struct xfs_ifork *,xfs_fileoff_t ,int *, -xfs_extnum_t *,xfs_bmbt_irec_t *,xfs_bmbt_irec_t *); -#endif /* __KERNEL__ */ #endif /* __XFS_BMAP_H__ */
fs/xfs/xfs_bmap_btree.c +10 -10
@@ -202,16 +202,6 @@ xfs_bmbt_get_state( ext_flag); } -/* Endian flipping versions of the bmbt extraction functions */ -void -xfs_bmbt_disk_get_all ( -xfs_bmbt_rec_t *r, -xfs_bmbt_irec_t *s) -{ -__xfs_bmbt_get_all (get_unaligned_be64 (&r->l0), -get_unaligned_be64 (&r->l1), s); -} -/* * Extract the blockcount field from an on disk bmap extent record. */
@@ -816,6 +806,16 @@ xfs_bmbt_trace_key( *l1 =0 ; } +/* Endian flipping versions of the bmbt extraction functions */ +STATIC void +xfs_bmbt_disk_get_all ( +xfs_bmbt_rec_t *r, +xfs_bmbt_irec_t *s) +{ +__xfs_bmbt_get_all (get_unaligned_be64 (&r->l0), +get_unaligned_be64 (&r->l1), s); +} + STATIC void xfs_bmbt_trace_record( struct xfs_btree_cur *cur,
fs/xfs/xfs_bmap_btree.h +0 -1
@@ -220,7 +220,6 @@ extern xfs_fsblock_t xfs_bmbt_get_startblock(xfs_bmbt_rec_host_t *r);extern xfs_fileoff_t xfs_bmbt_get_startoff (xfs_bmbt_rec_host_t *r);extern xfs_exntst_t xfs_bmbt_get_state (xfs_bmbt_rec_host_t *r); -extern void xfs_bmbt_disk_get_all (xfs_bmbt_rec_t *r,xfs_bmbt_irec_t *s);extern xfs_filblks_t xfs_bmbt_disk_get_blockcount (xfs_bmbt_rec_t *r);extern xfs_fileoff_t xfs_bmbt_disk_get_startoff (xfs_bmbt_rec_t *r);
fs/xfs/xfs_btree.c +1 -41
54 lines not on this page · raw message
fs/xfs/xfs_btree.h +0 -15
@@ -379,20 +379,6 @@ xfs_btree_read_bufl( int refval);/* ref count value for buffer *//* -* Get a buffer for the block, return it read in. -* Short-form addressing. -*/ -int /* error */ -xfs_btree_read_bufs ( -struct xfs_mount *mp,/* file system mount point */ -struct xfs_trans *tp,/* transaction pointer */ -xfs_agnumber_t agno,/* allocation group number */ -xfs_agblock_t agbno,/* allocation group block number */ -uint lock,/* lock flags for read_buf */ -struct xfs_buf **bpp,/* buffer for agno/agbno */ -int refval);/* ref count value for buffer */ - -/* * Read-ahead the block, don't wait for it, don't return a buffer. * Long-form addressing. */
@@ -432,7 +418,6 @@ int xfs_btree_decrement(struct xfs_btree_cur *, int, int *);int xfs_btree_lookup (struct xfs_btree_cur *,xfs_lookup_t ,int *);int xfs_btree_update (struct xfs_btree_cur *,union xfs_btree_rec *);int xfs_btree_new_iroot (struct xfs_btree_cur *,int *,int *); -int xfs_btree_kill_iroot (struct xfs_btree_cur *);int xfs_btree_insert (struct xfs_btree_cur *,int *);int xfs_btree_delete (struct xfs_btree_cur *,int *);int xfs_btree_get_rec (struct xfs_btree_cur *,union xfs_btree_rec **,int *);
fs/xfs/xfs_inode.c +4 -4
@@ -641,7 +641,7 @@ xfs_iformat_btree(return 0 ; } -void +STATIC voidxfs_dinode_from_disk (xfs_icdinode_t *to,xfs_dinode_t *from)
@@ -1237,7 +1237,7 @@ xfs_isize_check(* In that case the pages will still be in memory, but the inode size * will never have been updated. */ -xfs_fsize_t +STATIC xfs_fsize_txfs_file_last_byte (xfs_inode_t *ip) {
@@ -3827,7 +3827,7 @@ xfs_iext_inline_to_direct(/* * Resize an extent indirection array to new_size bytes. */ -void +STATIC voidxfs_iext_realloc_indirect (xfs_ifork_t *ifp,/* inode fork pointer */ int new_size)/* new indirection array size */
@@ -3852,7 +3852,7 @@ xfs_iext_realloc_indirect(/* * Switch from indirection array to linear (direct) extent allocations. */ -void +STATIC voidxfs_iext_indirect_to_direct (xfs_ifork_t *ifp)/* inode fork pointer */ {
fs/xfs/xfs_inode.h +0 -5
@@ -521,7 +521,6 @@ void xfs_ipin(xfs_inode_t *);void xfs_iunpin (xfs_inode_t *);int xfs_iflush (xfs_inode_t *,uint );void xfs_ichgtime (xfs_inode_t *,int ); -xfs_fsize_t xfs_file_last_byte (xfs_inode_t *);void xfs_lock_inodes (xfs_inode_t **,int ,uint );void xfs_lock_two_inodes (xfs_inode_t *,xfs_inode_t *,uint );
@@ -589,8 +588,6 @@ int xfs_itobp(struct xfs_mount *, struct xfs_trans *, struct xfs_buf **, uint);int xfs_iread (struct xfs_mount *,struct xfs_trans *,struct xfs_inode *,xfs_daddr_t ,uint ); -void xfs_dinode_from_disk (struct xfs_icdinode *, -struct xfs_dinode *);void xfs_dinode_to_disk (struct xfs_dinode *,struct xfs_icdinode *);void xfs_idestroy_fork (struct xfs_inode *,int );
@@ -609,8 +606,6 @@ void xfs_iext_remove_inline(xfs_ifork_t *, xfs_extnum_t, int);void xfs_iext_remove_direct (xfs_ifork_t *,xfs_extnum_t ,int );void xfs_iext_remove_indirect (xfs_ifork_t *,xfs_extnum_t ,int );void xfs_iext_realloc_direct (xfs_ifork_t *,int ); -void xfs_iext_realloc_indirect (xfs_ifork_t *,int ); -void xfs_iext_indirect_to_direct (xfs_ifork_t *);void xfs_iext_direct_to_inline (xfs_ifork_t *,xfs_extnum_t );void xfs_iext_inline_to_direct (xfs_ifork_t *,int );void xfs_iext_destroy (xfs_ifork_t *);
fs/xfs/xfs_itable.c +1 -1
@@ -39,7 +39,7 @@#include "xfs_error.h" #include "xfs_btree.h" -int +STATIC intxfs_internal_inum (xfs_mount_t *mp,xfs_ino_t ino)
fs/xfs/xfs_itable.h +0 -5
@@ -99,11 +99,6 @@ xfs_bulkstat_one(void *dibuff, int *stat); -int -xfs_internal_inum ( -xfs_mount_t *mp, -xfs_ino_t ino); - typedef int (*inumbers_fmt_pf)( void __user *ubuffer, /* buffer to write to */ const xfs_inogrp_t *buffer, /* buffer to read from */
fs/xfs/xfs_log_priv.h +0 -2
@@ -451,8 +451,6 @@ extern int xlog_find_tail(xlog_t *log,extern int xlog_recover (xlog_t *log);extern int xlog_recover_finish (xlog_t *log);extern void xlog_pack_data (xlog_t *log,xlog_in_core_t *iclog,int ); -extern void xlog_recover_process_iunlinks (xlog_t *log); -extern struct xfs_buf *xlog_get_bp (xlog_t *,int );extern void xlog_put_bp (struct xfs_buf *);
fs/xfs/xfs_log_recover.c +1 -1
@@ -3263,7 +3263,7 @@ xlog_recover_process_one_iunlink(* freeing of the inode and its removal from the list must be * atomic. */ -void +STATIC voidxlog_recover_process_iunlinks (xlog_t *log) {
fs/xfs/xfs_mount.c +1 -1
@@ -1568,7 +1568,7 @@ xfs_mod_sb(xfs_trans_t *tp, __int64_t fields)* * The m_sb_lock must be held when this routine is called. */ -int +STATIC int xfs_mod_incore_sb_unlocked( xfs_mount_t *mp, xfs_sb_field_t field,
fs/xfs/xfs_mount.h +0 -3
@@ -414,13 +414,10 @@ typedef struct xfs_mod_sb {extern int xfs_log_sbcount (xfs_mount_t *,uint );extern int xfs_mountfs (xfs_mount_t *mp); -extern void xfs_mountfs_check_barriers (xfs_mount_t *mp);extern void xfs_unmountfs (xfs_mount_t *);extern int xfs_unmountfs_writesb (xfs_mount_t *);extern int xfs_mod_incore_sb (xfs_mount_t *,xfs_sb_field_t ,int64_t ,int ); -extern int xfs_mod_incore_sb_unlocked (xfs_mount_t *,xfs_sb_field_t , -int64_t ,int );extern int xfs_mod_incore_sb_batch (xfs_mount_t *,xfs_mod_sb_t *,uint ,int );extern int xfs_mount_log_sb (xfs_mount_t *,__int64_t );
fs/xfs/xfs_mru_cache.c +0 -29
@@ -564,35 +564,6 @@ xfs_mru_cache_lookup( }/* -* To look up an element using its key, but leave its location in the internal -* lists alone, call xfs_mru_cache_peek(). If the element isn't found, this -* function returns NULL. -* -* See the comments above the declaration of the xfs_mru_cache_lookup() function -* for important locking information pertaining to this call. -*/ -void * -xfs_mru_cache_peek ( -xfs_mru_cache_t *mru, -unsigned long key) -{ -xfs_mru_cache_elem_t *elem; - -ASSERT (mru && mru->lists); -if (!mru || !mru->lists) -return NULL ; - -spin_lock (&mru->lock); - elem =radix_tree_lookup (&mru->store, key); -if (!elem) -spin_unlock (&mru->lock); -else -__release (mru_lock);/* help sparse not be stupid */ - -return elem ? elem->value :NULL ; -} - -/* * To release the internal data structure spinlock after having performed an * xfs_mru_cache_lookup() or an xfs_mru_cache_peek(), call xfs_mru_cache_done() * with the data store pointer.
fs/xfs/xfs_mru_cache.h +0 -1
@@ -49,7 +49,6 @@ int xfs_mru_cache_insert(struct xfs_mru_cache *mru, unsigned long key,void *xfs_mru_cache_remove (struct xfs_mru_cache *mru,unsigned long key);void xfs_mru_cache_delete (struct xfs_mru_cache *mru,unsigned long key);void *xfs_mru_cache_lookup (struct xfs_mru_cache *mru,unsigned long key); -void *xfs_mru_cache_peek (struct xfs_mru_cache *mru,unsigned long key);void xfs_mru_cache_done (struct xfs_mru_cache *mru);#endif /* __XFS_MRU_CACHE_H__ */
fs/xfs/xfs_rw.h +0 -6
@@ -78,10 +78,4 @@ extern int xfs_read_buf(struct xfs_mount *mp, xfs_buftarg_t *btp,extern void xfs_ioerror_alert (char *func,struct xfs_mount *mp,xfs_buf_t *bp,xfs_daddr_t blkno); -/* -* Prototypes for functions in xfs_vnodeops.c. -*/ -extern int xfs_free_eofblocks (struct xfs_mount *mp,struct xfs_inode *ip, -int flags); -#endif /* __XFS_RW_H__ */
fs/xfs/xfs_vnodeops.c +1 -1
@@ -716,7 +716,7 @@ xfs_fsync(* when the link count isn't zero and by xfs_dm_punch_hole() when * punching a hole to EOF. */ -int +STATIC int xfs_free_eofblocks( xfs_mount_t *mp, xfs_inode_t *ip,
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 27 lines · Eric Sandeen
Quoted 26 lines · Felix Blyakher
Quoted 4 lines · Eric Sandeen
Quoted 2 lines · Christoph Hellwig
On Tue, May 26, 2009 at 02:05:09PM -0500, Eric Sandeen wrote:
Quoted 9 lines
Quoted 7 lines
Quoted 4 lines
A lot more functions could be made static, but they need forward declarations; this does some easy ones, and also found a few unused functions in the process.
Looks good to me.
Felix, do you plan to merge this one?
Eric, this patch doesn't apply cleanly now:
Applying xfs: add more statics & drop some unused functions
error: patch failed:fs/xfs/linux-2.6/xfs_sync.c:640
error:fs/xfs/linux-2.6/xfs_sync.c: patch does not apply
error: patch failed:fs/xfs/linux-2.6/xfs_sync.h:51
error:fs/xfs/linux-2.6/xfs_sync.h: patch does not apply Patch failed at 0002.
Quoted 7 lines
Quoted 6 lines
Can you rebase and repost it?
Thanks,
FelixThis one applies to linus' tree ok....
It does. Applied. Thanks.
Felix
Quoted 511 lines
(quoted diff) +0
-1-Ericfs/xfs/linux-2.6/xfs_super.c +1
-1@@ -687,7 +687,7 @@ xfs_barrier_test(return error; } -void +STATIC voidxfs_mountfs_check_barriers (xfs_mount_t *mp) {int error;fs/xfs/linux-2.6/xfs_sync.c +0
-15@@ -740,21 +740,6 @@ __xfs_inode_clear_reclaim_tag( XFS_INO_TO_AGINO(mp, ip->i_ino), XFS_ICI_RECLAIM_TAG); } -void -xfs_inode_clear_reclaim_tag ( -xfs_inode_t *ip) -{ -xfs_mount_t *mp = ip->i_mount; -xfs_perag_t *pag =xfs_get_perag (mp, ip->i_ino); - -read_lock (&pag->pag_ici_lock); -spin_lock (&ip->i_flags_lock); -__xfs_inode_clear_reclaim_tag (mp, pag, ip); -spin_unlock (&ip->i_flags_lock); -read_unlock (&pag->pag_ici_lock); -xfs_put_perag (mp, pag); -} -STATIC int
xfs_reclaim_inode_now(
structxfs_inode*ip,fs/xfs/linux-2.6/xfs_sync.h +0
-1@@ -48,7 +48,6 @@ int xfs_reclaim_inode(struct xfs_inode *ip, int locked, int sync_mode);int xfs_reclaim_inodes (struct xfs_mount *mp,int mode);void xfs_inode_set_reclaim_tag (struct xfs_inode *ip); -void xfs_inode_clear_reclaim_tag (struct xfs_inode *ip);void __xfs_inode_clear_reclaim_tag (struct xfs_mount *mp,struct xfs_perag *pag,struct xfs_inode *ip);fs/xfs/xfs_ag.h +0
-3@@ -91,9 +91,6 @@ typedef struct xfs_agf {#define XFS_AGF_BLOCK (mp) XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp))#define XFS_BUF_TO_AGF (bp) ((xfs_agf_t *)XFS_BUF_PTR(bp)) -extern int xfs_read_agf (struct xfs_mount *mp,struct xfs_trans *tp, -xfs_agnumber_t agno,int flags,struct xfs_buf **bpp); -/* * Size of the unlinked inode hash table in the agi. */ fs/xfs/xfs_alloc.c +1
-1@@ -2248,7 +2248,7 @@ xfs_alloc_put_freelist(/* * Read in the allocation group header (free/alloc section). */ -int /* error */ +STATIC int/* error */ xfs_read_agf(
structxfs_mount*mp, /* mount point structure */
structxfs_trans*tp, /* transaction pointer */fs/xfs/xfs_bmap.c +1
-1@@ -3713,7 +3713,7 @@ done:* entry (null if none). Else, *lastxp will be set to the index * of the found entry; *gotp will contain the entry. */ -xfs_bmbt_rec_host_t * /* pointer to found extent entry */ +STATIC xfs_bmbt_rec_host_t * /* pointer to found extent entry */xfs_bmap_search_multi_extents(
xfs_ifork_t *ifp, /* inode fork pointer */ xfs_fileoff_t bno, /* block number searched for */fs/xfs/xfs_bmap.h +0
-11@@ -392,17 +392,6 @@ xfs_bmap_count_blocks(int whichfork, int *count); -/* -* Search the extent records for the entry containing block bno. -* If bno lies in a hole, point to the next entry. If bno lies -* past eof, *eofp will be set, and *prevp will contain the last -* entry (null if none). Else, *lastxp will be set to the index -* of the found entry; *gotp will contain the entry. -*/ -xfs_bmbt_rec_host_t * -xfs_bmap_search_multi_extents (struct xfs_ifork *,xfs_fileoff_t , int *, -xfs_extnum_t *,xfs_bmbt_irec_t *,xfs_bmbt_irec_t *); -#endif /* __KERNEL__ */ #endif /*
__XFS_BMAP_H__*/fs/xfs/xfs_bmap_btree.c +10
-10@@ -202,16 +202,6 @@ xfs_bmbt_get_state( ext_flag); } -/* Endian flipping versions of the bmbt extraction functions */ -void -xfs_bmbt_disk_get_all ( -xfs_bmbt_rec_t *r, -xfs_bmbt_irec_t *s) -{ -__xfs_bmbt_get_all (get_unaligned_be64 (&r->l0), -get_unaligned_be64 (&r->l1), s); -} -/* * Extract the blockcount field from an on disk bmap extent record. */ @@ -816,6 +806,16 @@ xfs_bmbt_trace_key( *l1 =0 ; } +/* Endian flipping versions of the bmbt extraction functions */ +STATIC void +xfs_bmbt_disk_get_all ( +xfs_bmbt_rec_t *r, +xfs_bmbt_irec_t *s) +{ +__xfs_bmbt_get_all (get_unaligned_be64 (&r->l0), +get_unaligned_be64 (&r->l1), s); +} +STATIC void
xfs_bmbt_trace_record(
structxfs_btree_cur*cur,fs/xfs/xfs_bmap_btree.h +0
-1@@ -220,7 +220,6 @@ extern xfs_fsblock_txfs_bmbt_get_startblock (xfs_bmbt_rec_host_t *r);extern xfs_fileoff_t xfs_bmbt_get_startoff (xfs_bmbt_rec_host_t *r);extern xfs_exntst_t xfs_bmbt_get_state (xfs_bmbt_rec_host_t *r); -extern void xfs_bmbt_disk_get_all (xfs_bmbt_rec_t *r, xfs_bmbt_irec_t *s);extern xfs_filblks_t xfs_bmbt_disk_get_blockcount (xfs_bmbt_rec_t *r);extern
xfs_fileoff_txfs_bmbt_disk_get_startoff(xfs_bmbt_rec_t *r);fs/xfs/xfs_btree.c +1
-41@@ -646,46 +646,6 @@ xfs_btree_read_bufl( }/* -* Get a buffer for the block, return it read in. -* Short-form addressing. -*/ -int /* error */ -xfs_btree_read_bufs ( -xfs_mount_t *mp,/* file system mount point */ -xfs_trans_t *tp,/* transaction pointer */ -xfs_agnumber_t agno,/* allocation group number */ -xfs_agblock_t agbno,/* allocation group block number */ -uint lock,/* lock flags for read_buf */ -xfs_buf_t **bpp,/* buffer for agno/agbno */ -int refval)/* ref count value for buffer */ -{ -xfs_buf_t *bp;/* return value */ -xfs_daddr_t d;/* real disk block address */ -int error; - -ASSERT (agno !=NULLAGNUMBER ); -ASSERT (agbno !=NULLAGBLOCK ); - d =XFS_AGB_TO_DADDR (mp, agno, agbno); -if ((error =xfs_trans_read_buf (mp, tp, mp->m_ddev_targp, d, - mp->m_bsize, lock, &bp))) { -return error; - } -ASSERT (!bp || !XFS_BUF_GETERROR (bp)); -if (bp !=NULL ) { -switch (refval) { -case XFS_ALLOC_BTREE_REF : -XFS_BUF_SET_VTYPE_REF (bp,B_FS_MAP , refval); -break ; -case XFS_INO_BTREE_REF : -XFS_BUF_SET_VTYPE_REF (bp,B_FS_INOMAP , refval); -break ; - } - } - *bpp = bp; -return 0 ; -} - -/* * Read-ahead the block, don't wait for it, don't return a buffer. * Long-form addressing. */ @@ -2951,7 +2911,7 @@ error0:* inode we have to copy the single block it was pointing to into the * inode. */ -int +STATIC intxfs_btree_kill_iroot(
structxfs_btree_cur*cur)
{fs/xfs/xfs_btree.h +0
-15@@ -379,20 +379,6 @@ xfs_btree_read_bufl( int refval);/* ref count value for buffer *//* -* Get a buffer for the block, return it read in. -* Short-form addressing. -*/ -int /* error */ -xfs_btree_read_bufs ( -struct xfs_mount *mp,/* file system mount point */ -struct xfs_trans *tp,/* transaction pointer */ -xfs_agnumber_t agno,/* allocation group number */ -xfs_agblock_t agbno,/* allocation group block number */ -uint lock,/* lock flags for read_buf */ -struct xfs_buf **bpp,/* buffer for agno/agbno */ -int refval);/* ref count value for buffer */ - -/* * Read-ahead the block, don't wait for it, don't return a buffer. * Long-form addressing. */ @@ -432,7 +418,6 @@ int xfs_btree_decrement(struct xfs_btree_cur *, int, int *);int xfs_btree_lookup (struct xfs_btree_cur *,xfs_lookup_t ,int *);int xfs_btree_update (struct xfs_btree_cur *,union xfs_btree_rec *);int xfs_btree_new_iroot (struct xfs_btree_cur *,int *,int *); -int xfs_btree_kill_iroot (struct xfs_btree_cur *);int xfs_btree_insert (struct xfs_btree_cur *,int *);int xfs_btree_delete (struct xfs_btree_cur *,int *);int
xfs_btree_get_rec(struct xfs_btree_cur *, union xfs_btree_rec **, int *);fs/xfs/xfs_inode.c +1
-1@@ -641,7 +641,7 @@ xfs_iformat_btree(return 0 ; } -void +STATIC voidxfs_dinode_from_disk(
xfs_icdinode_t *to, xfs_dinode_t *from)fs/xfs/xfs_inode.c +1
-1@@ -1237,7 +1237,7 @@ xfs_isize_check(* In that case the pages will still be in memory, but the inode size * will never have been updated. */ -xfs_fsize_t +STATIC xfs_fsize_txfs_file_last_byte(
xfs_inode_t *ip){
fs/xfs/xfs_inode.c +1
-1@@ -3827,7 +3827,7 @@ xfs_iext_inline_to_direct(/* * Resize an extent indirection array to new_size bytes. */ -void +STATIC voidxfs_iext_realloc_indirect(
xfs_ifork_t *ifp, /* inode fork pointer */ int new_size) /* new indirection array size */fs/xfs/xfs_inode.c +0
-0@@ -3852,7 +3852,7 @@ xfs_iext_realloc_indirect(/* * Switch from indirection array to linear (direct) extent allocations.
*/fs/xfs/xfs_inode.c +1
-1-void +STATIC voidxfs_iext_indirect_to_direct(
xfs_ifork_t *ifp) /* inode fork pointer */{
fs/xfs/xfs_inode.h +0
-3@@ -521,7 +521,6 @@ void xfs_ipin(xfs_inode_t *);void xfs_iunpin (xfs_inode_t *);int xfs_iflush (xfs_inode_t *,uint );void xfs_ichgtime (xfs_inode_t *,int ); -xfs_fsize_t xfs_file_last_byte (xfs_inode_t *);void xfs_lock_inodes (xfs_inode_t **,int ,uint );void xfs_lock_two_inodes (xfs_inode_t *,xfs_inode_t *,uint );@@ -589,8 +588,6 @@ int xfs_itobp(struct xfs_mount *, struct xfs_trans *, struct xfs_buf **, uint);int xfs_iread (struct xfs_mount *,struct xfs_trans *,struct xfs_inode *,xfs_daddr_t ,uint ); -void xfs_dinode_from_disk (struct xfs_icdinode *, -struct xfs_dinode *);void xfs_dinode_to_disk (struct xfs_dinode *,struct xfs_icdinode *);void
xfs_idestroy_fork(struct xfs_inode *, int);fs/xfs/xfs_inode.h +0
-2@@ -609,8 +606,6 @@ void xfs_iext_remove_inline(xfs_ifork_t *, xfs_extnum_t, int);void xfs_iext_remove_direct (xfs_ifork_t *,xfs_extnum_t ,int );void xfs_iext_remove_indirect (xfs_ifork_t *,xfs_extnum_t ,int );void xfs_iext_realloc_direct (xfs_ifork_t *,int ); -void xfs_iext_realloc_indirect (xfs_ifork_t *,int ); -void xfs_iext_indirect_to_direct (xfs_ifork_t *);void xfs_iext_direct_to_inline (xfs_ifork_t *,xfs_extnum_t );void xfs_iext_inline_to_direct (xfs_ifork_t *,int );void
xfs_iext_destroy(xfs_ifork_t *);fs/xfs/xfs_itable.c +1
-1@@ -39,7 +39,7 @@#include "xfs_error.h" #include "xfs_btree.h" -int +STATIC intxfs_internal_inum(
xfs_mount_t *mp, xfs_ino_t ino)fs/xfs/xfs_itable.h +0
-5@@ -99,11 +99,6 @@ xfs_bulkstat_one(void *dibuff, int *stat); -int -xfs_internal_inum ( -xfs_mount_t *mp, -xfs_ino_t ino); -typedef int (*inumbers_fmt_pf)(
void__user*ubuffer, /* buffer to write to */
constxfs_inogrp_t*buffer, /* buffer to read from */fs/xfs/xfs_log_priv.h +0
-2@@ -451,8 +451,6 @@ extern int xlog_find_tail(xlog_t *log,extern int xlog_recover (xlog_t *log);extern int xlog_recover_finish (xlog_t *log);extern void xlog_pack_data (xlog_t *log,xlog_in_core_t *iclog,int ); -extern void xlog_recover_process_iunlinks (xlog_t *log); -extern struct xfs_buf *xlog_get_bp (xlog_t *,int );extern void xlog_put_bp (struct xfs_buf *);fs/xfs/xfs_log_recover.c +1
-1@@ -3263,7 +3263,7 @@ xlog_recover_process_one_iunlink(* freeing of the inode and its removal from the list must be * atomic. */ -void +STATIC voidxlog_recover_process_iunlinks(
xlog_t *log){
fs/xfs/xfs_mount.c +1
-1@@ -1568,7 +1568,7 @@ xfs_mod_sb(xfs_trans_t *tp, __int64_t fields)* * The m_sb_lock must be held when this routine is called. */ -int +STATIC intxfs_mod_incore_sb_unlocked(
xfs_mount_t *mp, xfs_sb_field_t field,fs/xfs/xfs_mount.h +0
-3@@ -414,13 +414,10 @@ typedef struct xfs_mod_sb {extern int xfs_log_sbcount (xfs_mount_t *,uint );extern int xfs_mountfs (xfs_mount_t *mp); -extern void xfs_mountfs_check_barriers (xfs_mount_t *mp);extern void xfs_unmountfs (xfs_mount_t *);extern int xfs_unmountfs_writesb (xfs_mount_t *);extern int xfs_mod_incore_sb (xfs_mount_t *,xfs_sb_field_t ,int64_t ,int ); -extern int xfs_mod_incore_sb_unlocked (xfs_mount_t *,xfs_sb_field_t , -int64_t ,int );extern int xfs_mod_incore_sb_batch (xfs_mount_t *,xfs_mod_sb_t *,uint ,int );extern int xfs_mount_log_sb (xfs_mount_t *,__int64_t );fs/xfs/xfs_mru_cache.c +0
-1@@ -564,35 +564,6 @@ xfs_mru_cache_lookup( }/* -* To look up an element using its key, but leave its location in the internal
- * lists alone, callxfs_mru_cache_peek(). If the element isn't found, this
- * function returns NULL.
- *
- * See the comments above the declaration of thexfs_mru_cache_lookup()function
- * for important locking information pertaining to this call.
- */fs/xfs/xfs_mru_cache.c +0
-22-void * -xfs_mru_cache_peek ( -xfs_mru_cache_t *mru, -unsigned long key) -{ -xfs_mru_cache_elem_t *elem; - -ASSERT (mru && mru->lists); -if (!mru || !mru->lists) -return NULL ; - -spin_lock (&mru->lock); - elem =radix_tree_lookup (&mru->store, key); -if (!elem) -spin_unlock (&mru->lock); -else -__release (mru_lock);/* help sparse not be stupid */ - -return elem ? elem->value :NULL ; -} - -/* * To release the internal data structure spinlock after having performed an
*xfs_mru_cache_lookup()or anxfs_mru_cache_peek(), callxfs_mru_cache_done()
* with the data store pointer.fs/xfs/xfs_mru_cache.h +0
-1@@ -49,7 +49,6 @@ int xfs_mru_cache_insert(struct xfs_mru_cache *mru, unsigned long key, void * xfs_mru_cache_remove(struct xfs_mru_cache *mru, unsigned long key);void xfs_mru_cache_delete (struct xfs_mru_cache *mru,unsigned long key);void *xfs_mru_cache_lookup (struct xfs_mru_cache *mru,unsigned long key); -void *xfs_mru_cache_peek (struct xfs_mru_cache *mru,unsigned long key);void xfs_mru_cache_done (struct xfs_mru_cache *mru);#endif /*
__XFS_MRU_CACHE_H__*/fs/xfs/xfs_rw.h +0
-4@@ -78,10 +78,4 @@ extern int xfs_read_buf(struct xfs_mount *mp,xfs_buftarg_t *btp, extern void xfs_ioerror_alert(char *func, struct xfs_mount *mp,xfs_buf_t *bp,xfs_daddr_t blkno); -/* -* Prototypes for functions in xfs_vnodeops.c. -*/ -extern int xfs_free_eofblocks(struct xfs_mount *mp, struct
xfs_inode*ip,fs/xfs/xfs_rw.h +0
-2- int flags); -#endif /*
__XFS_RW_H__*/fs/xfs/xfs_vnodeops.c +1
-1@@ -716,7 +716,7 @@ xfs_fsync(* when the link count isn't zero and by xfs_dm_punch_hole() when * punching a hole to EOF. */ -int +STATIC intxfs_free_eofblocks(
Quoted 4 lines
xfs_mount_t *mp, xfs_inode_t *ip,
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs