Skip to contentSkip to conversation

(linux-next) Cleanups in drivers/staging/comedi

PATCH In review Gerard Lledo 4 participants 6 messages May 27, 2009 – Jun 2, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 (linux-next) Cleanups in drivers/staging/comedi

These are 2 small patches that fix one warning and a build faulure in the comedi subsystem. Both of them were build-tested.

#1 lore raw

PATCH 1/1 Staging: comedi: Add missing includes

Fixes build errors due to missing includes

---
 drivers/staging/comedi/comedidev.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/staging/comedi/comedidev.h +3 -0
index 7a1ccde..1cdf5aa 100644
@@ -38,6 +38,9 @@
 #include <linux/dma-mapping.h>
 #include <linux/uaccess.h>
 #include <linux/io.h>
+#include <linux/delay.h>
+#include <linux/jiffies.h>
+#include <linux/timer.h>
 
 #include "comedi.h"
 
Signature · 1 line
1.5.6.5
#2 lore raw

Re: [PATCH] Staging: comedi: Add missing includes

Quoted 3 lines · Gerard Lledo

Fixes build errors due to missing includes

This should now be fixed up already.

thanks,

greg k-h

#3 lore raw

PATCH 1/1 Staging: comedi: Fix build warning (type mismatch)

In reply to Gerard Lledo

spin_lock_irqsave expects flags to be unsigned long, not unsigned int.

---
 drivers/staging/comedi/drivers/cb_pcidas.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/comedi/drivers/cb_pcidas.c +1 -1
index 28212ad..702de15 100644
@@ -1593,7 +1593,7 @@ static void handle_ao_interrupt(struct comedi_device *dev, unsigned int status)
 	struct comedi_cmd *cmd = &async->cmd;
 	unsigned int half_fifo = thisboard->fifo_size / 2;
 	unsigned int num_points;
-	unsigned int flags;
+	unsigned long flags;
 
 	async->events = 0;
 
Signature · 1 line
1.5.6.5
#4 lore raw
In reply to Gerard Lledo
Quoted 3 lines · Gerard Lledo

These are 2 small patches that fix one warning and a build faulure in the comedi subsystem. Both of them were build-tested.

Hi,

Don't forget to Cc linux-kernel and also Greg who is the staging subsystem maintainer.

(adding the missing Cc)

Thanks.

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw
Quoted 6 lines · Frederic Weisbecker
Quoted 3 lines · Gerard Lledo

These are 2 small patches that fix one warning and a build faulure in the comedi subsystem. Both of them were build-tested.

Quoted 6 lines

Hi,

Don't forget to Cc linux-kernel and also Greg who is the staging subsystem maintainer.

(adding the missing Cc)

My scripts caught them, they are now in my ever-growing "to-apply" queue.

thanks,

greg k-h