ptrace: don't take tasklist to get/set ->last_siginfo
Oleg Nesterov
maintainerPATCH 1/1 ptrace: don't take tasklist to get/set ->last_siginfo
Change ptrace_getsiginfo/ptrace_setsiginfo to use lock_task_sighand() without tasklist_lock. Perhaps it makes sense to make a singler helper with "bool rw" argument.
Signed-off-by Oleg Nesterov <[email protected]>
kernel/ptrace.c renamed from kernel/ptrace.c~SIGINFO +6 -10
@@ -463,37 +463,33 @@ static int ptrace_setoptionsstatic int ptrace_getsiginfo (struct task_struct *child,siginfo_t *info) { +unsigned long flags;int error = -ESRCH ; -read_lock (&tasklist_lock); -if (likely (child->sighand !=NULL )) { +if (lock_task_sighand (child, &flags)) { error = -EINVAL ; -spin_lock_irq (&child->sighand->siglock);if (likely (child->last_siginfo !=NULL )) { *info = *child->last_siginfo; error =0 ; } -spin_unlock_irq (&child->sighand->siglock); +unlock_task_sighand (child, &flags); } -read_unlock (&tasklist_lock);return error; }static int ptrace_setsiginfo (struct task_struct *child,const siginfo_t *info) { +unsigned long flags;int error = -ESRCH ; -read_lock (&tasklist_lock); -if (likely (child->sighand !=NULL )) { +if (lock_task_sighand (child, &flags)) { error = -EINVAL ; -spin_lock_irq (&child->sighand->siglock);if (likely (child->last_siginfo !=NULL )) { *child->last_siginfo = *info; error =0 ; } -spin_unlock_irq (&child->sighand->siglock); +unlock_task_sighand (child, &flags); } -read_unlock (&tasklist_lock);return error; }
Acked-by Roland McGrath <[email protected]>
Quoted 3 lines
Change ptrace_getsiginfo/ptrace_setsiginfo to use
lock_task_sighand()withouttasklist_lock. Perhaps it makes sense to make a singler helper with "bool rw" argument.
Let's not bother now since we will change this more later anyway.
Thanks,
Roland