Skip to contentSkip to conversation

: llc: Kill outdated and incorrect comment.

PATCH In review David Miller 1 participant 1 message May 29, 2009

Subsystems (3)
lore
Share & tools
lore

David Miller

author maintainer
#0 lore raw

PATCH 10/10 : llc: Kill outdated and incorrect comment.

This comment suggested storing two pieces of state in the LLC skb control block, and in fact we do. Someone did the implementation but never killed this todo comment :-)

---
 net/llc/llc_conn.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
net/llc/llc_conn.c +0 -4
index 3477624..c6bab39 100644
@@ -79,10 +79,6 @@ int llc_conn_state_process(struct sock *sk, struct sk_buff *skb)
 
 	if (unlikely(!ev->ind_prim && !ev->cfm_prim)) {
 		/* indicate or confirm not required */
-		/* XXX this is not very pretty, perhaps we should store
-		 * XXX indicate/confirm-needed state in the llc_conn_state_ev
-		 * XXX control block of the SKB instead? -DaveM
-		 */
 		if (!skb->next)
 			goto out_kfree_skb;
 		goto out_skb_put;
Signature · 1 line
1.6.3