Skip to contentSkip to conversation

Reverting ltp-pan.c to pan.c revision1.32

LTP Cyril Hrubis 1 participant 3 messages Jun 1, 2009 – Jun 6, 2009 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Hi,

Quoted 5 lines

I had to revert this version of ltp-pan.c to an earlier pan.c revision 1.32 as the present ltp-pan.c was creating problems in lot of my architecture(s). It simply hangs and does not move forward. I had to do this immediate revert for the release. Please rebase your fixes (if any) against the present checked in code.

That's too bad, all I was changing was conding style but in the pan source who knows :(. Why not just to rename pan.c to ltp-pan.c as I was trying to do before the patch checker quarrels about coding style. I fully agree that cleaning code is must but only option I see here is rewrite pan from scratch and that is just too much work.

(forgotten to CC ltp, so sending once more)

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#1 lore raw

Hi,
Okay found the problem, I've remove static keyword in function wait_handler and that makes lastsent variable local and allways defined as 0. Please add static before int lastsent = 0; to function wait_handler() in patched ltp-pan.c.

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Hi,

Quoted 2 lines

Nope. This does not solve the problem either. There seems to some other issue here.

I try to look on the code again, but it's low priority now.

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list