Skip to contentSkip to conversation

drm: intel: add ignore lvds quirk info for AOpen Mini PC

PATCH In review Jarod Wilson 3 participants 5 messages May 27, 2009 – Jun 1, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: intel: add ignore lvds quirk info for AOpen Mini PC

Fix a FIXME in the intel LVDS bring-up code, adding the appropriate blacklist entry for the AOpen Mini PC, courtesy of a dmidecode dump from Florian Demmer.

CC Florian Demmer <[email protected]>
---
 drivers/gpu/drm/i915/intel_lvds.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_lvds.c +8 -2
index 439a865..7ac00c3 100644
@@ -424,8 +424,14 @@ static const struct dmi_system_id __initdata intel_no_lvds[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
 		},
 	},
-
-	/* FIXME: add a check for the Aopen Mini PC */
+	{
+		.callback = intel_no_lvds_dmi_callback,
+		.ident = "AOpen Mini PC",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
+		},
+	},
 
 	{ }	/* terminating entry */
 };
Signature · 2 lines
Jarod Wilson
[email protected]
Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines · On Wed, 27 May 2009 17:20:39 -0400 Jarod Wilson <[email protected]> wrote:

Fix a FIXME in the intel LVDS bring-up code, adding the appropriate blacklist entry for the AOpen Mini PC, courtesy of a dmidecode dump from Florian Demmer.

CC Florian Demmer <[email protected]>
---
 drivers/gpu/drm/i915/intel_lvds.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/intel_lvds.c index 439a865..7ac00c3 100644

drivers/gpu/drm/i915/intel_lvds.c +1 -2
@@ -424,8 +424,14 @@ static const struct dmi_system_id __initdata
 intel_no_lvds[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
 		},
 	},
-
-	/* FIXME: add a check for the Aopen Mini PC */
+	{

drivers/gpu/drm/i915/intel_lvds.c static const struct dmi_system_id __initdata · line 437

Quoted 10 lines
drivers/gpu/drm/i915/intel_lvds.c +7 -0
+		.callback = intel_no_lvds_dmi_callback,
+		.ident = "AOpen Mini PC",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
+		},
+	},
 
 	{ }	/* terminating entry */
 };

Looks fine to me, Eric? Patches to the i915 driver should generally go to [email protected] so we don't miss them. Thanks.

#2 lore raw
Quoted 2 lines · On Monday 01 June 2009 07:01:26 Jesse Barnes wrote:

Patches to the i915 driver should generally go
to [email protected] so we don't miss them. Thanks.

Ah, sorry, didn't know that. Might I suggest adding a note to that effect in MAINTAINERS? Reasonably sure that's where I looked to try to figure out where to send a prior i915 patch and I don't see a ref to that list in there now.

Signature · 2 lines
Jarod Wilson
[email protected]
#3 lore raw
Quoted 3 lines · Jarod Wilson
Quoted 2 lines · On Monday 01 June 2009 07:01:26 Jesse Barnes wrote:

Patches to the i915 driver should generally go
to [email protected] so we don't miss them. Thanks.

Does that apply to the i810 and i830 as well?

#4 lore raw
Quoted 6 lines · On Mon, 01 Jun 2009 09:11:41 -0700 Joe Perches <[email protected]> wrote:
Quoted 3 lines · Jarod Wilson
Quoted 2 lines · On Monday 01 June 2009 07:01:26 Jesse Barnes wrote:

Patches to the i915 driver should generally go
to [email protected] so we don't miss them. Thanks.

Does that apply to the i810 and i830 as well?

Those drivers are fairly abandoned afaik, so I'm not sure where patches to them should go. In fact I think i830 is deprecated in favor of i915... so it should probably just be killed.

Jesse