Skip to contentSkip to conversation

Documentation: Fix inconsistent description of futex list_op_pending

PATCH New Matt Helsley 1 participant 1 message Jun 1, 2009 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: Fix inconsistent description of futex list_op_pending

Documentation: Fix inconsistent description of futex list_op_pending

Strictly speaking list_op_pending points to the 'lock entry', not the 'lock word' (which is actually at 'offset' from 'lock entry'). We can infer this based on reading the code in kernel/futex.c:

struct robust_list __user *entry, *next_entry, *pending;
...
if (fetch_robust_entry(&pending, &head->list_op_pending, &pip))
return;
...
if (pending)
handle_futex_death((void __user *)pending + futex_offset,
curr, pip);

Which is also consistent with the rest of the docs on robust futex lists.

Documentation/robust-futex-ABI.txt +2 -2
index 535f69f..fd1cd8a 100644
@@ -135,7 +135,7 @@ manipulating this list), the user code must observe the following
 protocol on 'lock entry' insertion and removal:
 
 On insertion:
- 1) set the 'list_op_pending' word to the address of the 'lock word'
+ 1) set the 'list_op_pending' word to the address of the 'lock entry'
     to be inserted,
  2) acquire the futex lock,
  3) add the lock entry, with its thread id (TID) in the bottom 29 bits
@@ -143,7 +143,7 @@ On insertion:
  4) clear the 'list_op_pending' word.
 
 On removal:
- 1) set the 'list_op_pending' word to the address of the 'lock word'
+ 1) set the 'list_op_pending' word to the address of the 'lock entry'
     to be removed,
  2) remove the lock entry for this lock from the 'head' list,
  2) release the futex lock, and