ide: remove superfluous SELECT_MASK() call from ide_driveid_update()
PATCH 1/3 ide: remove superfluous SELECT_MASK() call from ide_driveid_update()
We always call SELECT_MASK(drive, 0) after ide_dev_read_id() call so there is no need to do it again in the error path.
Moreover with the combination of HPT36x controller and the drive on the quirk_drives[] list this can result in superfluous enable_irq() call which in turn will trigger WARN() in __enable_irq().
---
Sergei, after re-audit of my recent changes: these three patches should go before "hpt366: sync quirk_drives[] list with pdc202xx_{new,old}.c" one.
drivers/ide/ide-iops.c | 1 - 1 file changed, 1 deletion(-)
drivers/ide/ide-iops.c +0 -1
@@ -311,7 +311,6 @@ int ide_driveid_update(ide_drive_t *drivreturn 1 ; out_err: -SELECT_MASK (drive,0 );if (rc ==2 )printk (KERN_ERR "%s: %s: bad status\n" , drive->name, __func__);kfree (id);
Hello.
Quoted 9 lines · Bartlomiej Zolnierkiewicz
We always call
SELECT_MASK(drive, 0)afteride_dev_read_id()call so there is no need to do it again in the error path.Moreover with the combination of HPT36x controller and the drive on the quirk_drives[] list this can result in superfluous
enable_irq()call which in turn will triggerWARN()in__enable_irq().Cc Sergei Shtylyov <[email protected]>Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
MBR, Sergei