Skip to contentSkip to conversation

ide: remove superfluous SELECT_MASK() call from ide_driveid_update()

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Jun 1, 2009 – Jun 2, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ide: remove superfluous SELECT_MASK() call from ide_driveid_update()

We always call SELECT_MASK(drive, 0) after ide_dev_read_id() call so there is no need to do it again in the error path.

Moreover with the combination of HPT36x controller and the drive on the quirk_drives[] list this can result in superfluous enable_irq() call which in turn will trigger WARN() in __enable_irq().

---
Sergei, after re-audit of my recent changes: these three patches should go before "hpt366: sync quirk_drives[] list with pdc202xx_{new,old}.c" one.

 drivers/ide/ide-iops.c |    1 -
 1 file changed, 1 deletion(-)
drivers/ide/ide-iops.c +0 -1
Index: b/drivers/ide/ide-iops.c
===================================================================
@@ -311,7 +311,6 @@ int ide_driveid_update(ide_drive_t *driv
 
 	return 1;
 out_err:
-	SELECT_MASK(drive, 0);
 	if (rc == 2)
 		printk(KERN_ERR "%s: %s: bad status\n", drive->name, __func__);
 	kfree(id);
Acked-by on v1 1/3
#1 lore raw

Hello.

Quoted 9 lines · Bartlomiej Zolnierkiewicz

We always call SELECT_MASK(drive, 0) after ide_dev_read_id() call so there is no need to do it again in the error path.

Moreover with the combination of HPT36x controller and the drive on the quirk_drives[] list this can result in superfluous enable_irq() call which in turn will trigger WARN() in __enable_irq().

MBR, Sergei