fs: remove incorrect I_NEW warnings
PATCH 1/1 fs: remove incorrect I_NEW warnings
Some filesystems can call in to sync an inode that is still in the I_NEW state (eg. ext family, when mounted with -osync). This is OK because the filesystem has sole access to the new inode, so it can modify i_state without races (because no other thread should be modifying it, by definition of I_NEW). Ie. a false positive, so remove the warnings.
The races are described here 7ef0d7377cb287e08f3ae94cebc919448e1f5dff, which is also where the warnings were introduced.
Reported-by Stephen Hemminger <[email protected]>
Signed-off-by Nick Piggin <[email protected]>
--- fs/fs-writeback.c | 2 -- 1 file changed, 2 deletions(-)
fs/fs-writeback.c +0 -2
@@ -289,7 +289,6 @@ __sync_single_inode(struct inode *inode,int ret;BUG_ON (inode->i_state &I_SYNC ); -WARN_ON (inode->i_state &I_NEW );/* Set I_SYNC, reset I_DIRTY */ dirty = inode->i_state &I_DIRTY ;
@@ -314,7 +313,6 @@ __sync_single_inode(struct inode *inode, }spin_lock (&inode_lock); -WARN_ON (inode->i_state &I_NEW ); inode->i_state &= ~I_SYNC ;if (!(inode->i_state &I_FREEING )) { if (!(inode->i_state & I_DIRTY) &&