Skip to contentSkip to conversation

config.mk: remove un-needed REMOTE_BUILD check

PATCH New Jean-Christophe PLAGNIOL-VILLARD 3 participants 5 messages May 22, 2009 – Jun 4, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config.mk: remove un-needed REMOTE_BUILD check

as $(obj) is empty when in tree build

%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<

and

$(obj)%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<

are the same

---
 config.mk |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)
config.mk +0 -12
index b1254e9..8d47a8e 100644
@@ -206,23 +206,11 @@ export	TEXT_BASE PLATFORM_CPPFLAGS PLATFORM_RELFLAGS CPPFLAGS CFLAGS AFLAGS
 
 #########################################################################
 
-ifndef REMOTE_BUILD
-
-%.s:	%.S
-	$(CPP) $(AFLAGS) -o $@ $<
-%.o:	%.S
-	$(CC) $(AFLAGS) -c -o $@ $<
-%.o:	%.c
-	$(CC) $(CFLAGS) -c -o $@ $<
-
-else
-
 $(obj)%.s:	%.S
 	$(CPP) $(AFLAGS) -o $@ $<
 $(obj)%.o:	%.S
 	$(CC) $(AFLAGS) -c -o $@ $<
 $(obj)%.o:	%.c
 	$(CC) $(CFLAGS) -c -o $@ $<
-endif
 
 #########################################################################
Signature · 1 line
1.6.2.4
#1 lore raw

PATCH 1/1 config.mk: remove un-needed REMOTE_BUILD check

Quoted 11 lines · On Friday 22 May 2009 13:28:52 Jean-Christophe PLAGNIOL-VILLARD wrote:

as $(obj) is empty when in tree build

%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<

and

$(obj)%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<

are the same

i wondered about that ... assuming in/out of tree still builds for you, this sounds good to me
-mike

#2 lore raw

PATCH 1/1 config.mk: remove un-needed REMOTE_BUILD check

Quoted 8 lines · Mike Frysinger
Quoted 7 lines · On Friday 22 May 2009 13:28:52 Jean-Christophe PLAGNIOL-VILLARD wrote:

as $(obj) is empty when in tree build

%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<

and

Quoted 7 lines
Quoted 4 lines

$(obj)%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<

are the same

i wondered about that ... assuming in/out of tree still builds for you, this sounds good to me

It's build correctly for me :)

Best Regards,
J.

#3 lore raw

PATCH 1/1 config.mk: remove un-needed REMOTE_BUILD check

Quoted 12 lines · On Sunday 24 May 2009 08:03:11 Jean-Christophe PLAGNIOL-VILLARD wrote:
Quoted 11 lines · Mike Frysinger
Quoted 10 lines · On Friday 22 May 2009 13:28:52 Jean-Christophe PLAGNIOL-VILLARD wrote:

as $(obj) is empty when in tree build

%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<

and

$(obj)%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

are the same

i wondered about that ... assuming in/out of tree still builds for you, this sounds good to me

It's build correctly for me :)

-mike

#4 lore raw

PATCH 1/1 config.mk: remove un-needed REMOTE_BUILD check

In reply to Jean-Christophe PLAGNIOL-VILLARD

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 8 lines · In message <[email protected]> you wrote:

as $(obj) is empty when in tree build

%.s: %.S

	$(CPP) $(AFLAGS) -o $@ $<

and

$(obj)%.s: %.S

Quoted 8 lines
	$(CPP) $(AFLAGS) -o $@ $<

are the same

---
 config.mk |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

Applied to next, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Human beings were created by water to transport it uphill.