Skip to contentSkip to conversation

Are patches for warnings in drivers/staging/* worth?

DISCUSSION Pranith Kumar 3 participants 3 messages Jun 5, 2009

lore
Share & tools
lore
#0 lore raw

Hi Greg,

I am looking at the various warnings which occur while compiling the staging drivers. Most of them are

* unused variables
* arg makes pointer from integer without cast
* un-initialized variable

What in these warnings should I send patches against? Are they worth the effort?

Thanks,
Pranith.

#1 lore raw
Quoted 10 lines · Pranith Kumar

Hi Greg,

I am looking at the various warnings which occur while compiling the staging drivers. Most of them are

* unused variables
* arg makes pointer from integer without cast
* un-initialized variable

What in these warnings should I send patches against?

I'm not Greg, but --- I'd say it's the same as with all other kernel code:

- If somebody else already actively works on the code in question, coordinate your efforts with him. (I suppose Greg as the maintainer will tell you if there is parallel effort and whether /he/ will merge your patches, or the other developer should pick them up, or whatever.)¹

- The goal of such patches should not just be about making the warnings go away, they should be about improving the code: Fix bugs, make it more readable, eventually optimize... I for one agree with the people who say that "fixing" the warnings without addressing the /underlying/ problems or even just the /surrounding/ problems is actually very counterproductive. Warnings are good!² They tell us that there probably is a problem. As long as the problem is there, the warning should stay there.

Quoted 1 line

Are they worth the effort?

Most certainly, because getting the drivers merge-ready is exactly the main purpose of carrying them in the staging area.

¹) For coordination between those who work on the staging drivers, there is also linuxdriverproject.org's devel mailinglist.

²) Well, warnings are /not/ good if they become overwhelming noise. But at least the staging drivers are out of the picture of normal kernel configurations, therefore they normally don't add noise.

Signature · 3 lines
Stefan Richter
-=====-==--= -==- --=-=
http://arcgraph.de/sr/
#2 lore raw
In reply to Pranith Kumar
Quoted 11 lines · Pranith Kumar

Hi Greg,

I am looking at the various warnings which occur while compiling the staging drivers. Most of them are

* unused variables
* arg makes pointer from integer without cast
* un-initialized variable

What in these warnings should I send patches against? Are they worth the effort?

Sure they are worth the effort in cleaning up this kind of things. Always generate patches for the staging tree against the latest linux-next release.

thanks,

greg k-h