Skip to contentSkip to conversation

proc: vmcore - use kzalloc in get_new_element

PATCH In review Cyrill Gorcunov 3 participants 3 messages Jun 6, 2009 – Jun 8, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 proc: vmcore - use kzalloc in get_new_element

Instead of kmalloc+memset better use straight kzalloc

---
 fs/proc/vmcore.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
fs/proc/vmcore.c +1 -6
Index: linux-2.6.git/fs/proc/vmcore.c
=====================================================================
@@ -166,12 +166,7 @@ static const struct file_operations proc
 
 static struct vmcore* __init get_new_element(void)
 {
-	struct vmcore *p;
-
-	p = kmalloc(sizeof(*p), GFP_KERNEL);
-	if (p)
-		memset(p, 0, sizeof(*p));
-	return p;
+	return kzalloc(sizeof(struct vmcore), GFP_KERNEL);
 }
 
 static u64 __init get_vmcore_size_elf64(char *elfptr)
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Cyrill Gorcunov

Instead of kmalloc+memset better use straight kzalloc

Looks good!

Quoted 27 lines

---
fs/proc/vmcore.c | 7 +------

1 file changed, 1 insertion(+), 6 deletions(-)

Index: linux-2.6.git/fs/proc/vmcore.c
=====================================================================

fs/proc/vmcore.c +1 -7
@@ -166,12 +166,7 @@ static const struct file_operations proc
 
 static struct vmcore* __init get_new_element(void)
 {
-	struct vmcore *p;
-
-	p = kmalloc(sizeof(*p), GFP_KERNEL);
-	if (p)
-		memset(p, 0, sizeof(*p));
-	return p;
+	return kzalloc(sizeof(struct vmcore), GFP_KERNEL);
 }
 
 static u64 __init get_vmcore_size_elf64(char *elfptr)
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Acked-by on v1 1/1
#2 lore raw
In reply to Cyrill Gorcunov
Quoted 15 lines · Cyrill Gorcunov

Instead of kmalloc+memset better use straight kzalloc

---
 fs/proc/vmcore.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Index: linux-2.6.git/fs/proc/vmcore.c
=====================================================================

fs/proc/vmcore.c +0 -0
@@ -166,12 +166,7 @@ static const struct file_operations proc
 
 static struct vmcore* __init get_new_element(void)
 {

fs/proc/vmcore.c static const struct file_operations proc · line 172

Quoted 10 lines
fs/proc/vmcore.c +1 -6
-	struct vmcore *p;
-
-	p = kmalloc(sizeof(*p), GFP_KERNEL);
-	if (p)
-		memset(p, 0, sizeof(*p));
-	return p;
+	return kzalloc(sizeof(struct vmcore), GFP_KERNEL);
 }
 
 static u64 __init get_vmcore_size_elf64(char *elfptr)

Thanks
Vivek