Skip to contentSkip to conversation

pci hotplug: adding __init/__exit macros to sgi_hotplug

PATCH Applied Peter Hüwe 2 participants 3 messages Jun 6, 2009 – Jun 8, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pci hotplug: adding __init/__exit macros to sgi_hotplug

From: Peter Huewe <[email protected]>

Trivial patch which adds the __init and __exit macros to the module_init / module_exit functions from drivers/pci/hotplug/sgi_hotplug.c linux version 2.6.30-rc8

---

drivers/pci/hotplug/sgi_hotplug.c renamed from drivers/pci/hotplug/sgi_hotplug.c.orig +2 -2
diff -up linux-2.6.30-rc8/drivers/pci/hotplug/sgi_hotplug.c{.orig,}
@@ -679,7 +679,7 @@ alloc_err:
 	return rc;
 }
 
-static int sn_pci_hotplug_init(void)
+static int __init sn_pci_hotplug_init(void)
 {
 	struct pci_bus *pci_bus = NULL;
 	int rc;
@@ -716,7 +716,7 @@ static int sn_pci_hotplug_init(void)
 	return registered = 1 ? 0 : -ENODEV;
 }
 
-static void sn_pci_hotplug_exit(void)
+static void __exit sn_pci_hotplug_exit(void)
 {
 	struct hotplug_slot *bss_hotplug_slot;
 
Applied
#1 lore raw

Re: [PATCH] pci hotplug: adding __init/__exit macros to

Quoted 3 lines · Peter Hüwe

Trivial patch which adds the __init and __exit macros to the module_init / module_exit functions from drivers/pci/hotplug/sgi_hotplug.c linux version 2.6.30-rc8

Applied, thanks Peter.

Signature · 2 lines
Jiri Kosina
SUSE Labs
#2 lore raw
In reply to Peter Hüwe

Am Montag 08 Juni 2009 11:57:07 schrieb Jiri Kosina:

Quoted 2 lines
Quoted 1 line

Trivial patch which adds the __init and __exit macros

Applied, thanks Peter.

Thank you too - as it was my first 'official' kernel patch, do you have any remarks?
And there are a lot of missing __init / __exit in the kernel - shall I fix them or is isn't worth the effort?

Peter Huewe