Skip to contentSkip to conversation

sensord: Some cleanups,

PATCH In review Andre Prendel 2 participants 3 messages May 11, 2009 – Jun 9, 2009

lore
Share & tools
lore
#0 lore raw

v2 cover sensord: Some cleanups,

Hello Jean,

here is the updated patch series according to your notes. Thanks for your careful review.

There is much work left. I will go on with cleanups in further patches (see the note in patch 1/7). I've dropped patch 2/8.

You can see the changes in the changelog of every patch under "Changes in v2".

Thanks,
Andre

---
 args.c    |  177 +++++++++++++++++++++-----------------------------------------
 args.h    |   30 ++++++++++
 lib.c     |   74 +++++++++++++------------
 rrd.c     |  110 +++++++++++++++++++-------------------
 sense.c   |    6 +-
 sensord.c |  103 +++++++++++++++++++++---------------
 sensord.h |   18 ------
 7 files changed, 246 insertions(+), 272 deletions(-)

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Hi Andre,

Quoted 8 lines · Andre Prendel

Hello Jean,

here is the updated patch series according to your notes. Thanks for your careful review.

There is much work left. I will go on with cleanups in further patches (see the note in patch 1/7). I've dropped patch 2/8.

Quoted 8 lines

You can see the changes in the changelog of every patch under "Changes in v2".

Thanks,
Andre

---
 args.c    |  177 +++++++++++++++++++++-----------------------------------------
 args.h    |   30 ++++++++++

While you have committed your patches by now, this file is nowhere to be seen in SVN. I suspect you forgot to "svn add" the file? Please do now, so that sensord builds again.

Quoted 6 lines
 lib.c     |   74 +++++++++++++------------
 rrd.c     |  110 +++++++++++++++++++-------------------
 sense.c   |    6 +-
 sensord.c |  103 +++++++++++++++++++++---------------
 sensord.h |   18 ------
 7 files changed, 246 insertions(+), 272 deletions(-)

Thanks,

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw
In reply to Andre Prendel
Quoted 20 lines · Jean Delvare

Hi Andre,

Quoted 8 lines · Andre Prendel

Hello Jean,

here is the updated patch series according to your notes. Thanks for your careful review.

There is much work left. I will go on with cleanups in further patches (see the note in patch 1/7). I've dropped patch 2/8.

Quoted 8 lines

You can see the changes in the changelog of every patch under "Changes in v2".

Thanks,
Andre

---
 args.c    |  177 +++++++++++++++++++++-----------------------------------------
 args.h    |   30 ++++++++++
Quoted 3 lines

While you have committed your patches by now, this file is nowhere to be seen in SVN. I suspect you forgot to "svn add" the file? Please do now, so that sensord builds again.

Sorry for late response. Yes, you're right. I missed adding the file. I've just done it.

Quoted 9 lines
Quoted 7 lines
 lib.c     |   74 +++++++++++++------------
 rrd.c     |  110 +++++++++++++++++++-------------------
 sense.c   |    6 +-
 sensord.c |  103 +++++++++++++++++++++---------------
 sensord.h |   18 ------
 7 files changed, 246 insertions(+), 272 deletions(-)

Thanks,

Thanks for report.

Andre

Quoted 2 lines
Signature · 1 line
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors