Skip to contentSkip to conversation

rfkill: include err.h

PATCH In review Johannes Berg 3 participants 4 messages Jun 9, 2009 – Jun 10, 2009 Rfkill

lore
Share & tools
lore

Johannes Berg

author maintainer
#0 lore raw

PATCH 1/1 rfkill: include err.h

Since we use ERR_PTR and similar macros, we need to include linux/err.h.

---
 include/linux/rfkill.h |    1 +
 1 file changed, 1 insertion(+)
include/linux/rfkill.h +1 -0
@@ -105,6 +105,7 @@ enum rfkill_user_states {
 #include <linux/mutex.h>
 #include <linux/device.h>
 #include <linux/leds.h>
+#include <linux/err.h>
 
 /* this is opaque */
 struct rfkill;
#1 lore raw

From: Johannes Berg <[email protected]>
Date: Tue, 09 Jun 2009 15:56:52 +0200

Quoted 3 lines

Since we use ERR_PTR and similar macros, we need to include linux/err.h.

I'm applying this directly to net-next-2.6 to fix the -next build.

Please submit the more critical build fixes for regressions introduced by the wireless tree direclty to me in the future thanks.

#2 lore raw
Quoted 5 lines · David Miller

From: Johannes Berg <[email protected]>
Date: Tue, 09 Jun 2009 15:56:52 +0200

Quoted 2 lines

Since we use ERR_PTR and similar macros, we need to include linux/err.h.

Quoted 8 lines
Quoted 1 line

I'm applying this directly to net-next-2.6 to fix the -next build.

Please submit the more critical build fixes for regressions introduced by the wireless tree direclty to me in the future thanks.

That's a fine policy -- no objection. However, please be aware that Stephen picks-up stuff from the wireless trees even when I haven't yet asked Dave to pull (so Dave might not always have the patch that causes the break). So, just keep that in mind (and CC me as well, please). :-)

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
author maintainer
#3 lore raw
Quoted 15 lines · John W. Linville
Quoted 5 lines · David Miller

From: Johannes Berg <[email protected]>
Date: Tue, 09 Jun 2009 15:56:52 +0200

Quoted 2 lines

Since we use ERR_PTR and similar macros, we need to include linux/err.h.

Quoted 8 lines
Quoted 1 line

I'm applying this directly to net-next-2.6 to fix the -next build.

Please submit the more critical build fixes for regressions introduced by the wireless tree direclty to me in the future thanks.

Quoted 5 lines

That's a fine policy -- no objection. However, please be aware that Stephen picks-up stuff from the wireless trees even when I haven't yet asked Dave to pull (so Dave might not always have the patch that causes the break). So, just keep that in mind (and CC me as well, please). :-)

Alright, I'll do my best to differentiate based on what's in whose tree :)

johannes